Re: Web IDL review checklist updated

2017-04-03 Thread Kyle Huey
On Mon, Apr 3, 2017 at 9:07 AM, Boris Zbarsky wrote: > I just updated https://wiki.mozilla.org/WebAPI/WebIDL_Review_Checklist to > remove some no-longer relevant bits and add various new parts. > > The primary audience for this document are people doing Web IDL reviews > (bcced; you can see the li

Re: nsIAtom has been deCOMtaminated and is now called nsAtom

2017-10-08 Thread Kyle Huey
Awesome! You couldn't get to mozilla::Atom? - Kyle On Oct 8, 2017 7:27 PM, "Nicholas Nethercote" wrote: > Greetings, > > I have been deCOMtaminating nsIAtom over the past two months: > https://bugzilla.mozilla.org/show_bug.cgi?id=1392883. > > A big step that landed over a week ago was the devi

Re: Please use nsGlobalWindow{Inner,Outer}

2017-11-10 Thread Kyle Huey
On Fri, Nov 10, 2017 at 8:41 AM, Nika Layzell wrote: > Hey, > > Bug 1414974 (https://bugzilla.mozilla.org/show_bug.cgi?id=1414974) is in > mozilla-central, and it introduces the nsGlobalWindowInner and > nsGlobalWindowOuter types. These represent inner and outer nsGlobalWindow > objects, and can b

Re: MozPromises are now in XPCOM

2015-08-19 Thread Kyle Huey
On Tue, Aug 18, 2015 at 8:17 PM, Bobby Holley wrote: > I gave a lightning talk at Whistler about MozPromise and a few other new > tools to facilitate asynchronous and parallel programming in Gecko. There > was significant interest, and so I spent some time over the past few weeks > untangling them

Re: MozPromises are now in XPCOM

2015-08-19 Thread Kyle Huey
On Wed, Aug 19, 2015 at 2:04 PM, Bobby Holley wrote: > On Wed, Aug 19, 2015 at 1:39 PM, Kyle Huey wrote: >> >> Does MozPromise have the same "skipping the event loop" behavior that >> JS promises have? > > > They do not. > >> >> Or is that

Re: MozPromises are now in XPCOM

2015-08-19 Thread Kyle Huey
On Wed, Aug 19, 2015 at 5:23 PM, Bobby Holley wrote: > On Wed, Aug 19, 2015 at 2:12 PM, Kyle Huey wrote: >> >> On Wed, Aug 19, 2015 at 2:04 PM, Bobby Holley >> wrote: >> > On Wed, Aug 19, 2015 at 1:39 PM, Kyle Huey wrote: >> >> >> >>

Re: CloseFile() latency on Windows

2015-09-28 Thread Kyle Huey
We recently dealt with something similar in Gecko. See https://bugzilla.mozilla.org/show_bug.cgi?id=1152046 - Kyle On Mon, Sep 28, 2015 at 2:41 PM, Gregory Szorc wrote: > As part of profiling a Python process on Windows using Process Monitor.exe, > I noticed that closing file handles using Clos

Re: Disabling C++ tests by default?

2015-10-01 Thread Kyle Huey
How much time does it save? - Kyle On Thu, Oct 1, 2015 at 10:10 PM, Gregory Szorc wrote: > Currently, the Firefox build system builds C++ tests by default. This adds > extra time to builds for something that a significant chunk of developers > don't care about because they don't run them. > > An

Intent to ship: IDB getAll/getAllKeys/openKeyCursor

2015-10-14 Thread Kyle Huey
I intend to ship the following features in Gecko 44: IDBObjectStore.getAll IDBObjectStore.getAllKeys IDBObjectStore.openKeyCursor IDBIndex.getAll IDBIndex.getAllKeys These features will be available on all platforms and are specced at [0]. The bug tracking this work is [1]. Some of these featur

Re: mozilla::RefPtr is dead, long live ::RefPtr

2015-10-18 Thread Kyle Huey
Huzzah! When are you going to do nsCOMPtr? ;) - Kyle On Sun, Oct 18, 2015 at 7:43 AM, Nathan Froyd wrote: > Hi all, > > Bug 1207245 has landed on mozilla-central. Its main purpose in life is to > unify mozilla::RefPtr and nsRefPtr (both of which live in MFBT) into a > single RefPtr class. Thi

Re: mozilla::RefPtr is dead, long live ::RefPtr

2015-10-18 Thread Kyle Huey
I meant removing the ns prefix (i.e. s/nsCOMPtr/COMPtr/), which is the net effect of this change for places that previous used nsRefPtr, AIUI. - Kyle On Sun, Oct 18, 2015 at 8:24 AM, Boris Zbarsky wrote: > On 10/18/15 11:11 AM, Kyle Huey wrote: >> >> When are you going

Re: Question: why an external DTD is accessed (or not)? (svg11.dtd)

2015-11-21 Thread Kyle Huey
Bug 994305 is on file for this. - Kyle On Sat, Nov 21, 2015 at 10:57 AM, ISHIKAWA,chiaki wrote: > Hi, > > I have been puzzled at a pair of strange warning messages over the last few > years, but can't hold the curiosity any longer. > > So here is my question. > > During the invocation of TB |mak

nsThread now leaks runnables if dispatch fails

2016-01-04 Thread Kyle Huey
(This is a continuation of the discussion in bug 1218297) In bug 1155059 we made nsIEventTarget::Dispatch take an already_AddRefed instead of a raw pointer. This was done to allow the dispatcher to transfer its reference to the runnable to the thread the runnable will run on. That solves a race

Re: nsThread now leaks runnables if dispatch fails

2016-01-05 Thread Kyle Huey
The "race condition" here is the question of which thread the runnable destructor runs on. If the executing thread is already shut down the destructor still runs on the "wrong" dispatching thread (or not at all). Since the point of fixing the original race is to guarantee that the destructor runs

Re: nsThread now leaks runnables if dispatch fails

2016-01-05 Thread Kyle Huey
On Mon, Jan 4, 2016 at 4:10 PM, Randell Jesup wrote: >>Kyle Huey writes: >> >>> (This is a continuation of the discussion in bug 1218297) >>> >>> In bug 1155059 we made nsIEventTarget::Dispatch take an >>> already_AddRefed instead of a raw pointe

dump() calls now available in NSPR logging

2016-01-07 Thread Kyle Huey
In Bug 1059469 I added a logging module for calls to dump() on Window and WorkerGlobalScope. You can enable it with NSPR_LOG_MODULES="Dump:5". This is really handy when you're using other logging modules and want to see how content script execution fits into the logging output. - Kyle __

Re: dump() calls now available in NSPR logging

2016-01-07 Thread Kyle Huey
It would not be hard to add to the message manager and XPConnect. Patches welcome :) - Kyle On Thu, Jan 7, 2016 at 9:32 PM, Kan-Ru Chen (陳侃如) wrote: > Kyle Huey writes: > > > In Bug 1059469 I added a logging module for calls to dump() on Window > > and WorkerGlobalScope.

Re: Feedback needed on proposal to add a web primitive for queuing microtasks

2016-01-13 Thread Kyle Huey
In principle, I don't see any reason not to do this. - Kyle On Wed, Jan 13, 2016 at 1:59 PM, Boris Zbarsky wrote: > Please see https://github.com/whatwg/html/issues/512 > > Right now this is in the "does anyone have an objection to the basic > idea?" stage. So if someone does, please speak up!

Re: Proposal to stop revving UUIDs when changing XPIDL interfaces

2016-01-15 Thread Kyle Huey
As the XPIDL module owner, I support this. - Kyle On Fri, Jan 15, 2016 at 7:58 AM, Ehsan Akhgari wrote: > Historically we have enforced updating the XPIDL interface UUIDs when you > made any changes to it. This was needed because of two reasons: > > * Backwards compatibility with binary extens

Re: Dominator tree memory analysis now in Nightly

2016-01-15 Thread Kyle Huey
This is awesome. We've talked about how much we've wanted this since the early days of MemShrink back in 2011. Thanks to everyone who was involved. - Kyle On Thu, Jan 14, 2016 at 1:50 PM, Nick Fitzgerald wrote: > Hi folks! > > Dominator trees give you fine-grained insight into memory retentio

Splitting inner and outer windows

2016-01-21 Thread Kyle Huey
Early in the next release cycle I plan to land a patch that will remove nsPIDOMWindow in favor of two separate types for inner and outer windows (fittingly, called nsPIDOMWindowInner/nsPIDOMWindowOuter) I'll also make changes to the XPIDL interface hierarchy (effectively removing nsIDOMWindow and

Re: Splitting inner and outer windows

2016-01-22 Thread Kyle Huey
s far as JS is concerned)? Querying for > nsIDOMWindow is something add-ons do a lot and I'd expect to see a lot > of add-ons break if we changed that. > > On Thu, Jan 21, 2016 at 9:52 PM, Kyle Huey wrote: > > Early in the next release cycle I plan to land a patch that will re

Re: Splitting inner and outer windows

2016-01-22 Thread Kyle Huey
On Fri, Jan 22, 2016 at 11:24 AM, Bobby Holley wrote: > > > On Thu, Jan 21, 2016 at 9:52 PM, Kyle Huey wrote: > >> Early in the next release cycle I plan to land a patch that will remove >> nsPIDOMWindow in favor of two separate types for inner and outer windo

Re: IndexedDB access in third-party iFrames disabled or not?

2016-01-25 Thread Kyle Huey
We changed this in bug 1147821. It looks like the documentation hasn't been updated. - Kyle On Mon, Jan 25, 2016 at 10:26 AM, wrote: > Is IndexedDB supposed to be accessible in third-party iFrames? From what I > understand, the MDN documentation says IndexedDB is *not* accessible in > third-pa

Re: IndexedDB access in third-party iFrames disabled or not?

2016-01-25 Thread Kyle Huey
.org || MDN > cmi...@mozilla.com || @chrisdavidmills > > > On 25 Jan 2016, at 18:35, Kyle Huey wrote: > > > > We changed this in bug 1147821. It looks like the documentation hasn't > > been updated. > > > > - Kyle > > > > On Mon, Jan 25, 2016

Re: Bug Program Next Steps

2016-01-29 Thread Kyle Huey
On Fri, Jan 29, 2016 at 3:45 PM, Emma Humphries wrote: > We believe that the number of outstanding, actionable bugs is the best > metric of code quality available, and that how this number changes over > time will be a strong indicator of the evolving quality of Firefox. > Why do we believe that

Re: Splitting inner and outer windows

2016-01-30 Thread Kyle Huey
This has landed (and stuck) on inbound. - Kyle On Thu, Jan 21, 2016 at 9:52 PM, Kyle Huey wrote: > Early in the next release cycle I plan to land a patch that will remove > nsPIDOMWindow in favor of two separate types for inner and outer windows > (fittingly, called nsPIDOMWi

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
Are you using it from JS or C++? If you're using it from JS, nothing has changed. - Kyle On Wed, Feb 10, 2016 at 4:32 PM, Devan Shah wrote: > Hello > > nsIDOMWindow is deprecated now according to: > https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMWindow >

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
Wed, Feb 10, 2016 at 4:40 PM, Devan Shah wrote: > I am using it from c++ > > On Wed, Feb 10, 2016 at 7:38 PM, Kyle Huey wrote: > >> Are you using it from JS or C++? If you're using it from JS, nothing has >> changed. >> >> - Kyle >> >

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
45.0b4.sdk.zip> > > On Wed, Feb 10, 2016 at 7:43 PM, Kyle Huey wrote: > >> Ok ... ignoring the question of how you're using it from C++ since binary >> addons are gone, many of the methods on nsIDOMWindow moved to nsPIDOMWindow >> and then to nsPIDOMWindowIn

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
So makes it all not compatible. > > Is there any way I can rebuild the Firefox SDK with the old nsIDOMWindow > > On Wed, Feb 10, 2016 at 7:51 PM, Kyle Huey wrote: > >> Yeah, ok, nsPIDOMWindow then. >> >> - Kyle >> >> On Wed, Feb 10, 2016 at 4:49 PM

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
Ok. I thought we killed binary components in extensions ... There will be a lot of changes around windows and their XPIDL interfaces in Gecko over the next while so you should expect to have to update this code fairly frequently if you're actually calling methods on nsIDOMWindow. - Kyle On Wed,

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
Alright, just QueryInterface between nsIDOMWindow and nsPIDOMWindow when you have one and need the other and you should be fine. - Kyle On Wed, Feb 10, 2016 at 5:15 PM, Devan Shah wrote: > Currently I just want to get it up and running again on FF 45 again, with > out making too much changes be

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
= 0; > NS_IF_RELEASE(rootWebShell); > NS_IF_RELEASE(docShell); > NS_IF_RELEASE(window); > // return status; > } > > On Wed, Feb 10, 2016 at 8:16 PM, Kyle Huey wrote: > >> Alright, just QueryInterface between nsIDOMWindow and nsPIDOMWindow when >> you ha

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
::UpdateCurrentURI(this); > return NS_OK; > } > > So here just changing nsCOMPtr to nsCOMPtr > and using QueryInterface should do the trick right? > > Also I am using a function called SizeToContent() from nsIDOMWindow which > I do not see exists any more in nsPIDOMWi

Re: nsIDOMWindow is deprecated now is there an alternative?

2016-02-10 Thread Kyle Huey
ow)); > } > if (domWindow != topDomWindow) > isSubFrameLoad = PR_TRUE; > } > if (!isSubFrameLoad) > CWebBrowserChromeUI::UpdateCurrentURI(this); > return NS_OK; > } > > On Wed, Feb 10, 2016 at 8:30 PM, Kyle Huey wrote: > >> Yes

Re: Suggesting new name for nsIDOMEvent::GetInternalNSEvent

2016-02-10 Thread Kyle Huey
What's wrong with AsWidgetEvent? We do AsFoo a fair bit. - Kyle On Feb 10, 2016 8:58 PM, "Aidin Gharibnavaz" wrote: > In Bug 1235830 , I'm > going to rename this method to something more meaningful. I need suggestion > about what the name sho

Re: Using rr chaos mode to find intermittent bugs

2016-02-11 Thread Kyle Huey
On Thu, Feb 11, 2016 at 11:35 AM, Robert O'Callahan wrote: > On Thu, Feb 11, 2016 at 11:55 PM, Nicolas B. Pierron < > nicolas.b.pier...@mozilla.com> wrote: > > > On 02/10/2016 08:04 PM, Robert O'Callahan wrote: > > > >> Background: > >> http://robert.ocallahan.org/2016/02/introducing-rr-chaos-mod

Re: rr chaos mode update

2016-02-14 Thread Kyle Huey
On Sun, Feb 14, 2016 at 9:16 PM, Robert O'Callahan wrote: > Over the last few days we have had a lot of positive experiences > reproducing bugs with rr chaos mode. Kyle tells me that, in fact, he's been > able to reproduce every single bug he tried with enough machine time thrown > at it. > Of f

Re: rr chaos mode update

2016-02-14 Thread Kyle Huey
On Sun, Feb 14, 2016 at 9:37 PM, L. David Baron wrote: > On Sunday 2016-02-14 21:26 -0800, Kyle Huey wrote: > > On Sun, Feb 14, 2016 at 9:16 PM, Robert O'Callahan > wrote: > > > Over the last few days we have had a lot of positive experiences > > > reprod

Re: rr chaos mode update

2016-02-15 Thread Kyle Huey
Seems like a good thing to expect developers to do locally today. - Kyle On Mon, Feb 15, 2016 at 6:08 PM, Justin Dolske wrote: > On 2/14/16 9:25 PM, Bobby Holley wrote: > > How far are we from being able to use cloud (rather than local) machine >> time to produce a trace of an intermittently-fa

Re: rr chaos mode update

2016-02-15 Thread Kyle Huey
rr runs fine under VMWare ;) - Kyle On Mon, Feb 15, 2016 at 6:18 PM, Bobby Holley wrote: > On Mon, Feb 15, 2016 at 6:15 PM, Kyle Huey wrote: > >> Seems like a good thing to expect developers to do locally today. >> > > I don't think that's realistic

Intent to implement and ship: IDBKeyRange.includes()

2016-02-26 Thread Kyle Huey
*Summary*: This simple API allows one to test whether a given key is included in an IDBKeyRange *Bug*: https://bugzilla.mozilla.org/show_bug.cgi?id=1251498 *Link to standard*: http://w3c.github.io/IndexedDB/#dom-idbkeyrange-includes *Platform coverage*: All platforms *Estimated or target release*:

Re: Exit code -11 must die

2016-02-29 Thread Kyle Huey
On Mon, Feb 29, 2016 at 9:03 AM, Benjamin Smedberg wrote: > On 2/27/2016 9:06 PM, Randell Jesup wrote: > >> months until recently it popped up a bit). Note that this failure >> *never* results in a crashdump, and I've never seen it locally, just in >> Automation. >> > > What we do know: > > * E

Re: call prompt service dynamically

2016-03-08 Thread Kyle Huey
You're probably just not linking to the xpcom glue library in eclipse/gcc. - Kyle On Tue, Mar 8, 2016 at 8:33 PM, Tobias Wolf wrote: > We`re develping a PKCS11 modul in c/c++ for a custom card reader to > support. I just want to display a simple dialog. The code below works great > until I stay

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-03-10 Thread Kyle Huey
On Fri, Mar 11, 2016 at 2:03 AM, Benjamin Smedberg wrote: > This is notice of an intent to deprecate support within Firefox for the > following old versions of MacOS: 10.6, 10.7, and 10.8 > > The motivation for this change is that we have continued failures that are > specific to these old operat

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-03-12 Thread Kyle Huey
On Fri, Mar 11, 2016 at 4:28 PM, Terrence Cole wrote: > We need to drop support for OSX 10.8 and Windows Vista yesterday, not next > year. We need to cut our losses and ship E10S while we're still relevant. > We need to be the browser that works best on Android and Windows 10, not > the browser t

Re: On nsICancelableRunnable (or how bad decisions come back to haunt you)

2016-03-13 Thread Kyle Huey
On Fri, Mar 11, 2016 at 7:04 AM, Gabriele Svelto wrote: > Many moons ago, while we were frantically trying to make Firefox OS 1.0 > run half-decently, I introduced a derived class of nsIRunnable that > could be canceled: nsICancelableRunnable. As with many other things that > led to the first re

Re: Proposal: revisit and implement navigator.hardwareConcurrency

2016-03-14 Thread Kyle Huey
On Mon, Mar 14, 2016 at 2:30 PM, Ehsan Akhgari wrote: > On 2016-03-14 3:23 PM, Boris Zbarsky wrote: > > On 9/8/15 3:21 PM, Luke Wagner wrote: > >> On a more technical detail: WebKit and Chromium have both shipped, > >> returning the number of logical processors where WebKit additionally > >> clam

Re: The convention to pass a parameter when ownership transfer is optional

2016-03-19 Thread Kyle Huey
Conceptually already_AddRefed is a move reference. And it's destructor asserts (in debug builds) that the reference was indeed moved, so it cannot be used as a conditional transfer under any circumstances. - Kyle On Thu, Mar 17, 2016 at 8:07 PM, wrote: > > https://hg.mozilla.org/mozilla-centra

Introducing MOZ_ALWAYS_SUCCEEDS

2016-03-29 Thread Kyle Huey
For when you are too lazy to type MOZ_ALWAYS_TRUE(NS_SUCCEEDS(foo)). This was added in bug 1259294, which merged to mozilla-central this morning. - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-

Removing the Chromium event loop

2016-03-30 Thread Kyle Huey
In the department-of-paying-down-technical-debt, I'm planning to remove much of the Chromium event loop over the next few months. You can follow along in bug 1260828. The rough outline: Step 1: Replace Task with nsIRunnable, without changing any other semantics. This will happen in late April, a

Re: Removing the Chromium event loop

2016-03-30 Thread Kyle Huey
On Wed, Mar 30, 2016 at 11:34 AM, Benjamin Smedberg wrote: > I support this plan! > > Mostly. > > I've been unhappy with the fact that our event loop uses refcounted > objects by default. *Most* runnables are pure-C++ and really don't need to > be refcounted/scriptable. > > I'm asking you to cons

Re: Removing the Chromium event loop

2016-03-30 Thread Kyle Huey
On Wed, Mar 30, 2016 at 1:11 PM, Nathan Froyd wrote: > On Wed, Mar 30, 2016 at 2:34 PM, Benjamin Smedberg > wrote: > > I've been unhappy with the fact that our event loop uses refcounted > objects > > by default. *Most* runnables are pure-C++ and really don't need to be > > refcounted/scriptable

Re: Removing the Chromium event loop

2016-03-31 Thread Kyle Huey
On Thu, Mar 31, 2016 at 6:43 AM, Nathan Froyd wrote: > On Thu, Mar 31, 2016 at 8:08 AM, Gabriele Svelto > wrote: > > On this topic, did anyone experiment with trying to lighten the > > synchronization burden when handling nsEventQueues? Both nsThread and > > nsThreadPool acquire a mutex each tim

Re: Removing the Chromium event loop

2016-03-31 Thread Kyle Huey
On Thu, Mar 31, 2016 at 3:19 AM, Honza Bambas wrote: > On 3/30/2016 20:21, Kyle Huey wrote: > >> In the department-of-paying-down-technical-debt, I'm planning to remove >> much of the Chromium event loop over the next few months. You can follow >> along in bug 126

Re: Crash signature change: signatures now include abort messages

2016-04-06 Thread Kyle Huey
Does this catch MOZ_RELEASE_ASSERT and similar? It would be nice to distinguish those somehow in crash-stats. - Kyle On Wed, Apr 6, 2016 at 2:18 PM, Benjamin Smedberg wrote: > A change just landed which will change the way crash signatures are > computed for intentional aborts. Previously the

Re: Intent to ship: Treat cookies set over non-secure HTTP as session cookies

2016-04-14 Thread Kyle Huey
Why should we be the ones to take the web compat hit on this? - Kyle On Apr 14, 2016 1:55 AM, "Chris Peterson" wrote: > Summary: Treat cookies set over non-secure HTTP as session cookies > > Exactly one year ago today (!), Henri Sivonen proposed [1] treating > cookies without the `secure` flag a

Re: Moving XP to ESR?

2016-04-18 Thread Kyle Huey
12% of our users are on Windows XP. - Kyle On Mon, Apr 18, 2016 at 6:04 AM, Henri Sivonen wrote: > XP has now gone for two years without security patches from Microsoft. > Additionally, as of its latest release, Chrome no longer supports XP. > > When 46 ships, it would be a great time to make A

Re: Moving XP to ESR?

2016-04-19 Thread Kyle Huey
On Tue, Apr 19, 2016 at 1:20 PM, Ted Mielczarek wrote: > On Tue, Apr 19, 2016, at 04:14 PM, Nils Ohlmeier wrote: > > The good news is that dxr does not find anything using IsXPSP3OrLater(). > > But this looks like we have a bit of version specific code in our tree: > > > https://dxr.mozilla.org/m

Re: Proposal: use nsresult& outparams in constructors to represent failure

2016-04-20 Thread Kyle Huey
On Wed, Apr 20, 2016 at 9:52 PM, Kris Maglione wrote: > On Thu, Apr 21, 2016 at 02:10:59PM +1000, Nicholas Nethercote wrote: > >> On Thu, Apr 21, 2016 at 1:23 PM, Kris Maglione >> wrote: >> >>> >>> If we do this, can we please use |nsresult*| rather than |nsresult&|? >>> >> >> I prefer a referen

nsRunnable is now mozilla::Runnable on trunk

2016-04-25 Thread Kyle Huey
Sometime later this week Task will become Runnable too. - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Static analysis for "use-after-move"?

2016-04-27 Thread Kyle Huey
Can we catch this pattern with a compiler somehow? Foo foo; foo.x = thing; DoBar(mozilla::Move(foo)); if (foo.x) { /* do stuff */ } - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

NS_New*RunnableMethod* -> New*RunnableMethod

2016-04-28 Thread Kyle Huey
NS_NewRunnableMethod has been replaced with mozilla::NewRunnableMethod. NS_NewRunnableMethodWithArg[s] has also been collapsed into mozilla::NewRunnableMethod. It also now returns an already_AddRefed. The Chromium versions of these methods have been removed. NS_NewRunnableFunction still survives

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Kyle Huey
On Fri, Apr 29, 2016 at 1:46 PM, Chris Peterson wrote: > On 4/29/16 5:53 AM, Nathan Froyd wrote: > >> This is a noble goal, but there is an enormous amount of code that >> would need to be modified to make this feasible. Perhaps if you >> exempted nsresult from MOZ_MUST_USE types. >> > > In theo

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-05-05 Thread Kyle Huey
On Thu, May 5, 2016 at 8:23 PM, wrote: > On Tuesday, May 3, 2016 at 8:32:26 PM UTC-7, Lawrence Mandel wrote: > > On Tue, May 3, 2016 at 11:11 PM, Xidorn Quan > wrote: > > > > > On Wed, May 4, 2016 at 9:46 AM, Lawrence Mandel > > > wrote: > > > > > >> On Tue, May 3, 2016 at 6:56 PM, Mike Hommey

Re: Reverting to VS2013 on central and aurora

2016-05-06 Thread Kyle Huey
I think we should strongly consider just requiring SSE at this point. - Kyle On Fri, May 6, 2016 at 7:10 AM, Mike Hoye wrote: > On 2016-05-06 12:26 AM, Gregory Szorc wrote: > >> FWIW, the crashes we've seen so far are from incorrectly emitted movss >> instructions. This instruction is part of t

Re: Ignoring viewpoints of non-Mozilla-employees can't be the way to go for a OSS project!

2016-05-09 Thread Kyle Huey
Because you are *still* (as of 10 minutes ago) removing the off-topic labels that were applied to clearly off-topic comments I have temporarily removed your editbugs permissions. - Kyle On Mon, May 9, 2016 at 11:23 AM, Tobias B. Besemer < tobias.bese...@googlemail.com> wrote: > Hi! > > Ignoring

Is Telemetry::Accumulate threadsafe?

2016-05-11 Thread Kyle Huey
And if not, why is this not documented? - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Is Telemetry::Accumulate threadsafe?

2016-05-11 Thread Kyle Huey
65 made it thread-safe, bug 1258183 is dealing with some > remaining TSan issues. > > Georg > > On Wed, May 11, 2016 at 7:23 PM, Kyle Huey wrote: > >> And if not, why is this not documented? >> >> - Kyle >> ___

Re: Updating 32-bit Windows users to 64-bit Windows builds?

2016-05-12 Thread Kyle Huey
On Thu, May 12, 2016 at 2:46 PM, Karl Tomlinson wrote: > Lawrence Mandel writes: > > > Do we need this criteria? > > > > RAM - Does it hurt to move an instance that has <4GB? > > Yes. OOM will be more common with 64-bit builds on systems with > less RAM because 64-bit builds use more memory. >

Chromium and XPCOM event queues are now unified

2016-05-12 Thread Kyle Huey
On inbound (and soon central), for Chromium MessageLoops that belong to an XPCOM thread (either the main thread, or created via the thread manager) posting tasks now calls through to the underlying XPCOM thread's dispatch implementation. This could cause subtle breakage because event ordering has

Re: Windows 7 tests in AWS

2016-05-13 Thread Kyle Huey
On Fri, May 13, 2016 at 11:07 AM, Chris AtLee wrote: > I'm very happy to let you know that we've recently started running some of > our Windows 7 tests in AWS. Currently we're running these suites in Amazon > for all branches of gecko 49 and higher: > * Web platform tests + reftests > * gtest > *

Re: How to name our JSContext getter(s): let the bikeshed begin

2016-05-29 Thread Kyle Huey
Do we really need the ForThread part? Is the long term plan to merge JSRuntime and JSContext, or are they going to remain distinct indefinitely? - Kyle On Sun, May 29, 2016 at 6:10 PM, Boris Zbarsky wrote: > We currently have the following functions in nsContentUtils for getting > various JSCon

Re: How to name our JSContext getter(s): let the bikeshed begin

2016-05-30 Thread Kyle Huey
On Sun, May 29, 2016 at 6:21 PM, Boris Zbarsky wrote: > On 5/29/16 6:17 PM, Kyle Huey wrote: >> >> Do we really need the ForThread part? > > > I wanted to make it clear that we're getting something that's OK to use > without synchronization, but maybe that

Re: Non-standard stuff in the /dom/ directory

2016-08-16 Thread Kyle Huey
On Tue, Aug 16, 2016 at 8:56 PM, wrote: > I'm wondering, would it be worth while cleaning up the dom/ directory to move > non-standard stuff out of there? > > There is a bunch of legacy stuff from B2G that could be moved out to, say, > b2g/apis or some such for historical reasons. > > It would

Re: Getting rid of already_AddRefed?

2016-09-12 Thread Kyle Huey
On Mon, Sep 12, 2016 at 10:53 AM, Daniel Holbert wrote: > On 08/12/2014 07:59 AM, Benjamin Smedberg wrote: >> But now that nsCOMPtr/nsRefPtr support proper move constructors, [...] >> Could we replace every already_AddRefed return value with a nsCOMPtr? > > I have a variant of bsmedberg's original

Re: removing about:bloat

2016-10-10 Thread Kyle Huey
On Mon, Oct 10, 2016 at 2:07 PM, Andrew McCreight wrote: > In bug 1308652, I'm planning on removing about:bloat. It disables XPCOM > leak tracking while it is running, so running it can cause false negative > leaks (bug 1271182). I don't think anybody uses it much any more, so I'm > going to remov

Re: Windows XP and Vista Long Term Support Plan

2016-10-21 Thread Kyle Huey
On Fri, Oct 21, 2016 at 3:05 AM, wrote: > My point for the above paragraph is that even if Mozilla stops security > updates for ESR 52, these computers will still need to get around on the > Internet. These machines will still need to do log ins and banking. The world > isn't the same as back

Re: Runnable labeling for Quantum DOM

2016-12-01 Thread Kyle Huey
On Thu, Dec 1, 2016 at 8:21 PM, Boris Zbarsky wrote: > P.S. This is awesome. ;) Indeed. So glad this is finally happening. - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

DOM Bindings Meeting - Monday @ 12:30 PM PST

2013-02-25 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday February 25th at 12:30 PM PST. Meeting details: * Monday, February 25, 2012, 12:30 PM PST (9:30 PM CET) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: SFO-7N - In office or soft phone: extens

Re: Windows 7 Platform Update & June 2010 SDK

2013-02-27 Thread Kyle Huey
On Wed, Feb 27, 2013 at 5:33 AM, Gian-Carlo Pascutto wrote: > Hi all, > > just a heads up: the Windows 7 platform update that's being shipped > today has the following KB article: > http://support.microsoft.com/kb/2670838?wa=wsignin1.0 > > Interesting part: > "If you are a Windows 7 DirectX develo

DOM Bindings Meeting - Monday @ 12:30 PM PST

2013-03-04 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday March 4th at 12:30 PM PST. Meeting details: * Monday, March 4, 2012, 12:30 PM PST (9:30 PM CET) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: SFO-7N - In office or soft phone: extension 92

Re: Turning off window.Components for the web

2013-03-05 Thread Kyle Huey
On Tue, Mar 5, 2013 at 11:33 AM, Bobby Holley wrote: > This makes sense in terms of |if (Components)| browser detection. But if a > site is grabbing interface constants off of nsIDOMFoo interfaces, it seems > very unlikely that said site would work in another browser. The other > problem with shi

Reminder: NSPR synchronization primitives are not to be used

2013-03-06 Thread Kyle Huey
This is a friendly reminder that you should not be using NSPR synchronization primitives in new Gecko code unless you have a very good reason to. We built all these nice wrappers on them that provide deadlock checking, RAII, leak checking, etc. that you should use instead. Instead of PRLock - use

Re: ChromeWorkers and staying off the Main thread

2013-03-14 Thread Kyle Huey
On Thu, Mar 14, 2013 at 7:08 AM, wrote: > Hi all, > > To what extent is the Main thread consumed by a (Chrome)Workers > postMessage() and onmessage() calls to other Sub(Chrome)Workers? > > Specifically, if a sub-worker postMessage()s to it's listening parent > Worker, and the parent Worker posts

Re: ChromeWorkers and staying off the Main thread

2013-03-14 Thread Kyle Huey
On Thu, Mar 14, 2013 at 8:31 AM, wrote: > On Thursday, 14 March 2013 14:19:57 UTC, Kyle Huey wrote: > > > > > > > > Message passing from a worker to a sub-worker (or vice versa) only > involves > > > > the worker thread and the sub-worker thread. > &

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-03-18 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday March 18th at 12:30 PM PDT. Note the time change. Meeting details: * Monday, March 18, 2012, 12:30 PM PDT (8:30 PM CET) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: SFO-7N - In office or s

Re: Automatic tree clobbering is coming

2013-03-29 Thread Kyle Huey
On Fri, Mar 29, 2013 at 9:47 PM, Philip Chee wrote: > I'm running Windows7 and the mozilla-build system. We *have* to use > relative paths because some parts of mozilla-build (I can't remember > which) would choke on absolute paths. > Unless there's some problem with comm-central specifically, t

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-04-01 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday April 1st at 12:30 PM PDT. Note the time change for Europe. Meeting details: * Monday, April 1, 2013, 12:30 PM PDT (9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: SFO-7N - In o

The current state of WARNINGS_AS_ERRORS is untenable

2013-04-03 Thread Kyle Huey
(Ignoring whether or not WARNINGS_AS_ERRORS is a good idea, ignoring whether or not having it disabled by default on developer builds but enabled on automation is a good idea, ignoring whether or not we can deal with the tendency of gcc to lurch from complaining incessantly about one silly thing to

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-04-08 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday April 8th at 12:30 PM PDT. Meeting details: * Monday, April 8, 2013, 12:30 PM PDT (9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: SFO-7N - In office or soft phone: extension 92

Re: Preparing for the next windows PGO build memory exhaustion

2013-04-13 Thread Kyle Huey
On Sat, Apr 13, 2013 at 8:40 AM, Asa Dotzler wrote: > I have a really basic question. Is PGO's performance gains something users > are actually going to notice or are we mostly talking about synthetic > benchmark pissing contests here? As we saw when we accidentally disabled it the other day, i

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-04-15 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday April 15th at 12:30 PM PDT. Meeting details: * Monday, April 15, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: SFO-7N - In office or soft phone:

Re: Rethinking the amount of system JS we use in Gecko on B2G

2013-04-22 Thread Kyle Huey
The things on Justin's list do not appear to be infrequently running code. Wifi, RIL, Apps, mozbrowser, etc are going to be running all the time. - Kyle On Mon, Apr 22, 2013 at 7:11 AM, Andreas Gal wrote: > JS is a big advantage for rapid implementation of features and it's > easier to avoid e

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-04-22 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday April 22th at 12:30 PM PDT. Meeting details: * Monday, April 22, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: SFO-7N - In office or soft phone:

Re: Accelerating exact rooting work

2013-04-23 Thread Kyle Huey
On Tue, Apr 23, 2013 at 8:18 AM, Ehsan Akhgari wrote: > Can the stuff in objdir/dom/bindings be fixed whole-sale by changing the > WebIDL codegen? > Yes. bz is looking into it. - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https:

Re: Storage in Gecko

2013-04-26 Thread Kyle Huey
On Fri, Apr 26, 2013 at 11:17 AM, Gregory Szorc wrote: > I'd like to start a discussion about the state of storage in Gecko. > > Currently when you are writing a feature that needs to store data, you > have roughly 3 choices: > > 1) Preferences > 2) SQLite > 3) Manual file I/O > > Preferences are

Re: Storage in Gecko

2013-04-26 Thread Kyle Huey
On Fri, Apr 26, 2013 at 11:43 AM, Gregory Szorc wrote: > On 4/26/2013 11:26 AM, Kyle Huey wrote: > > On Fri, Apr 26, 2013 at 11:17 AM, Gregory Szorc wrote: > >> I'd like to start a discussion about the state of storage in Gecko. >> >> Currently when you

Re: Storage in Gecko

2013-04-26 Thread Kyle Huey
Resending to list. On Fri, Apr 26, 2013 at 12:02 PM, Gregory Szorc wrote: > On 4/26/2013 11:52 AM, Kyle Huey wrote: > > Could you please point me at a "good" implementation of a Gecko consumer > of IndexedDB? If you don't know which are good, an MXR search URL wil

  1   2   3   4   >