Gijs Kruitbosch writes:
>> What if it causes a regression and a blocking bug needs to be filed?
> Then you file a bug and needinfo the person who landed the commit
> (which one would generally do anyway, besides just marking it
> blocking the regressor).
I find the association of multiple regress
Kartikaya Gupta writes:
> On Wed, Mar 8, 2017 at 4:01 PM, wrote:
>> In the past I have not always been made aware when my tests were disabled,
>> which has lead to me feeling jaded.
>
> We have a process (in theory) that ensures the relevant people get
> notified of tests. The process involves t
I would like to see failure rates expressed as a ratio of failures
to test runs, but I recognise that this data may not be readily
available and getting it may not be that important if we have a
rough idea. These are a means for setting priorities, and so a
rank works well.
If we have 100 tests,
zbranie...@mozilla.com writes:
> * I still have only 8GB of ram which is probably the ultimate
> limiting factor
You are right here. RAM is required not only for link time, but
also when compiling several large unified files at a time (though
perhaps this is not so significant with only 4 core
> It'd make me feel slightly less sad that we're disabling tests
> that do their job 90% of the time...
The way I interpret a test failing 10% of the time is that either
it has already done its job to indicate a problem in the product,
or the test is not doing its job.
Either way, if it is not go
Benjamin Smedberg writes:
> This is not the list for this question. Please respect this question to the
> firefox-dev list.
https://wiki.mozilla.org/Firefox/firefox-dev says "Anyone can post. By
default, posts will be reviewed by a moderator before being sent to the list."
bit in fact some unclea
had it been posted to firefox-dev, would very clearly be
> on-topic and not rejected.
>
> Justin
>
> On Wed, Mar 22, 2017 at 7:35 PM, Karl Tomlinson wrote:
>
>> Benjamin Smedberg writes:
>>
>> > This is not the list for this question. Please respect this q
Nathan Froyd writes:
> I think a broader definition of "POD struct" would be required here:
> RefPtr and similar are technically not POD, but I *think* you'd
> want to require RefPtr* arguments when you expect the smart pointer
> to be assigned into? Not sure.
Yes, please, for similar reasons as
On Sat, 20 May 2017 14:59:11 -0400, Eric Rescorla wrote:
> On Sat, May 20, 2017 at 1:16 PM, Kris Maglione
> wrote:
>
>> On Sat, May 20, 2017 at 08:36:13PM +1000, Martin Thomson wrote:
>>
>>> Hmm, these are all -Wsign-compare issues bar one, which is fixed
>>> upstream. We have an open bug tracki
Andrew McCreight writes:
> On Fri, May 19, 2017 at 7:38 PM, Nicholas Nethercote > wrote:
>
>> There's also a pre-processor constant that we define in Valgrind/ASAN/etc.
>> builds that you can check in order to free more stuff than you otherwise
>> would. But I can't for the life of me remember wha
I assume this was integrated with OrangeFactor?
That is the only way I know to determine whether an intermittent
failure has occurred, because failures are not necessarily
reported to bugzilla.
Is there a mechanism for tracking a failure that we intend to
addresss, even when it does not fail ever
I don't know how well GConf is supported by more recent GNOME
versions. I assume GSettings support was added to
nsUnixSystemProxySettings because GConf was to be no longer
supported, but the crash reporter uses separate code.
https://bugzilla.mozilla.org/show_bug.cgi?id=1388897
http://searchfox.
Zibi Braniecki writes:
> On Tuesday, November 7, 2017 at 2:54:45 AM UTC-8, pa...@paul.cx wrote:
>> I'm using this setup daily (with clang trunk from some weeks ago, not
>> 5.0, but it's the same really), here is my mozconfig:
>>
>> ```
>> export CC="icecc clang"
>> export CXX="icecc clang++"
>> m
I've always found this confusing, and so I'll write down the
understanding I've reached, in the hope that either it will help
others, or others can help me by correcting if these are
misunderstandings.
On Unix systems:
`nativePath`
contains the bytes corresponding to the native filename u
> On Thu, Nov 30, 2017 at 11:09:07AM +1300, Karl Tomlinson wrote:
>> The native bytes may not be valid UTF-8, and so if the
>> character encoding is UTF-8, then there may not be a valid
>> `path` that can be encoded to produce the same `nativePath`.
Kris Maglione
=Summary/benefits:
"The AudioWorklet object allows developers to supply scripts
(such as JavaScript or WebAssembly code) to process audio on the
rendering thread, supporting custom AudioNodes." [[Concepts]]
Allowing scripts to process audio on the rendering thread is
important for low latency g
Boris Zbarsky writes:
> On 5/2/18 5:21 AM, Karl Tomlinson wrote:
>> [[AudioNode Lifetime]] https://github.com/WebAudio/web-audio-api/issues/1471
>
> I've read through that thread, but I'm still a little unclear on
> where thing stand. With the latest proposa
to
fix it.
> If there is no difference in observable behavior, what would a
> normative requirement mean?
Good question. I will find that useful at some point.
> Karl Tomlinson wrote:
>> If the whole normative AudioNode lifetime section were dropped
>> then this would clearl
On Fri, 4 May 2018 14:32:20 -0400, Boris Zbarsky wrote:
> On 5/4/18 3:34 AM, Karl Tomlinson wrote:
>> Not sure I understand your question, but the observable behavior
>> described by this section, or specifically "Before an AudioNode is
>> deleted, it will discon
Steven Englehardt writes:
> While it may have been
> theoretically possible for all trackers to gather statistics on video
> playback for each configuration, the only scripts that could practically
> carry out those attacks without degrading user experience would have been
> video providers. This
On Fri, 18 May 2018 13:13:04 -0400, Chris AtLee wrote:
> IMO, it's not reasonable to keep CI builds around forever, so the question
> is then how long to keep them? 1 year doesn't quite cover a full ESR cycle,
> would 18 months be sufficient for most cases?
>
> Alternatively, we could investigate
On Fri, 13 Apr 2018 10:22:06 -0400, Boris Zbarsky wrote:
> On 4/13/18 9:37 AM, Emilio Cobos Álvarez wrote:
>> Would people agree to use:
>>
>> , mIsRootDefined { false }
>>
>> Instead of:
>>
>> , mIsRootDefined{ false }
>
> So my take is that we should not use braced initializer syntax in
> co
Is there a guideline that should be used to evaluate what can
acceptably run in the same process for different sites?
I assume the primary goal is to prevent one site from reading
information that should only be available to another site?
There would also be defense-in-depth value from having eac
Is there a plan to avoid the contrast problems we have mixing
document colors with system colors in other widgets?
e.g. If one scrollbar color is specified by the document, then what ensures
that other parts of the scrollbar are visually distinct?
Does the computed value of the other scrollbar co
Thanks very much for answering some of my questions for me.
Xidorn Quan writes:
> On Wed, Jul 25, 2018, at 6:29 PM, Karl Tomlinson wrote:
>> Is there a plan to avoid the contrast problems we have mixing
>> document colors with system colors in other widgets?
>>
>> e.g
Xidorn Quan writes:
>> Would the color for the auto property be derived in such as way as
>> to hide the thumb or to make it constrast?
>
> No, currently we don't derive them from each other. We simply use some
> fallback color in that case.
How is the fallback color chosen?
> It is not impossib
Mark Côté writes:
> On August 20, we will remove public access to MozReview and archive
> patches. Every landed, in-progress, and abandoned patch will be downloaded
> from MozReview and stored in an S3 bucket. The “stub attachments” in
> Bugzilla that currently redirect to MozReview will be update
Jonas Sicking writes:
> On Sun, Aug 2, 2015 at 3:47 AM, Xidorn Quan wrote:
>> Probably we should generally avoid using constructor directly for
>> those cases. Instead, use helper functions like MakeUnique() or
>> MakeAndAddRef(), which is much safer.
>
> We used to have NS_NewFoo() objects all o
On Mon, 27 Jul 2015 21:35:20 +1200, Karl Tomlinson wrote:
> Sometimes it would be nice to check in crashtests that use, or
> attempt to use large memory allocations, but I'm concerned that
> checking in these crashtests could disrupt subsequent tests
> because there is then not
On Fri, 16 Oct 2015 10:31:43 -0700, Gregory Szorc wrote:
> But as awesome as
> these targets are, they can still build more than is desired (especially in
> the edit .h file case). This slows down iteration cycles and slows down
> developers.
>
> For this reason, I think dumbmake needs to remain o
David Rajchenbach-Teller writes:
> To improve the Performance Stats API, I'm looking for a way to find out
> if we are currently animating something on the main thread.
>
> My definition of animating is pretty large, i.e. "will the user probably
> notice if some computation on the main thread last
Kartikaya Gupta writes:
> Personally I much prefer the new approach to reporting intermittents.
> It's much easier for me to see at a glance (i.e when the bugs are
> updated with the weekly count) which ones are actually occurring more
> frequently and which bug would be best to spend time on. Wit
Kyle Huey writes:
> (This is a continuation of the discussion in bug 1218297)
>
> In bug 1155059 we made nsIEventTarget::Dispatch take an
> already_AddRefed instead of a raw pointer. This was done to allow the
> dispatcher to transfer its reference to the runnable to the thread the
> runnable wil
Xidorn Quan writes:
> On Wed, Jan 6, 2016 at 3:53 AM, Kyle Huey wrote:
>> On Mon, Jan 4, 2016 at 4:10 PM, Randell Jesup wrote:
>>>
>>> Yup. In cases where we anticipate a possible Dispatch failure (which is
>>> supposed to become impossible, but isn't currently) you can use the
>>> (still-exist
Xidorn Quan writes:
> On Thu, Jan 7, 2016 at 6:47 AM, Karl Tomlinson wrote:
>> Xidorn Quan writes:
>>
>>> You can keep a raw pointer yourself, and release it manually after you
>>> find the dispatch fails, like what is done in
>>> NS_DispatchToCurrentThr
Boris Zbarsky writes:
> On 1/23/16 9:48 PM, Mike Hommey wrote:
>> Note that if /other/ changes from other bugs have happened to the same
>> files between the last reviewed iteration and the rebase before landing,
>> the interdiff will show them without any kind of visual cues.
>
> Ah, that's unfor
On Fri, 22 Jan 2016 14:24:38 -0500, Ehsan Akhgari wrote:
> What about the case where the information doesn't exist in the
> repository because the author, for example, cherry-picked a
> specific commit on a throw-away branch because the rest of the
> dependencies are still being worked on? Or, as
Mike Hommey writes:
> On Mon, Jan 25, 2016 at 11:23:59AM -0800, Steve Fink wrote:
>> Heh. Your list of UI complaints is very similar to mine. Some comments:
>>
>>
>> On 01/25/2016 04:26 AM, Honza Bambas wrote:
> Also, iirc, when you reply diff comments in MozReview, the resulting
> comments sent
>> On 25/01/16 05:44 PM, Eric Rescorla wrote:
>> >On Mon, Jan 25, 2016 at 1:58 PM, Mike Hommey wrote:
>> >
>> >>It's also painful to use MozReview's comment system. The comments in the
>> >>reviews pane don't show much diff context, and while I just realized
>> >>it's possible to make it show more
Honza Bambas writes:
> On 1/25/2016 20:23, Steve Fink wrote:
>> For navigation, there's a list of changed files at the top
>> (below the fixed summary pane) that jumps to per-file anchors.
>
> Not good enough for review process.
>
>> Are you saying you want tabs or something for this (like
>> spl
Felipe G. writes:
> Yeah, --e10s enables e10s in the browser for mochitest-chrome. However,
> the test harness is a .xul file opened in a tab, and that runs that tab as
> non-remote, so for most tests it ends up testing the same thing as not
> using --e10s. Other tabs and/or windows opened manual
Eric Rescorla writes:
> I don't believe I am asking for this, just auto-squash on submit. I
> certainly understand if it's your position that you have higher priorities,
> that's fine, but it's not fine to remove the ability to do squashed reviews
> before something like that lands.
Perhaps the d
Thanks for the info, Mark.
In the mean time, at least, it would make interdiffs easiest to
read if patch authors can submit updates to patches against the
same revision as the original patches.
If that causes too much inconvenience (and it will sometimes),
then separate pushes for the rebase and
libxul.so is dlopen()ed from the firefox process.
That firefox process would already have a libc.so.6, I assume, and
so I would not expect libxul.so to load another libc.so.6.
That seems to be confirmed here by running
strace -e trace=file firefox/firefox
See whether something different is hap
Daniel Minor writes:
> Summary: This provides an alternative to using BiquadFilterNode when
> odd-order filters are required or automation is not needed. It is part of
> the Web Audio spec and is already implemented in Blink.
Thanks for looking at this, Daniel.
I fear that high order filters are
Xidorn Quan writes:
> I think this specific case should actually use UniquePtr& rather
> than && in parameter for conditional move, so that callsite can only pass
> in an lvalue, and we don't need a Move there.
Jim Blandy writes:
> TakeMediaIfKnown is accepting a
> UniquePtr as an inout paramete
Thanks for the replies, Dan and Roy.
A first order filter node with AudioParam inputs seems a likely
future addition AFAIK.
Even with that though, having a way to apply a custom biquad
without needing to decompose into multiple textbook filters is
useful I think. And I agree that implementing th
Cross-posting to mozilla.dev.tech.mathml so that this is seen by
people who are interested.
Please follow-up to mozilla.dev.platform.
Henri Sivonen writes:
> We ship data tables for converting from Unicode to HTML entities.
> These tables obviously take space. (They are not optimized for space
>
Lawrence Mandel writes:
> Do we need this criteria?
>
> RAM - Does it hurt to move an instance that has <4GB?
Yes. OOM will be more common with 64-bit builds on systems with
less RAM because 64-bit builds use more memory.
___
dev-platform mailing list
Could the lack of failure emails be specific to taskcluster jobs?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8c6ab15dd8f
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
> Could the lack of failure emails be specific to taskcluster jobs?
https://bugzilla.mozilla.org/show_bug.cgi?id=1275774
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
William Lachance writes:
> As part of a larger effort to improve the experience around
> debugging intermittents, I've been looking at reducing the time it
> takes for common "try" workloads for developers (so that
> e.g. retriggering a job to reproduce a failure can happen faster).
> Also, accou
On Fri, 19 Aug 2016 17:05:30 -0400, Eric Shepherd wrote:
> I'm trying to update the table of scan codes and the keys they go with here:
>
> https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code#Code_values_on_Linux_(X11)_(When_scancode_is_available)
>
> But the values in that table f
Aryeh Gregor writes:
> On Tue, Oct 25, 2016 at 8:12 PM, Anne van Kesteren wrote:
>> The basic problem is prompting the user at all for non-HTTPS since
>> that leads them to think they can make an informed decision whereas
>> that's very much unclear. So prompting more would just make the
>> probl
Gregory Szorc writes:
> When the autoland repository was introduced, it was advised to not pull
> from this repository because we plan to do rewrites like this frequently in
> the future. So if this rewriting impacted your local repo and you aren't a
> sheriff, you should consider changing your wo
Gregory Szorc writes:
> On Wed, Nov 30, 2016 at 12:40 PM, Karl Tomlinson wrote:
>> When history is rewritten, is there a way to view the original
>> history through the web interface, so that autoland tinderbox
>> builds can be used to find regression ranges?
>
> No.
Nicholas Nethercote writes:
> Warnings about possibly dubious but common practices aren't much use.
> I gave up on turning on -Wshadow for this reason,
If you could now use |index| as a variable name, would it be worth
revisiting -Wshadow?
http://gcc.gnu.org/gcc-4.8/changes.html
Paul Rouget writes:
> The Firefox OS Simulator is a XulRunner instance run
> from Firefox. Two processes, two windows, two different
> version of gecko.
>
> It would be very useful if we could display the simulator
> as part of Firefox. Inside a tab.
Under X11, the XEmbed protocol was designed fo
Axel Hecht writes:
> On 8/8/13 5:17 PM, Jonathan Kew wrote:
>> On 8/8/13 15:17, Axel Hecht wrote:
>>> Couter example seems to be Chinese, the unagi shows something, while my
>>> tool reports 13k missing glyphs for zh-TW.
>> If we're using Droid Sans Fallback, I believe it supports somewhere well
Axel Hecht writes:
> On 8/8/13 10:45 PM, Karl Tomlinson wrote:
>> Axel Hecht writes:
>>
>>> On 8/8/13 5:17 PM, Jonathan Kew wrote:
>>>> On 8/8/13 15:17, Axel Hecht wrote:
>>>>> Couter example seems to be Chinese, the unagi shows something, while
On Fri, 09 Aug 2013 13:51:45 +0200, Axel Hecht wrote:
> To clarify, the tool does support either .name. or .name-list. at
> this point. Is there a code path or a setup where we have for any
> language/family both a .name. and a .name-list. entry?
>
> I.e.
>
> pref("font.name.serif.zh-TW", "Times")
ishikawa writes:
> - Has anyone have mode-line (or .emacs) setting to make the indentation in
> Emacs to follow the prefered style?
I've got by so-far with M-x set-variable js-indent-level 2 when
necessary, but this doesn't automatically become buffer-local, so
I find myself manually changing b
Bill McCloskey writes:
> # Silence ++THIS and --THAT
> export MOZ_QUIET=1
>
> # Silence NS_WARNING
> export MOZ_IGNORE_WARNINGS=1
>
> then you won't get any more messages about DOM windows or
> docshell creation/destruction or about NS_WARNINGs firing.
Thanks very much, Bill. I think I'll also f
Gregory Szorc writes:
> Just landed in inbound is a mass conversion of mochitests to use manifests.
When adding a new test, the process used to be:
1. add new file path/to/test/directory/new-file
2. add "new-file" to MOCHITEST_FILES in path/to/test/directory/Makefile.in
3. make -C obj/path/to/te
Marco writes:
> The bug has regressed a lot of things. To me it looks like the
> decision to land it was a bit rushed.
I can't help wondering whether the feature was needed urgently on
b2g, and the people involved just didn't care enough if getting
that done quickly also damaged desktop products.
Jeff Walden writes:
> On 10/15/2013 06:06 PM, Benjamin Smedberg wrote:
>
> That means sync I/O on the main thread, and not well-optimized because it
> won't be part of the binary. Just to note.
When sync I/O is performed to read in-binary-object data, how is
that better?
Just readahead?
Wouldn'
Matt Brubeck writes:
> On 10/15/2013 1:36 PM, al...@yahoo.com wrote:
>> Why are these ignored?
> As to whether we should pull someone off of other tasks to focus
> on these XP text-rendering bugs, that's tricky.
> So in some cases we might need to choose between speed and
> subpixel rendering.
Nicholas Cameron writes:
> Currently on Linux our only 'supported' graphics backend is the
> main-thread software backend (basic layers).
FWIW basic layers is predominantly GPU-based compositing
(not-softwared) on most X11 systems.
> 5) We would love to spend time making OMTC OpenGL on Linux wor
Andreas Gal writes:
> Its not a priority to fix Linux/X11. We will happily take
> contributed patches, and people are welcome to fix issues they
> see, as long its not at the expense of the things that matter.
Do bugs in B2G Desktop on Linux/X11 matter?
I assume glitches and perf issues that are
Andreas Gal writes:
> On Nov 7, 2013, at 1:48 PM, Karl Tomlinson wrote:
>
>> Andreas Gal writes:
>>
>>> Its not a priority to fix Linux/X11. We will happily take
>>> contributed patches, and people are welcome to fix issues they
>>> see, as long its
Andreas Gal writes:
> On Nov 7, 2013, at 3:06 PM, "L. David Baron" wrote:
>
>> On Thursday 2013-11-07 13:24 -0800, Andreas Gal wrote:
>>> On Nov 7, 2013, at 1:19 PM, Karl Tomlinson wrote:
>>>> Will any MoCo developers be permitted to spend some time fi
For the sake of WebGL, GL compositing is most likely the preferred
backend for Linux/X11. Basic layers with Render compositing is
available as a fallback for those without sufficient GL support.
Our goal for X11 should be OMTC GL compositing. Adding OMTC
support for X11 basic layers will addre
Gregory Szorc writes:
> Do we need periodic clobber? It's just wallpapering over legit
> clobber-needed issues, which doesn't exactly help us fix them.
The problem is that unfixed bugs in dependences mean that code
bugs can sometimes not show up until the next clobber. There is
then a huge regre
Henri Sivonen writes:
> On *nix platforms, it's not clear to me what exactly the platform
> charset is used for these days. An MXR search turns up surprisingly
> little.
> * Do we (or gtk) really still support non-UTF-8 platform charset
> values on *nix? (MXR turns up so little that it makes me
Lawrence Mandel writes:
> - Original Message -
>> On 27/11/13 07:36, Gabriele Svelto wrote:
>> > I'm always tempted to close the former as duplicates of the
>> > actual fix and the latter as WONTFIX so that they won't show
>> > up on the following searches but I'm also afraid that closing
Nicholas Nethercote writes:
> - When a job times out, the output produced by Valgrind is
> usually chopped off in the middle of a line. In fact, it's
> often chopped off in the middle of a line that would have been
> produced by a single write() system call. So it feels like the
> test harness i
Nicholas Nethercote writes:
> We've had some recent discussions about code style. I have a propasal
I'm sceptical about the value of such changes out-weighing the
cost here. I know there will be a cost now and in the future, but
I don't recall seeing any entire files so badly formatted that it
t
Martin Thomson writes:
> I would like to think that adding (or removing) braces from block statements
> should be acceptable.
I would argue that braces should not be added with automation.
When debugging code, it is important to understand the intent of
the author. Adding braces at parser-deter
smaug writes:
> Why this deprecation?
NS_ENSURE_ macros hid return paths.
Also many people didn't understand that they issued warnings, and
so used the macros for expected return paths.
Was there some useful functionality that is not provided by the
replacements?
___
Gregory Szorc writes:
> I think you just gave an example of why our tooling needs to
> identify poorly formatted code better. An "if" without a brace
> followed by multiple indented lines containing compiler
> expressions is a bug at worst or unreadable/unclear code at
> best. We could, of course,
L. David Baron writes:
> I tend to think that we should either:
> * stick to 80
> * require no wrapping, meaning that comments must be one paragraph
>per line, boolean conditions must all be single line, and assume
>that people will deal, using an editor that handles such code
>usefu
Bobby Holley writes:
> Note that there in a explicit stylistic exception that NS_WARN_IF
> statements do not require braces. So it's:
>
> if (NS_WARN_IF(NS_FAILED(rv)))
> return rv;
I don't see that on the current version of
https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style
Chris Peterson writes:
> If mozilla-central is reformatted, that would be a good time to
> also remove the modelines.
> 5. Remove modelines from mozilla-central files
I'm happy with removal of modelines provided .dir-locals.el files
are added to provide the same functionality.
There is imported
Anthony Jones writes:
> There is also some vagueness and inconsistency around:
>
> bool
> MyClass::MyFunction()
>
> vs
>
> bool MyClass::MyFunction()
>
> Most of the code seems to do this only for top-level functions i.e. when
> not already indented. I'd like some clarification on the rule here. I
On Tue, 21 Jan 2014 12:27:12 -0500, Jeff Muizelaar wrote:
> [...] OS X supports drawing subpixel-AA to partially
> transparent surfaces. I believe the amount of sub pixel AA depends on the
> alpha of the surface. (Imagine drawing sub-pixel aa text to a transparency
> group to get an idea of how th
Daniel Holbert writes:
> On 02/27/2014 10:26 AM, Zack Weinberg wrote:
>> Does that mean a patch to squelch the uninitialized variable
>> warnings in layout will now be accepted? Those are the only
>> warnings in layout on my (Linux, debug) builds.
>>
>>> layout/base/FrameLayerBuilder.cpp:3462:56
On Thu, 13 Mar 2014 12:46:14 -0400, Erik Rose wrote:
> A lot of you have asked for the ability to select and share ranges within
> source files. Now, thanks to contributor Jamon Carmisso, you can:
>
> http://dxr.mozilla.org/mozilla-central/source/content/media/AbstractMediaDecoder.h#7-13
>
> As on
Erik Rose writes:
> Once we have request-time rendering of indexed content, it will
> be a lot more straightforward to fetch and render arbitrary revs
> out of version control the same way. We just won't have
> analysis—only syntax coloring—since we won't have time to build
> the whole project dur
Ehsan Akhgari writes:
> On 2014-03-19, 10:50 PM, Boris Zbarsky wrote:
>> On 3/19/14 10:40 PM, Ehsan Akhgari wrote:
>>> Why do we have to touch that list on shutdown?
>>
>> We Release() all the things in it (nsIWeakReferences in this case).
>
> Well, that was sort of my point (gotta work on my styl
Jason Orendorff writes:
> On 3/24/14, 2:42 AM, K. Gadd wrote:
>
> There are two collectors.
>
> The JS engine's garbage collector runs more frequently.
> The XPCOM cycle collector runs less often.
That may be true in some scenarios, but I sometimes observe the
cycle collector running more freque
Neil writes:
> I tried to push a patch which changes the DOM of the HTML
> directory listing page but it tripped over this assertion while
> running an RTL test.
>
> It seems to be something to do with the reflow caused by the
> loading of the icons on an RTL directory listing page.
>
> What's th
Jason Orendorff writes:
> If the code is truly unreachable, it doesn't matter what we replace it
> with. The question is what to do when the impossible occurs. To me,
> letting control flow past such a place is just as scary as undefined
> behavior.
That depends on the particular code. Often eno
Zack Weinberg writes:
> This is a bit of a tangent, but: There are a whole bunch of places in
> layout, and probably elsewhere, where we have the following catch-22:
> if you have a switch statement over the values of an enumeration, gcc
> and clang (with -Wall) will warn you about enumeration val
Karl Tomlinson writes:
> Jason Orendorff writes:
>
>> If the code is truly unreachable, it doesn't matter what we replace it
>> with. The question is what to do when the impossible occurs. To me,
>> letting control flow past such a place is just as scary as undefined
Benjamin Smedberg writes:
> I think in general we should be willing to make more of our
> assertions fatal in release builds, especially in
> non-performance-sensitive code. Of course the choice of assertion
> depends on the characteristics of what's being asserted.
Sounds good.
_
On Fri, 04 Apr 2014 11:03:57 -0400, Zack Weinberg wrote:
>> On Tue, Apr 1, 2014 at 10:13 PM, Karl Tomlinson
>> wrote:
>>> Does WARNINGS_AS_ERRORS make the default:MOZ_CRASH()
>>> unnecessary?
>>
>> No, because it's possible that the thing you&#x
On Fri, 4 Apr 2014 12:49:45 -0700 (PDT), jmaher wrote:
>> overburdened in other ways (e.g., reviews). the burden
>> needs to be placed on the regressing change rather than the original
>> author of the test.
>
> I am open to ideas to help figure out the offending changes. My
> understanding is m
On Fri, 4 Apr 2014 11:58:28 -0700 (PDT), jmaher wrote:
> Two exceptions:
> 2) When we are bringing a new platform online (Android 2.3, b2g, etc.) many
> tests will need to be disabled prior to getting the tests on tbpl.
It makes sense to disable some tests so that others can run.
I assume bugs
chiaki ISHIKAWA writes:
> (2014/04/07 10:16), Karl Tomlinson wrote:
>> because enumeration types may hold values that don't match any of
>> their enumerator values.
>
> Is this allowed by C (or C++) specification today?
It is allowed in N3242. I think the relevant
chiaki ISHIKAWA writes:
> I think 7.2 10 is also relevant here.
>
> --- quote ---
> An expression of arithmetic or enumeration type can be converted
> to an enumeration type explicitly. The
> value is unchanged if it is in the range of enumeration values of
> the enumeration type; otherwise the re
1 - 100 of 169 matches
Mail list logo
