On 22/03/2017 2:34 PM, Botond Ballo wrote:
Now that this change has hit the release channel, we've started
receiving feedback from a wider range of users, a lot of it in bug
1345661 [1].
I believe the feedback in that thread brings some new information to
the table that we weren't aware of when
You may already know that the Low-Level Tools team support important tools and
code infrastructure. Lately we’ve also been improving our rustc/clang (LLVM)
story and I’d like bring everyone up to date.
There are a lot of important and interesting things going on:
* Michael Woerister and Nat
On Friday, 11 May 2018 21:14:21 UTC+12, Sylvestre Ledru wrote:
> Do we have a list of blockers (or meta bug) to make the switch on Linux?
We're already using clang for ASAN builds on Linux and passing tests. We'll
want to switch to clang on Linux pretty soon after getting it running on
Windows,
You may already know that the Low-Level Tools team support important tools and code infrastructure. Lately we’ve also been improving our rustc/clang (LLVM) story and I’d like bring everyone up to date.
There are a lot of important and interesting things going on:
On Wednesday, 30 May 2018 08:48:12 UTC+12, Jeff Gilbert wrote:
> It would be sad to see us standardize on a clang monoculture.
It pays not to be sentimental about tools. We get better practicality and
productivity by focusing on clang. Using the same compiler across all platforms
means that we
On Thursday, 31 May 2018 02:44:51 UTC+12, Tom Ritter wrote:
> Oh. Are we doing this rustc inlining development on a particular old
> version of clang? I'm not even close to getting CFI ready but I'm
> basically working off llvm trunk as I'm finding and filing llvm bugs
> and working with llvm de
On Thursday, 12 July 2018 15:50:40 UTC+12, halivi...@gmail.com wrote:
> I hope that both Firefox and Chrome continue to keep the build and tests
> running on MSVC. It would suck if for example we can't build Firefox with
> MSVC.
I can't comment on Chrome.
> Will the Firefox team publish builds
On Friday, 13 July 2018 11:26:07 UTC+12, Jörg Knobloch wrote:
> On 10/07/2018 22:29, David Major wrote:
> > Bug 1443590 is switching our official Windows builds to use clang-cl
> > as the compiler.
> >
> > Please keep an eye out for regressions and file a blocking bug for
> > anything that might b
I'm chuffed to announce that Web Replay has finally made its way into nightly.
It brings tardis like functionality (or perhaps rr like) to Firefox Devtools,
enabling recording and replaying of tab behavior, and best of all, stepping
backwards and running backwards. This could be transformative f
On Tuesday, 31 July 2018 03:38:00 UTC+12, mte9...@gmail.com wrote:
> I am waiting a lot this feature but I am a Linux user so I cannot try it.
To be clear: this is not a feature, it is a proof of concept.
> So I tried to add the flag on Linux and see what happens.
> Adding 'devtools.recordreplay
My understanding is that the reason people stick to 10.6 is because
of Rosetta[1] which offers PowerPC compatibility.
https://en.wikipedia.org/wiki/Rosetta_(software)
Chrome is dropping support for these platforms so it seems like an
opportunity to pick up some
On 27/02/13 03:07, Milan Sreckovic wrote:
> "Large amount of work" - sure, but it is sort of independent, in that you
> wouldn't expect to touch a lot of code elsewhere, so it should be easy from
> the merging point of view.
>
> Milan
While adding the DrawTarget and Path is separate, the fonts
On 06/03/13 11:55, Robert O'Callahan wrote:
> On Wed, Mar 6, 2013 at 8:54 AM, Gavin Sharp wrote:
> Bustage detection rate isn't just a function of the user populations on
> each channel; it's also a function of time. Six months of testing on beta
> is better than six weeks. I don't know how much b
On 28/03/13 10:03, Justin Lebar wrote:
>> Since we believe if we go through with this it would be the first time we
>> use a true subrepository system for a component
>> used in mozilla-central, we'd very much appreciate any thoughts or feedback
>> people might have on the idea.
>
> Have you tho
On 11/04/13 15:23, Gregory Szorc wrote:
> Mercurial and Git both support the ability to attach arbitrary key-value
> string data to commits. There is an abundance of awesomeness that could
> be realized if we started storing [machine readable] information inside
> our commits (not inside the commit
On 25/05/13 04:16, Ehsan Akhgari wrote:
> On 2013-05-24 11:46 AM, Benoit Girard wrote:
> Another option is to use clang-format, which can lexically parse diff
> files.
A pre-upload check would give the fastest feedback.
It would help me (and those who review my code) if there is an easy way
to ch
On 30/05/13 04:55, Mike Hommey wrote:
> As someone that will soon be in UTC+9, and taking on the occasion to
> represent all the people in that timezone and surroundings, a couple
> hours before 3am is not very a great time to decide whether I'd attend
> or not. That being said, I haven't attended
On 19/06/13 16:02, Robert O'Callahan wrote:
> I believe that in Webkit you're not supposed to call "new" directly.
> Instead you call a static "create" method that returns the equivalent of
> already_AddRefed.
Do they have a lint checker we can use for that?
_
On 18/07/13 12:00, Gregory Szorc wrote:
> Since new Makefile.in badness makes people's lives harder (especially
> when it makes the build slower), I would like to propose a more strict
> policy around Makefile.in changes: *if a non-list change in a
> Makefile.in isn't reviewed by a build peer, it d
On 21/09/13 17:58, Robert O'Callahan wrote:
> I don't think that's necessarily true on Windows. If we can find a way to
> generate Visual Studio projects and use those to build, or do most of the
> build, we can probably go a lot faster than using cl command-line
> invocations compiling one file pe
On 23/09/13 16:49, Robert O'Callahan wrote:
> I see how compiling several files in the same cl invocation would mess
> up using /showincludes to track dependencies, making this difficult to
> fix. The only possibility I can think of for fixing this is to emit a
> Visual Studio project and make the
On 20/12/13 11:55, Mike Hommey wrote:
> On Thu, Dec 19, 2013 at 11:02:08AM -0500, Ehsan Akhgari wrote:
>> clang-format has a basic support for the Mozilla coding style, and we can
>> definitely extend it to add support for this heuristic.
>
> I don't think we should care about having a Mozilla-sp
On 20/12/13 14:35, Jeff Gilbert wrote:
> How do patches get fully-reviewed if the sum-knowledge of the
> reviewers doesn't include whether the style's right? Alternatively,
> who is signing off on the content of code, having in-depth knowledge
> of how it works, but not knowing the style? That soun
I have been doing some testing with clang-format and formatting only the
lines that have been modified.
Version 3.5 is good enough for Mozilla style although the defaults for
style=Mozilla need to be corrected. It doesn't handle weird cases like
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN and _END block
clang-format-3.5 is now available for Windows using the updated patch in
bug 952379.
Anthony
On 08/01/14 15:31, Anthony Jones wrote:
> I have been doing some testing with clang-format and formatting only the
> lines that have been modified.
>
> Version 3.5 is good enough for M
On 08/01/14 11:49, Nicholas Nethercote wrote:
> If you're just distinguishing members, then |foo_| is good. But if
> you're distinguishing parameters and globals/statics as well (which I
> think is a good idea), then mFoo/aFoo/gFoo/sFoo makes more sense.
If you want to be precise you would use thi
On 09/01/14 06:57, Adam Roach wrote:
> Automated wrapping to a column width is less than optimal. If you look
> back at bz's example about how he would chose to wrap a specific
> conditional, it's based on semantic intent, not the language syntax. By
> and large, this goes to author's intent and hi
On 08/01/14 15:04, Chris Peterson wrote:
> 1. Finish bikeshedding coding style
> 2. Update official style guide (owner=bsmedberg?)
> 3. Add style config files for vim/emacs/clang-format in mozilla-central
> 4. Reformat mozilla-central code (piecemeal or big bang)
> 5. Remove modelines from mozilla-
Excuse the continued conversation with myself.
Bug 952379 has landed on m-c so you can now use the work flow below:
$ hg qrefresh
$ mach clang-format
This reformats only the lines that are different from tip^. It doesn't
show anything on the console. Review the changes with your favourite
di
On 23/01/14 15:26, Gregory Szorc wrote:
> As a temporary workaround until upstream gets patched, we're
> downloading and running hosted binaries from ajone's people account
> (with consent of course). He hasn't built the binary for OS X yet.
I've created bug 962954 to track this issue.
Anthony
__
finite columns,
>> member/parameter/local naming convention, and other threads that Gavin was
>> going to start and one I'm going to start now ;-)
>
> It's been a couple of weeks now. Can we move forward?
A style verifier would be nice.
> Anthony Jones has done some
On 30/01/14 06:32, Gregory Szorc wrote:
> Building a style verifier for C++ is hard. You inevitably have to build
> it on top of an existing parser (like Clang) or cobble something hacky
> together [1], at which point you are chasing the language evolution and
> all kinds of one-offs.
I wrote one
On 30/01/14 10:46, Kyle Huey wrote:
> Whatever tool we end up using needs to work on Windows.
clang-format works fine on Windows.
If we want to go down the preprocessed route, you can generate
preprocessed output from the msvc compiler using:
C:\> cl /E MyFile.cpp
Pretty much does the same thin
On 30/01/14 14:44, Anthony Jones wrote:
> On 30/01/14 10:46, Kyle Huey wrote:
>> Whatever tool we end up using needs to work on Windows.
>
> clang-format works fine on Windows.
>
> If we want to go down the preprocessed route, you can generate
> preprocessed output from
On 30/01/14 10:42, Bobby Holley wrote:
> On Wed, Jan 29, 2014 at 1:21 PM, Anthony Jones <mailto:ajo...@mozilla.com>> wrote:
>
> I don't think we should attempt style rewriting.
>
> One thing I wanted to explain is why I have focussed on
> clang-format
On 31/01/14 13:25, Nicholas Nethercote wrote:
> I think what Bobby is saying is that a tool which restyles only lines
> that have only been modified isn't much use. For example, much of
> XPConnect uses 4-space indents, when it should use 2-space indents,
> and fixing that cannot be sensibly done i
Some of you may remember the discussion on clang-format and the `mach
clang-format` command. What we have in place right now is very temporary
but it is functional enough to give it a try. I have not put the effort
into upstreaming my changes. Depending on the feedback I receive I will
either:
* F
I've recently been using gtest for media code. However I've come across
the issue of fopen() working locally but not on the try servers.
https://tbpl.mozilla.org/?tree=Try&rev=11d9f94c54bd
Any suggestions on how I should do this differently?
Anthony
__
I just wanted to give a heads up to everyone that we enabled Media
Source Extensions on nightly for WebM/VP9. This brings Adaptive
Streaming capability to Firefox video playback. The feature is not
complete so the pref will automatically turn off when it gets to
beta/release if we do nothing.
You
There is a priority list of best to worst something like this:
1. Types
2. Compile time assertions
3. Unit tests
4. Fatal run time assertions
5. Non-fatal runtime assertions
6. Documentation
This is the order in which you are most likely to quickly find a
problem. Obviously 1 and 2 don't apply to
On 15/12/14 12:28, Ehsan Akhgari wrote:
> In order to avoid burning the tree, if you are a clang user you can add
> ac_add_options --enable-clang-plugin to your mozconfig and make sure you
> are using a recent version of clang with the development headers and
> libraries installed (the binary packa
On 09/08/12 13:03, Nicholas Nethercote wrote:
IME, this is one those things that seems easy and worthwhile but
usually ends up being a real pain, and doesn't seem worth it. Getting
it 90% right isn't too bad but there's often some trouble in the last
10% that torpedoes it.
Over-inclusion can c
On 29/08/12 19:45, Gregory Szorc wrote:
On 8/23/2012 9:11 AM, Hanno Schlichting wrote:
Instead of using Python's ast module, you can also do a simple trick
with the exec statement and limit the global scope and only allow
certain whitelisted names. An example implementation is at
https://gist.gi
On 30/08/12 12:10, Justin Lebar wrote:
More on topic: I think the essential problem is, you can spend a week
chasing down a perf regression when there's a good chance it's not
your fault (and also a good chance it's not a regression). So people
are making a reasonable trade-off here when they ig
On 31/08/12 13:13, Dave Mandelin wrote:
Otherwise, it seems we just have to share the pain. Bisecting changesets is not
necessarily an enjoyable job but it is a necessary one. I would suggest that
sheriffs pick one of the 5 committers and ask that person to bisect the change
and try not to pic
On 26/09/12 04:25, daniel...@gmail.com wrote:
Yeah, press apparently didn't distinguish between the two - and I never asked,
or was placed on the Technical Adviser list.
No good deed goes unpunished.
On the bright side, I never saw Firefox lagging hardcore in my testing - in
fact, as this
On 04/10/12 01:10, Ben Hearsum wrote:
I don't think anyone is saying that simply using try a lot is bad. But I
think it's valid to question the usage if someone is always using "-p
all". That's not to say it can't be valid/useful usage, just that it's
more questionable than other usage.
The w
I've been tracking down an issue that led me to
nsROCSSPrimitiveValue::GetCssText()
case CSS_PX :
{
float val =
nsPresContext::AppUnitsToFloatCSSPixels(mValue.mAppUnits);
tmpStr.AppendFloat(val);
tmpStr.AppendLiteral("px");
break;
}
This formats
On 09/10/12 11:09, Nicholas Nethercote wrote:>
> But I do agree that it would be lovely to automate this.
+1 for automation. Cross-referencing is a machine's job.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/list
On 09/10/12 17:37, Robert O'Callahan wrote:
> Which tests?
With 7 digits of float precision it fails:
* content/smil/test/test_smilCSSFromBy.xhtml
* layout/style/test/test_animations.html
* layout/style/test/test_bug399349.html
* layout/style/test/test_flexbox_layout.html
* layout/style/test/test
On 11/10/12 19:33, Mike Hommey wrote:
> That being said, PGO on Linux is between 5 and 20% improvement on our
> various talos tests. That's with the version of gcc we currently use,
> which is 4.5. I'd expect 4.7 to do a better job even, especially if we
> added lto to the equation (and since we ar
On 21/11/12 14:09, Justin Dolske wrote:
> On 11/20/12 1:31 PM, Mihai Sucan wrote:
>> Hello!
>>
>> Any https page I try to load shows:
>>
>>Peer's certificate has an invalid signature.
>>Error code: sec_error_bad_signature
>>
>> I can't even run mochitests that load https pages.
>
> Check y
On 07/12/12 08:22, Chris Peterson wrote:
> On 12/6/12 9:34 AM, Ed Morley wrote:
>> As such, if testing just one platform on Try, use Linux64 instead for
>> reduced overall turnaround times. (Use '-p linux64' in your trychooser
>> [2] line).
>
> Sounds like Try could implement a naive '-p fastest/w
On 11/12/12 06:40, Henri Sivonen wrote:
> On Sat, Dec 8, 2012 at 5:24 PM, Randell Jesup wrote:
>> tl;dr - prefixing is bad. It's not good even before Release. API
>> version suffixing may be better.
>
> Are you OK with the latest policy proposal I made or do you intend to
> make a counter-propo
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
David,
On 13/01/13 04:46, David Rajchenbach-Teller wrote:
> As a base for discussion, I have put together a small RFC based on
> promises: https://wiki.mozilla.org/RFC/TaskDependencies
You seem to be on the right track. You've probably already worke
I've spent several weeks fixing scrolling and zooming bugs on b2g. You
may have enjoyed bug 831973 (and it's duplicates) over the last week. In
bug 811950 it took -9 lines to introduce the bug and a further -27 lines
to fix it. Perhaps we have too much scrolling code:
* AsyncPanZoomControl
On 30/01/13 04:20, Kartikaya Gupta wrote:
> I agree, we should try to unify all of this code. A related (but
> possibly deferrable) problem is to unify all of the gesture detection.
>
> I can help you with the Java code in Fennec, in terms of understanding
> what it does and helping replace it wit
On 31/01/13 17:40, Robert O'Callahan wrote:
> Also, reducing the number of directories that are PGO/LTCG should mean that
> the rate of growth decreases proportionally. Even more than proportionally,
> if we flip our default for entirely new modules to be non-PGO/LTCG, as I
> assume we would.
Prof
We need to have a cheap snapshot mechanism. There are a number of
options that have different cost models. Options include:
* Locking
* Defensive copying
* COW (Copy-on-write)
* Immutable trees O(log n)
I'd like to see less of the first two and more of the last two. We need
to create better abstr
On 13/02/13 09:52, Robert O'Callahan wrote:
> On Wed, Feb 13, 2013 at 9:20 AM, Anthony Jones <mailto:ajo...@mozilla.com>> wrote:
>
> We need to have a cheap snapshot mechanism.
>
>
> We don't need that for this. The display list can be construct
On 19/02/13 23:52, Robert O'Callahan wrote:
> I think my idea for an anti-flood state makes this unnecessary.
There are two distinct use cases:
1. You only care where the mouse currently is.
2. You need to know both where the mouse is and how it got there.
We really have to choices:
A. Provide an
61 matches
Mail list logo
