Re: Including just to get std::min and std::max

2013-09-09 Thread Jonathan Kew
On 9/9/13 00:29, Nicholas Cameron wrote: I don't think these kind of time improvements make it worth duplicating std library code into mfbt, we may as well just pull in the headers and forget about it. +1 to that. We've been trying to get *away* from requiring special Mozilla-isms in our cod

Re: Detection of unlabeled UTF-8

2013-09-09 Thread Henri Sivonen
On Fri, Sep 6, 2013 at 6:17 PM, Adam Roach wrote: > Sure. It's a much trickier problem (and, in any case, the UI is > necessarily more intrusive than what I'm suggesting). There's no good way > to explain the nuanced implications of security decisions in a way that is > both accessible to a lay u

Re: Including just to get std::min and std::max

2013-09-09 Thread Dao
On 09.09.2013 03:21, Benoit Jacob wrote: Again, how many other similar wins are we leaving on the table because they're only 10s on a clobber build? It's of course hard to know, which is why I've suggested the (number of useful lines of code) / (total lines of code included) ratio as a meaningful

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread Dao
On 09.09.2013 05:15, ishikawa wrote: > I have been recently editing javascript files to > reduce warnings but found an issue of adopted styls in comm-central > thunderbird codes. > > I checked for the preferred style: > > [1] I found one reference here: > http://autonome.wordpress.com/2006/03/24/

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread ISHIKAWA,chiaki
(2013/09/09 21:18), Dao wrote: On 09.09.2013 05:15, ishikawa wrote: I have been recently editing javascript files to reduce warnings but found an issue of adopted styls in comm-central thunderbird codes. I checked for the preferred style: [1] I found one reference here: http://autonome.wordpre

Re: "Unable to restore focus" and 32-bit Linux builds

2013-09-09 Thread Nicholas Nethercote
On Sun, Sep 8, 2013 at 5:29 PM, Nicholas Nethercote wrote: > > I want to land https://bugzilla.mozilla.org/show_bug.cgi?id=910517, > which is just a clean-up of memory reporters (and is blocking a bunch > of follow-up work.) But I'm blocked by some baffling time-outs > occurring only on 32-bit op

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread Dao
On 09.09.2013 14:48, ISHIKAWA,chiaki wrote: But to be honest, I wonder why 2 for JS and 4 for Java. As far as the indentation requirement is concerned, there does not seem to be much difference between the two languages. But there must be a reason. But for a casual programmer, it is not clear.

Rendering meeting Monday 5:30pm PDT

2013-09-09 Thread Milan Sreckovic
The Rendering meeting is about all things Gfx, Image, Layout, and Media. It takes place every second Monday, alternating between 2:30pm PDT and 5:30pm PDT. The next meeting will take place today Monday, September 9th at 5:30 PM US/Pacific. This is the time that's manageable for Taipei, not so

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread Scott Johnson
Thus Spoke ishikawa: > > I wonder if trying to re-indent legacy code according to the current style > is a good idea or not. (It is a little irritating to modify a part of legacy > code and find my editor trying to follow the current style while the rest of > the file is in different style.) I'd r

Re: Detection of unlabeled UTF-8

2013-09-09 Thread Adam Roach
On 9/9/13 02:31, Henri Sivonen wrote: We don't have telemetry for the question "How often are pages that are not labeled as UTF-8, UTF-16 or anything that maps to their replacement encoding according to the Encoding Standard and that contain non-ASCII bytes in fact valid UTF-8?" How rare would th

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread Chris Peterson
On 9/9/13 6:58 AM, Dao wrote: Probably historic reasons (e.g. somebody started adding lots of Java files with 4-space indents and changing those wasn't considered worthwhile) or consistency with ? Google's

How is Talos on Android deployed?

2013-09-09 Thread Nicholas Nethercote
Hi, How is Talos on Android deployed? It appears to be done differently to Talos on desktop (Windows, Mac, Linux). I need to update the Android deployment so it has the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=912863 in order to land the patch in https://bugzilla.mozilla.org/show_

Re: How is Talos on Android deployed?

2013-09-09 Thread Nicholas Nethercote
On Mon, Sep 9, 2013 at 5:52 PM, Nicholas Nethercote wrote: > > How is Talos on Android deployed? For those who are curious, there's a zip file that must be uploaded to a particular machine, and then testing/talos/talos.json must be modified to point to it. See https://bugzilla.mozilla.org/show_b