Re: getter_AddRefs

2013-03-29 Thread Neil
Benjamin Smedberg wrote: On 3/26/2013 10:16 AM, Neil wrote: Why does getter_AddRefs have an operator nsISupports**? So far most of the uses I've found appear to be people enumerating an nsISimpleEnumerator directly into an nsCOMPtr type, although the documented idl return value is nsISupport

Automatic tree clobbering is coming

2013-03-29 Thread Gregory Szorc
The CLOBBER file landed a few months ago to help us detect and prevent known build bustage. Since then, a lot of people (myself included) have pushed to trees not knowing they needed to force a clobber first, causing burnage. Others have been frustrated that |hg pull -u && mach build| followed by a

Re: Automatic tree clobbering is coming

2013-03-29 Thread Emanuel Hoogeveen
How are things looking with regards to using hg purge (bug 851270)? ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Automatic tree clobbering is coming

2013-03-29 Thread Gregory Szorc
On 3/29/2013 11:29 AM, Emanuel Hoogeveen wrote: > How are things looking with regards to using hg purge (bug 851270)? > As far as I'm concerned, that's in RelEng's court. I hope they solve it soon because not using hg purge is adding huge delays (15+ minutes for some Windows builds) for all clobbe

Re: Automatic tree clobbering is coming

2013-03-29 Thread Neil
Gregory Szorc wrote: * Your mozconfig contains |mk_add_options NO_AUTOCLOBBER=1| or your environment contains NO_AUTOCLOBBER. Exactly what happens in this case, does it still fail in configure? (The old failure mode was not detectable by client.mk so you had to manually reconfigure.) * Th

Re: Automatic tree clobbering is coming

2013-03-29 Thread Gregory Szorc
On 3/29/2013 5:32 PM, Neil wrote: > Gregory Szorc wrote: > >> * Your mozconfig contains |mk_add_options NO_AUTOCLOBBER=1| or your >> environment contains NO_AUTOCLOBBER. >> > Exactly what happens in this case, does it still fail in configure? > (The old failure mode was not detectable by client.mk

Re: Automatic tree clobbering is coming

2013-03-29 Thread Philip Chee
On 30/03/2013 09:01, Gregory Szorc wrote: > If MOZ_OBJDIR is literally ".." then depending on how client.mk is > invoked, that '..' will be appended to the current working directory > somehow. I think the exact semantics are partially undefined. > > I highly recommend against defining MOZ_OBJDIR

Re: Automatic tree clobbering is coming

2013-03-29 Thread Kyle Huey
On Fri, Mar 29, 2013 at 9:47 PM, Philip Chee wrote: > I'm running Windows7 and the mozilla-build system. We *have* to use > relative paths because some parts of mozilla-build (I can't remember > which) would choke on absolute paths. > Unless there's some problem with comm-central specifically, t

Re: Automatic tree clobbering is coming

2013-03-29 Thread David Keeler
On 03/29/13 22:10, Kyle Huey wrote: > On Fri, Mar 29, 2013 at 9:47 PM, Philip Chee wrote: > >> I'm running Windows7 and the mozilla-build system. We *have* to use >> relative paths because some parts of mozilla-build (I can't remember >> which) would choke on absolute paths. >> > > Unless there'