Re: Status: ASan builds on Windows

2015-12-15 Thread Chris Peterson
On 12/15/15 4:36 PM, Emanuel Hoogeveen wrote: Not to derail the topic, but I wonder how many crashes would be more actionable if they were caught earlier by assertions. I believe Chrome Canary has assertions enabled for their testing audience. I don't know how pleasant this would be for Nightl

Re: Status: ASan builds on Windows

2015-12-15 Thread Emanuel Hoogeveen
Not to derail the topic, but I wonder how many crashes would be more actionable if they were caught earlier by assertions. I believe Chrome Canary has assertions enabled for their testing audience. I don't know how pleasant this would be for Nightly users (like myself), since Nightly right now i

Re: Status: ASan builds on Windows

2015-12-15 Thread Ehsan Akhgari
> On Dec 15, 2015, at 9:36 AM, Nicolas B. Pierron > wrote: > 2/ Current Blockers: > > 2.1/ Windows Clang ASan builds are not stable yet. Have we considered doing this on Linux and Mac? Windows would probably be the last platform where we should try this, given that we build Nightly with a d

Re: Status: ASan builds on Windows

2015-12-15 Thread Andrew McCreight
I'd also note that Google at least used to ship a similar kind of thing to their Canary users a few times a week, called SyzygyASAN: http://blog.chromium.org/2013/05/testing-chromium-syzyasan-lightweight.html I haven't found a ton of detail about whether they still do it but that blog post does s

Re: Status: ASan builds on Windows

2015-12-15 Thread Ted Mielczarek
On Tue, Dec 15, 2015, at 09:36 AM, Nicolas B. Pierron wrote: > The crash reporter is currently disabled on ASan builds, we need to > figure > out why, one hypothesis (I do not recall the author) was that we have > issues > with the SEGV handler. That was my hypothesis. I remember talking to deco

Status: ASan builds on Windows

2015-12-15 Thread Nicolas B. Pierron
Hi, 0/ Context As part of the JS engine a lot of issues which are reported on crash-stats are rarely actionable. I personally waited a few times on equivalent fuzz-bugs, in hope to fix a crash-stat issue by luck. One of the proposal we made in Orlando was to investigate if we could improve