Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Valentin Gosu
On 26 March 2018 at 16:53, Ben Kelly wrote: > On Mon, Mar 26, 2018 at 10:47 AM, Valentin Gosu > wrote: > >> Yes, that is definitely something we want to fix, but not very >> straightforward. We have quite a few URI implementations, and a bunch more >> protocol handlers. >> >> https://github.com/

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Ben Kelly
On Mon, Mar 26, 2018 at 10:47 AM, Valentin Gosu wrote: > Yes, that is definitely something we want to fix, but not very > straightforward. We have quite a few URI implementations, and a bunch more > protocol handlers. > > https://github.com/valenting/gecko/wiki/Threadsafe-URIs- > progress#protoco

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Valentin Gosu
Yes, that is definitely something we want to fix, but not very straightforward. We have quite a few URI implementations, and a bunch more protocol handlers. https://github.com/valenting/gecko/wiki/Threadsafe-URIs-progress#protocol-handler-implementations On 26 March 2018 at 15:24, Ben Kelly wro

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Ben Kelly
This is so great. Thank you! One question that comes to mind, though, is there any chance this could be uplifted to 60? As we start doing more OMT nsIURI stuff its going to become difficult to uplift code to 60ESR. On Fri, Mar 23, 2018 at 8:25 AM, Valentin Gosu wrote: > Hello everyone, > > I

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Boris Zbarsky
On 3/23/18 8:25 AM, Valentin Gosu wrote: I would like to announce that with the landing of bug 1447194, all nsIURI implementations in Gecko are now threadsafe, as well as immutable. Valentin, Thank you very much for doing this! Just the safety guarantees from URI immutability are a huge deal

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Ben Kelly
Do we have any plan to be able to use NS_NewURI() off-main-thread? I thought that was included here, but I see now that it is not. The initial URL parse OMT is important for truly being able to remove all our "bounce to the main thread for URL stuff" legacy code. On Fri, Mar 23, 2018 at 8:25 AM,

Re: PSA: nsIURI implementations are now threadsafe

2018-03-26 Thread Patrick McManus
\o/ !! On Friday, March 23, 2018, Valentin Gosu wrote: > Hello everyone, > > I would like to announce that with the landing of bug 1447194, all nsIURI > implementations in Gecko are now threadsafe, as well as immutable. As a > consequence, you no longer have to clone a URI when you pass it arou

Re: PSA: nsIURI implementations are now threadsafe

2018-03-26 Thread Valentin Gosu
On 23 March 2018 at 21:06, Ben Kelly wrote: > This is so great. Thank you! > > One question that comes to mind, though, is there any chance this could be > uplifted to 60? As we start doing more OMT nsIURI stuff its going to > become difficult to uplift code to 60ESR. > Certainly doable. Most

PSA: nsIURI implementations are now threadsafe

2018-03-23 Thread Valentin Gosu
Hello everyone, I would like to announce that with the landing of bug 1447194, all nsIURI implementations in Gecko are now threadsafe, as well as immutable. As a consequence, you no longer have to clone a URI when you pass it around, as it's guaranteed not to change, and now it's OK to release the