On 23 March 2018 at 21:06, Ben Kelly <bke...@mozilla.com> wrote: > This is so great. Thank you! > > One question that comes to mind, though, is there any chance this could be > uplifted to 60? As we start doing more OMT nsIURI stuff its going to > become difficult to uplift code to 60ESR. >
Certainly doable. Most of the code landed in 60. Only 5 bugs related to this were landed in 61, 1442239 <https://bugzilla.mozilla.org/show_bug.cgi?id=1442239>, 1442242 <https://bugzilla.mozilla.org/show_bug.cgi?id=1442242>, 1447190 <https://bugzilla.mozilla.org/show_bug.cgi?id=1447190>, 1447194 <https://bugzilla.mozilla.org/show_bug.cgi?id=1447194>, 1447330 <https://bugzilla.mozilla.org/show_bug.cgi?id=1447330>. Still a fair amount of code, but it might be worth it. > On Fri, Mar 23, 2018 at 8:25 AM, Valentin Gosu <valentin.g...@gmail.com> > wrote: > >> Hello everyone, >> >> I would like to announce that with the landing of bug 1447194, all nsIURI >> implementations in Gecko are now threadsafe, as well as immutable. As a >> consequence, you no longer have to clone a URI when you pass it around, as >> it's guaranteed not to change, and now it's OK to release them off the >> main >> thread. >> >> If you need to change a nsIURI, you should use the nsIURIMutator interface >> (in JavaScript - just call .mutate() on the URI) or the NS_MutateURI >> <https://searchfox.org/mozilla-central/source/netwerk/test/ >> gtest/TestURIMutator.cpp#22> >> helper class (in C++). >> >> More info here: >> https://wiki.mozilla.org/Necko/nsIURI >> >> If you find any bugs, make them block bug 922464 (OMT-nsIURI) >> >> I'd like to thank everyone who helped review the patches, especially Honza >> Bambas who reviewed most of my patches. >> >> Cheers! >> _______________________________________________ >> dev-platform mailing list >> dev-platform@lists.mozilla.org >> https://lists.mozilla.org/listinfo/dev-platform >> > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
