Re: Extension to integrate Searchfox features in Phabricator

2018-10-11 Thread Marco Castelluccio
Thanks for the report, I had built it really quickly without actually looking into perf. I think the issue should be fixed in the newest version of the extension (0.2.1), let me know if it isn't (I couldn't reproduce it). - Marco. P.S.: Should you find other problems, you can file issues at http

Re: Extension to integrate Searchfox features in Phabricator

2018-10-10 Thread Bobby Holley
I noticed this extension seems to be causing significant jank while typing comments into phabricator. I'll send a profile to Marco, but just an FYI for anyone else who's using it. On Tue, Oct 2, 2018 at 6:03 AM Marco Castelluccio wrote: > I've built an (experimental) WebExtension to integrate so

Re: Extension to integrate Searchfox features in Phabricator

2018-10-04 Thread Eric Rescorla
This is great. Thanks! -Ekr On Tue, Oct 2, 2018 at 7:04 AM Kartikaya Gupta wrote: > Neat! I took a quick peek at your addon source and the stuff it's > relying on seems ok for now. At least, it's not anything we plan to > change anytime soon. If there are changes to searchfox that would make >

Re: Extension to integrate Searchfox features in Phabricator

2018-10-02 Thread Kartikaya Gupta
Neat! I took a quick peek at your addon source and the stuff it's relying on seems ok for now. At least, it's not anything we plan to change anytime soon. If there are changes to searchfox that would make your life easier in terms of expanding your addon, let me know and we can discuss possibilitie

Extension to integrate Searchfox features in Phabricator

2018-10-02 Thread Marco Castelluccio
I've built an (experimental) WebExtension to integrate some of the Searchfox features into Phabricator. I find it very useful to be able to search code while reviewing, but I have to resort to opening a new Searchfox tab and looking for the code that is being modified. This extension makes my workf