Thanks for the report, I had built it really quickly without actually looking into perf.
I think the issue should be fixed in the newest version of the extension (0.2.1), let me know if it isn't (I couldn't reproduce it). - Marco. P.S.: Should you find other problems, you can file issues at https://github.com/marco-c/mozsearch-phabricator-addon/issues. Il 11/10/2018 00:26, Bobby Holley ha scritto: > I noticed this extension seems to be causing significant jank while > typing comments into phabricator. I'll send a profile to Marco, but > just an FYI for anyone else who's using it. > > On Tue, Oct 2, 2018 at 6:03 AM Marco Castelluccio > <mcastelluc...@mozilla.com <mailto:mcastelluc...@mozilla.com>> wrote: > > I've built an (experimental) WebExtension to integrate some of the > Searchfox features into Phabricator. > I find it very useful to be able to search code while reviewing, but I > have to resort to opening a new > Searchfox tab and looking for the code that is being modified. This > extension makes my workflow much > more pleasant. > > You can find it at > https://addons.mozilla.org/addon/searchfox-phabricator/ (the > source code > is at > https://github.com/marco-c/mozsearch-phabricator-addon). > > Currently, the extension does: > 1) Highlight keywords when you hover them, highlighting them both > in the > pre-patch and in the post-patch view; > 2) When you press on a keyword, it offers options to search for the > definition, callers, and so on (the results are opened on > Searchfox in a > new tab). > > I'm planning to add support for sticky highlighting and blame > information (when hovering on the line number on the left side). > > - Marco. > > P.S.: The extension relies on parsing pages from Searchfox and from > Phabricator, so the maintenance might not be so easy. If there's > enough > interest, I might keep maintaining it or talk with someone to make > Searchfox data accessible in an easier way. > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org <mailto:dev-platform@lists.mozilla.org> > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
