Re: Commit messages in Phabricator

2018-02-13 Thread Mark Côté
On Tuesday, 13 February 2018 14:05:55 UTC-5, Haik Aftandilian wrote: > On Mon, Feb 12, 2018 at 6:30 AM, Eric Rescorla wrote: > > > On Mon, Feb 12, 2018 at 6:09 AM, Boris Zbarsky wrote: > > Instead, maybe we can arrange for Phab/Lando to put the bug #in the short > > message, potentially also wi

Re: Commit messages in Phabricator

2018-02-13 Thread Haik Aftandilian
On Mon, Feb 12, 2018 at 6:30 AM, Eric Rescorla wrote: > On Mon, Feb 12, 2018 at 6:09 AM, Boris Zbarsky wrote: > Instead, maybe we can arrange for Phab/Lando to put the bug #in the short > message, potentially also with r= > ​I agree. Having the bug ID on the first line of the commit message is

Re: Commit messages in Phabricator

2018-02-13 Thread lthomson
On Monday, February 12, 2018 at 1:48:54 PM UTC-5, Gregory Szorc wrote: > While I'm not working on either client implementation and am not part of > the Phabricator team, if someone wants to formalize the Mercurial or Git > clients in version-control-tools before the Phabricator team has time to > w

Re: Commit messages in Phabricator

2018-02-12 Thread Gregory Szorc
On Mon, Feb 12, 2018 at 6:09 AM, Boris Zbarsky wrote: > On 2/11/18 3:57 PM, Emilio Cobos Álvarez wrote: > >> Arc wants to use something like: >> > > So from my point of view, having the bug# easily linked from various > places where the short summary is all that's shown (pushlogs especially) is >

Re: Commit messages in Phabricator

2018-02-12 Thread Eric Rescorla
On Mon, Feb 12, 2018 at 6:09 AM, Boris Zbarsky wrote: > On 2/11/18 3:57 PM, Emilio Cobos Álvarez wrote: > >> Arc wants to use something like: >> > > So from my point of view, having the bug# easily linked from various > places where the short summary is all that's shown (pushlogs especially) is >

Re: Commit messages in Phabricator

2018-02-12 Thread Boris Zbarsky
On 2/11/18 3:57 PM, Emilio Cobos Álvarez wrote: Arc wants to use something like: So from my point of view, having the bug# easily linked from various places where the short summary is all that's shown (pushlogs especially) is pretty useful. It saves loading a bunch of extra things when tryin

Re: Commit messages in Phabricator

2018-02-12 Thread Piotr Zalewa
Hi Emilio, Landing using upcoming "Lando" will use the following format (taken from https://github.com/mozilla-conduit/lando-api/blob/master/landoapi/commit_message.py#L21) : ``` - r=,r= Differential Revision: ``` "Test Plan" is describing the steps to test the patc

Commit messages in Phabricator

2018-02-11 Thread Emilio Cobos Álvarez
Hey, So I've been testing Phabricator for a while and I've noticed that the arc tool uses different formatting for the commit messages than what usually lands on mozilla-central. In particular I usually lay out my commits like: --- Bug XXX: Short summary. r= Long description, if needed. ---