Hi Emilio,

Landing using upcoming "Lando" will use the following format
(taken from
https://github.com/mozilla-conduit/lando-api/blob/master/landoapi/commit_message.py#L21)
:

```
        <Bug #> - <Short Summary> r=<reviewer1>,r=<reviewer2>

        <Summary>

        Differential Revision: <Revision URL>
```

"Test Plan" is describing the steps to test the patch by the reviewer.

"Subscribers" is a list of users author would like to subscribe to the
revision.

zalun

On Sun, Feb 11, 2018 at 9:57 PM Emilio Cobos Álvarez <emi...@crisal.io>
wrote:

> Hey,
>
> So I've been testing Phabricator for a while and I've noticed that the
> arc tool uses different formatting for the commit messages than what
> usually lands on mozilla-central.
>
> In particular I usually lay out my commits like:
>
> ---
> Bug XXX: Short summary. r=<reviewers>
>
> Long description, if needed.
> ---
>
> Arc wants to use something like:
>
> ---
> Short summary.
>
> Summary:
> Long description (I assume?).
>
> Test Plan: (what goes here?)
>
> Reviewers: <reviewers>
>
> Subscribers: (what goes here?)
>
> Bug #: XXX
>
> Differential revision: https://phabricator.services.mozilla.com/D574
> ---
>
> I've been manually fixing them up before committing them so they have
> the usual format when landing.
>
> My question is: Are commits that are going to land to autoland from
> phabricator directly going to land with the new format?
>
> Should we keep fixing them up before pushing to autoland / inbound, or
> should we start pushing commits with the new commit message formatting?
>
> Also, knowing an answer for the (what goes here?) questions would be
> super-helpful.
>
> Thanks a lot!
>
>   -- Emilio
> _______________________________________________
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to