Re: Building mozilla-central with clang + icecream

2017-11-09 Thread Wei-Cheng Pan
te-env can help. It will create a standalone toolchain package: /usr/lib/icecc/icecc-create-env --clang /usr/bin/clang-5.0 /usr/lib/icecc/compiler-wrapper Then export ICECC_VERSION="" in your mozconfig. -- Wei-Cheng Pan ___ dev-platform

getComputedStyle now skips restyling if possible

2017-09-28 Thread Wei-Cheng Pan
descendants have changed but not document.body itself. If you are not sure (or just don't care about it), choose a layout dependent property will do the trick. (e.g.: getComputedStyle(document.body).width) [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1363805 Cheers, Wei-Chen

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Wei-Cheng Pan
On 08/03/2017 10:24 PM, Ehsan Akhgari wrote: > On 2017-03-08 6:40 AM, James Graham wrote: >> On 08/03/17 11:11, Frederik Braun wrote: >>> On 08.03.2017 01:17, Ralph Giles wrote: I second Jeff's point about building with icecream[1]. If you work in an office with a build farm, or near a fa

Re: Error handling with MOZ_MUST_USE

2016-11-14 Thread Wei-Cheng Pan
Hi, I've updated the coding style document, added something about MOZ_MUST_USE and MOZ_MUST_USE_TYPE on MDN: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Error_handling Best, Wei-Cheng Pan On 04/11/2016 12:39 AM, Michael Layzell wrote: > We also have

Error handling with MOZ_MUST_USE

2016-11-03 Thread Wei-Cheng Pan
sion. Such grey zone will depend on each reviewers' own judgement. Wei-Cheng Pan [1] https://groups.google.com/forum/#!msg/mozilla.dev.platform/dS5Dz6SfO3w/avzIxb7CBAAJ [2] https://bugzilla.mozilla.org/show_bug.cgi?id=MOZ_MUST_USE [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1301574 [4] ht

Re: Generating Visual Studio project files by default

2016-05-24 Thread Wei-Cheng Pan
This is great! Just few questions: Can we debug firefox in the IDE during mochitest? i.e.: ./mach mochitest --debugger=devenv Does it supports nmake as well? Thanks. Wei-Cheng Pan On 5/25/16 7:00 AM, Gregory Szorc wrote: > Coming soon to your local builds, Visual Studio project files w