Re: disabled non-e10s tests on trunk

2017-08-15 Thread Nils Ohlmeier
I guess not a lot of people are aware of it, but for WebRTC we still have two distinct implementations for the networking code. So if I understand the impact here right we just lost test coverage for probably a couple of thousand lines of code. And yes you can potentially blame it on WebRTC netw

Intent to ship version 4 of the Safe Browsing protocol

2017-08-15 Thread Francois Marier
After a year's worth of development, bug fixes, and integration testing, we are now ready to enable the latest version [1] of the Safe Browsing API in Firefox 56, two releases ahead of schedule and only a few weeks behind Chrome. We do not expect any user-visible changes, but will be running an ex

Re: disabled non-e10s tests on trunk

2017-08-15 Thread J. Ryan Stinnett
I think Ben's argument has merit: 1. Even after Firefox 57, we will still be shipping a product in non-e10s mode: Firefox for Android 2. If WPT (and potentially other suites) aren't being run in non-e10s mode, it increases risk because we are shipping untested code paths to our users Someone migh

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Ben Kelly
On Tue, Aug 15, 2017 at 4:43 PM, Joel Maher wrote: > This is a discussion about tests in e10s mode, not WPT on Android. > Yes. And android is our last tier 1 platform that requires non-e10s. I think that makes it relevant to the discussion. > > What specific coverage are we missing by not ru

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Joel Maher
This is a discussion about tests in e10s mode, not WPT on Android. What specific coverage are we missing by not running WPT in non-e10s mode on desktop? When can we ensure we have that coverage in e10s mode? I assume this is just making sure the tests that we have disabled on e10s mode need to g

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Ben Kelly
On Tue, Aug 15, 2017 at 4:37 PM, Joel Maher wrote: > All of the above mentioned tests are not run on Android (well > mochitest-media is to some degree). Is 4 months unreasonable to fix the > related tests that do not run in e10s? Is there another time frame that > seems more reasonable? > Last

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Joel Maher
All of the above mentioned tests are not run on Android (well mochitest-media is to some degree). Is 4 months unreasonable to fix the related tests that do not run in e10s? Is there another time frame that seems more reasonable? On Tue, Aug 15, 2017 at 4:34 PM, Ben Kelly wrote: > On Tue, Aug 1

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Ben Kelly
On Tue, Aug 15, 2017 at 4:29 PM, wrote: > While there are many tests which individually are disabled or lacking > coverage, these test suites have no non-e10s coverage: > * web-platform-tests > * browser-chrome > * devtools > * jsreftests > * mochitest-webgl, mochitest-gpu, mochitest-media > * re

Re: disabled non-e10s tests on trunk

2017-08-15 Thread jmaher
Thanks everyone for commenting on this thread. As a note, we run many tests in non-e10s mode: * android mochitest, reftest, crashtest, marionette, * mochitest-chrome * xpcshell * gtest/cpptest/jittest * mochitest-a11y * mochitest-jetpack (very few tests remain) While there are many tests which i

Re: Firefox and clang-cl

2017-08-15 Thread Ted Mielczarek
On Mon, Aug 14, 2017, at 04:36 PM, Ehsan Akhgari wrote: > > * Performance: We switched from msvc+pgo to clang without pgo and got > > comparable perf. We did have to use an order file (/order: flag to > > link.exe) to get comparable startup perf. > That is very interesting! This is one of the as