I guess not a lot of people are aware of it, but for WebRTC we still have two distinct implementations for the networking code. So if I understand the impact here right we just lost test coverage for probably a couple of thousand lines of code.
And yes you can potentially blame it on WebRTC networking for not having unified it’s networking code for e10s and non-e10s. But when e10s got turned on I asked around if we could delete the non-e10s code soon, I was told no. So I assumed both technologies would stick around for some more time. I’m not sure how others do it, but our low level C++ unit tests don’t have an e10s mode at all. Therefore we can’t simply delete the non-e10s WebRTC networking code either (without loosing a ton of test coverage). With this being said I think the right thing here would be to turn the non-e10s mochitests back on for WebRTC until we have a better solution. Nils > On Aug 15, 2017, at 13:54, J. Ryan Stinnett <jry...@gmail.com> wrote: > > I think Ben's argument has merit: > > 1. Even after Firefox 57, we will still be shipping a product in non-e10s > mode: Firefox for Android > 2. If WPT (and potentially other suites) aren't being run in non-e10s mode, > it increases risk because we are shipping untested code paths to our users > > Someone might add code that assumes e10s is the only mode and land it > successfully, only later to hear that it fails or crashes on Android, since > e10s doesn't exist there today. > > - Ryan > > On Tue, Aug 15, 2017 at 3:43 PM, Joel Maher <jma...@mozilla.com> wrote: > >> This is a discussion about tests in e10s mode, not WPT on Android. >> >> What specific coverage are we missing by not running WPT in non-e10s mode >> on desktop? When can we ensure we have that coverage in e10s mode? I >> assume this is just making sure the tests that we have disabled on e10s >> mode need to get fixed. >> >> On Tue, Aug 15, 2017 at 4:39 PM, Ben Kelly <bke...@mozilla.com> wrote: >> >>> On Tue, Aug 15, 2017 at 4:37 PM, Joel Maher <jma...@mozilla.com> wrote: >>> >>>> All of the above mentioned tests are not run on Android (well >>>> mochitest-media is to some degree). Is 4 months unreasonable to fix the >>>> related tests that do not run in e10s? Is there another time frame that >>>> seems more reasonable? >>>> >>> >>> Last I checked it was your team that told me WPT on android was not an >>> immediate priority. The WPT harness itself does not run there. >>> >> _______________________________________________ >> dev-platform mailing list >> dev-platform@lists.mozilla.org >> https://lists.mozilla.org/listinfo/dev-platform >> > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
