Re: Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread Mike Hommey
On Wed, Nov 09, 2016 at 05:32:03PM -0800, Eric Rahm wrote: > Would that be a fourth copy in the tree at this point? Why would that require another copy? Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Bobby Holley
On Wed, Nov 9, 2016 at 12:31 PM, David Teller wrote: > \o/ > > Do we already have a story for implementing WebIDL in Rust? > In general, we decided that WebIDL objects need to remain C++, since they generally need to interact with the DOM and the extra complexity to support pure-Rust objects in

Re: Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread David Major
On Wed, Nov 9, 2016, at 06:17 PM, Mike Hommey wrote: > On Thu, Nov 10, 2016 at 11:04:05AM +1100, Nicholas Nethercote wrote: > > On Thu, Nov 10, 2016 at 10:00 AM, Mike Hommey wrote: > > > > > > > > CppUnitTests are fine to keep. > > > > > > Having said that, IMO it is desirable to convert CppUni

Re: Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread Eric Rahm
Would that be a fourth copy in the tree at this point? -e On Wed, Nov 9, 2016 at 4:17 PM, Mike Hommey wrote: > On Thu, Nov 10, 2016 at 11:04:05AM +1100, Nicholas Nethercote wrote: > > On Thu, Nov 10, 2016 at 10:00 AM, Mike Hommey wrote: > > > > > > > > CppUnitTests are fine to keep. > > > > >

Multiple content processes in Nightly

2016-11-09 Thread Blake Kaplan
Hello everyone, We've been working on the e10s-multi project for a while now and are looking at turning on multiple content processes in Nightly. Our plan is to start with two content processes (compared to the single content process we currently use) and if that goes well, we'll start ramping up

Re: Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread Mike Hommey
On Thu, Nov 10, 2016 at 11:04:05AM +1100, Nicholas Nethercote wrote: > On Thu, Nov 10, 2016 at 10:00 AM, Mike Hommey wrote: > > > > > CppUnitTests are fine to keep. > > > Having said that, IMO it is desirable to convert CppUnitTests to gtests > where possible. Every CppUnitTest has to provide s

Re: Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread Nicholas Nethercote
On Thu, Nov 10, 2016 at 10:00 AM, Mike Hommey wrote: > > CppUnitTests are fine to keep. Having said that, IMO it is desirable to convert CppUnitTests to gtests where possible. Every CppUnitTest has to provide some basic check/pass/fail infrastructure, and many of them provide their own. Convert

[e10s] Higher priority handling for vsync in child processes

2016-11-09 Thread smaug
Hi, the latest nightly has higher priority for vsync/refreshDriver/requestAnimationFrame handling in child processes [1], which should make rendering updates smoother, at least in some cases. If you see any unexpected behavior, please file bugs and CC me, :smaug. And if there are cases when re

Re: Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread Mike Hommey
On Wed, Nov 09, 2016 at 02:47:44PM -0500, Benjamin Smedberg wrote: > Please do not add any new CppUnitTests. With the pending removal of the > XPCOM glue, CppUnitTests will fail to build and are no longer an option. We > are currently porting current CppUnitTests to gtests, and if you are > tempted

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread David Teller
\o/ Do we already have a story for implementing WebIDL in Rust? Cheers, David On 09/11/16 12:20, Ted Mielczarek wrote: > I recently wrote some documentation on how to add Rust code to Gecko: > http://gecko.readthedocs.io/en/latest/build/buildsystem/rust.html > > It should be fairly straightfor

Re: Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread Aaron Klotz
What about CppUnitTests that only pull in stuff from headers and don't emit references to xul symbols? Will we still be able to create those, or is all CppUnitTest build capability going away? On 11/9/2016 12:47 PM, Benjamin Smedberg wrote: Please do not add any new CppUnitTests. With the pend

Please do not add any new CppUnitTests/GeckoCppUnitTests

2016-11-09 Thread Benjamin Smedberg
Please do not add any new CppUnitTests. With the pending removal of the XPCOM glue, CppUnitTests will fail to build and are no longer an option. We are currently porting current CppUnitTests to gtests, and if you are tempted to write a CppUnitTest, please write it as a gtest instead. --BDS ___

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Ted Mielczarek
On Wed, Nov 9, 2016, at 11:41 AM, Kartikaya Gupta wrote: > I'm actually trying to debug a rust issue right now and have some > questions. I've done the |mach vendor rust| step and got all the > vendored crates. Now let's say that in one of the dependencies (the > 'cmake' crate in my case) there's s

PSA: More setTimeout()/setInterval() changes

2016-11-09 Thread Ben Kelly
Hi all, FYI, I've landed some more timer changes in FF52 nightly. This builds on the work previously discussed here: https://groups.google.com/forum/#!topic/mozilla.dev.platform/obJ97zzl4Po As of today's nightly setTimeout() and setInterval() will more aggressively yield the main thread back

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Kartikaya Gupta
On Wed, Nov 9, 2016 at 11:51 AM, Ralph Giles wrote: > On Wed, Nov 9, 2016 at 8:41 AM, Kartikaya Gupta wrote: > >> If I edit the third_party/rust/cmake/src/lib.rs >> in-place, the build fails because of a hash mismatch. > > Interesting! This is supposed to happen as a check against corruption > an

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Ralph Giles
On Wed, Nov 9, 2016 at 8:41 AM, Kartikaya Gupta wrote: > If I edit the third_party/rust/cmake/src/lib.rs > in-place, the build fails because of a hash mismatch. Interesting! This is supposed to happen as a check against corruption and/or non-reproducible builds, but I can't reproduce by modifyin

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Kartikaya Gupta
I'm actually trying to debug a rust issue right now and have some questions. I've done the |mach vendor rust| step and got all the vendored crates. Now let's say that in one of the dependencies (the 'cmake' crate in my case) there's some sort of behaviour that I'd like to investigate/debug. If I ed

Re: Reduction of intermittent failures for Marionette tests

2016-11-09 Thread Lawrence Mandel
Thank you for your focus on intermittent Marionette tests Henrik. Great results! Lawrence On Wed, Nov 9, 2016 at 4:16 AM, Henrik Skupin wrote: > Hi all, > > Over the past months I tried to always have a look on newly filed > intermittent failures for Marionette tests on Bugzilla. I tried to > t

Adding Rust code to Gecko, now documented

2016-11-09 Thread Ted Mielczarek
I recently wrote some documentation on how to add Rust code to Gecko: http://gecko.readthedocs.io/en/latest/build/buildsystem/rust.html It should be fairly straightforward for most use cases (thanks to Nathan Froyd for doing the lion's share of the work to make it so), but if there's anything that

Re: Reorganization of Firefox-UI tests in mozilla-central

2016-11-09 Thread Henrik Skupin
Henrik Skupin wrote on 01/09/16 17:37: After a longer time without a response I would like to give a follow-up on where we stand at the moment and what the future will be for those tests. But first, I want to say thanks to everyone who participated in this thread. The received feedback was very h

Let Firefox shutdown for content crashes via MOZ_CRASHREPORTER_SHUTDOWN

2016-11-09 Thread Henrik Skupin
Hi, Recently I have added a feature to Firefox which let it shutdown on its own in case of a content crash happening (bug 1311016). It is available starting with Firefox 52, and the behavior can be controlled via the MOZ_CRASHREPORTER_SHUTDOWN environment variable. This feature is kinda helpful f

Reduction of intermittent failures for Marionette tests

2016-11-09 Thread Henrik Skupin
Hi all, Over the past months I tried to always have a look on newly filed intermittent failures for Marionette tests on Bugzilla. I tried to triage them early and to bring those up to interested parties. This was working great for a couple of scenarios like the massive amount of hangs and crashes