Re: Best way to make xpcshell provide consistent stack limits?

2013-06-28 Thread Andrew Sutherland
On 06/28/2013 06:52 PM, Benjamin Smedberg wrote: The JS stack limit should be basically the native stack limit minus a little bit of headroom (maybe 512 bytes?). Whether we implement that dynamically or just use ifdefs to hardcode the "correct" values seems like just an implementation question.

Re: MOZ_NOT_REACHED and JS_NOT_REACHED are now MOZ_ASSUME_UNREACHABLE, and other changes.

2013-06-28 Thread Justin Lebar
> #3 from the tldr and #2 from the main post contradict each other, no? I was out to lunch and didn't realize that I was tossing around two macro names. There's only one. The name we liked was MOZ_ASSUME_UNREACHABLE; MOZ_ASSUME_NOT_REACHED won't exist in a minute, after I push. There's no diffe

Re: MOZ_NOT_REACHED and JS_NOT_REACHED are now MOZ_ASSUME_UNREACHABLE, and other changes.

2013-06-28 Thread Kyle Huey
On Fri, Jun 28, 2013 at 7:04 PM, Justin Lebar wrote: > tl;dr - Changes from bug 820686: > > 1. We renamed MOZ_NOT_REACHED to MOZ_ASSUME_UNREACHABLE. > 2. In Gecko, please use MOZ_CRASH instead of MOZ_NOT_REACHED unless you > care > about code size or perf. > 3. In JS, we removed JS_NOT_REAC

MOZ_NOT_REACHED and JS_NOT_REACHED are now MOZ_ASSUME_UNREACHABLE, and other changes.

2013-06-28 Thread Justin Lebar
tl;dr - Changes from bug 820686: 1. We renamed MOZ_NOT_REACHED to MOZ_ASSUME_UNREACHABLE. 2. In Gecko, please use MOZ_CRASH instead of MOZ_NOT_REACHED unless you care about code size or perf. 3. In JS, we removed JS_NOT_REACHED in favor of MOZ_ASSUME_UNREACHABLE. 4. Don't put code after MO

Re: Changes to file purging during builds

2013-06-28 Thread Gregory Szorc
On 6/25/13 2:19 PM, Ehsan Akhgari wrote: On 2013-06-25 2:52 PM, Gregory Szorc wrote: tl;dr You may experience a change in behavior in build performance In bug 884587, we just changed how file purging occurs during builds. FWIW this has been backed out for now. And it relanded on inbound a f

Re: Best way to make xpcshell provide consistent stack limits?

2013-06-28 Thread Till Schneidereit
On Sat, Jun 29, 2013 at 12:52 AM, Benjamin Smedberg wrote: > On 6/26/13 7:06 PM, Andrew Sutherland wrote: > >> >> >> d) Change xpconnect to use jsnativestack.cpp's ability to tell us what >> the platform stack size actually is and/or nsThread's knowledge of the >> stack size it was created with.

Re: Best way to make xpcshell provide consistent stack limits?

2013-06-28 Thread Benjamin Smedberg
On 6/26/13 7:06 PM, Andrew Sutherland wrote: d) Change xpconnect to use jsnativestack.cpp's ability to tell us what the platform stack size actually is and/or nsThread's knowledge of the stack size it was created with. So on linux we'd use whatever 'ulimit -s' is telling us to do, etc. The

Rendering meeting, Monday July 1, 2:30pm PDT

2013-06-28 Thread Milan Sreckovic
The Rendering meeting is about all things Gfx, Image, Layout, and Media. It takes place every second Monday, alternating between 2:30pm PDT and 5:30pm PDT. The next meeting will take place today, Monday, July 1st at 2:30 PM US/Pacific Please add to the agenda: https://wiki.mozilla.org/Platform/