On Sat, May 15, 2021 at 11:42:06PM +0100, Jessica Clarke wrote:
> I think you two are talking past each other. kib@’s point is that some of the
> changes made in this commit were style *changes* not style *fixes* (i.e. the
> code was compliant before, you’ve just changed it from one acceptable
> fo
On 15 May 2021, at 23:36, Lutz Donnerhacke wrote:
>
> On Sun, May 16, 2021 at 12:30:54AM +0300, Konstantin Belousov wrote:
>>> The LIBALIAS_LOCK_ASSERT and the variable declarations were not moved.
>> So you changed some style, but left the large violation in place.
>
> This cleanup is a prepara
On Sun, May 16, 2021 at 12:30:54AM +0300, Konstantin Belousov wrote:
> > The LIBALIAS_LOCK_ASSERT and the variable declarations were not moved.
> So you changed some style, but left the large violation in place.
This cleanup is a preparation to fix various issues in this code.
So yes, the change w
On Sat, May 15, 2021 at 10:51:33PM +0200, Lutz Donnerhacke wrote:
> On Sat, May 15, 2021 at 11:14:31PM +0300, Konstantin Belousov wrote:
> > On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote:
> > > Of course it was a style commit.
> > >
> > > + /*
> > > + De-alias incoming echo
Konstantin Belousov kostikbel at gmail.com wrote on
Sat May 15 19:42:08 UTC 2021 :
> On Sat, May 15, 2021 at 07:01:07AM +, Lutz Donnerhacke wrote:
> > . . .
> > +static int
> > +IcmpAliasIn1(struct libalias *la, struct ip *pip)
> > +{
> > + LIBALIAS_LOCK_ASSERT(la);
> > struct alias_link
On Sat, May 15, 2021 at 11:14:31PM +0300, Konstantin Belousov wrote:
> On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote:
> > Of course it was a style commit.
> >
> > + /*
> > + De-alias incoming echo and timestamp replies.
> > + Alias incoming echo and timestamp requests.
On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote:
> On Sat, May 15, 2021 at 10:41:53PM +0300, Konstantin Belousov wrote:
> > On Sat, May 15, 2021 at 07:01:07AM +, Lutz Donnerhacke wrote:
> > > @@ -285,21 +283,20 @@ static int UdpAliasOut(struct libalias *, struct
> > > ip *, i
On Sat, May 15, 2021 at 10:41:53PM +0300, Konstantin Belousov wrote:
> On Sat, May 15, 2021 at 07:01:07AM +, Lutz Donnerhacke wrote:
> > @@ -285,21 +283,20 @@ static intUdpAliasOut(struct libalias *, struct
> > ip *, int, int create);
> > static int TcpAliasIn(struct libalias *, struct ip
On Sat, May 15, 2021 at 07:01:07AM +, Lutz Donnerhacke wrote:
> The branch main has been updated by donner:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=effc8e57fbf03d7f1423c662caf2b63f0d1d21a9
>
> commit effc8e57fbf03d7f1423c662caf2b63f0d1d21a9
> Author: Lutz Donnerhacke
> Author
