On Sat, May 15, 2021 at 11:42:06PM +0100, Jessica Clarke wrote: > I think you two are talking past each other. kib@’s point is that some of the > changes made in this commit were style *changes* not style *fixes* (i.e. the > code was compliant before, you’ve just changed it from one acceptable > formatting to another), and that there were instances of significant style > violations *not* fixed (e.g. the assertion macro before variable declarations > pointed out). He is not talking about functional violations, only style ones. > However, in your defence, your original commit did not claim to fix *all* > style > violations, only "most annoying style errors", though that doesn’t account for > unnecessary churn as seen with the blank lines at the starts of functions.
You are right. Let's close this discussion. _______________________________________________ dev-commits-src-main@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main To unsubscribe, send any mail to "dev-commits-src-main-unsubscr...@freebsd.org"
