[GitHub] incubator-zeppelin pull request: Clone a note

2015-08-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/219#issuecomment-132387297 +1 on copy icon and interpreter bindings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: Option to choose default interpre...

2015-08-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/222#issuecomment-132387939 is this default going to be stored with the interpreter binding? perhaps some sort of template so one can create a python notebook, for example

[GitHub] incubator-zeppelin pull request: Protect from NPE when creating In...

2015-08-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/223#issuecomment-132389778 I didn't quite get, what was the root cause of the NPE? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-zeppelin pull request: ZEPPELIN-227 Allow nextline invok...

2015-08-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/220#issuecomment-132828943 cool it seems to work ![image](https://cloud.githubusercontent.com/assets/8969467/9372415/095080e2-4693-11e5-8558-7b10ad70f1c1.png) --- If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-227 Allow nextline invok...

2015-08-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/220#issuecomment-132829280 hmm, but not this (this is without fix in this PR) ![image](https://cloud.githubusercontent.com/assets/8969467/9372453/68840df4-4693-11e5-8e9f

[GitHub] incubator-zeppelin pull request: ZEPPELIN-227 Allow nextline invok...

2015-08-20 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/220#issuecomment-133184320 looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Option to choose default interpre...

2015-08-20 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/222#issuecomment-133195137 It's convenient. I think there are some practical use cases for a single language/interpreter notebook (like IPython). At least I think it help use

[GitHub] incubator-zeppelin pull request: Option to choose default interpre...

2015-08-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/222#issuecomment-133507012 @Leemoonsoo great point on copy notebook --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: ZEPPELIN-252: Add PostgreSQL Inte...

2015-08-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/239#issuecomment-133508427 looks great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: ZEPPELIN-251: Postgresql Interpre...

2015-08-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/237#issuecomment-133508501 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Restart spark interpreter when th...

2015-08-23 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/228#issuecomment-133934888 We could call `sc.stop()` or `SparkIMain.reset()`? Though apparently SparkIMain reset() has some issue: https://issues.apache.org/jira/browse/SPARK

[GitHub] incubator-zeppelin pull request: ZEPPELIN-160 Working with provide...

2015-08-24 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/244#issuecomment-134069646 looks good. this is a very important change, thanks for making it --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: ZEPPELIN_PORT=10008 removed

2015-08-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/255#issuecomment-135201501 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-236: state representatio...

2015-08-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/257#issuecomment-135201699 Do you have a screen cap of this with the textbox with unsaved text state (text box left bar has a color)? --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: ZEPPELIN-269 : Adding Error Msg a...

2015-08-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/263#issuecomment-135905228 looks good... what is the guideline on when to show this notification? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-270 added env varibles f...

2015-08-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/264#issuecomment-135905387 It should build this automatically when SPARK_HOME is defined right? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-270 added env varibles f...

2015-08-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/264#issuecomment-135931941 Hmm, should we use SparkConf instead then: https://github.com/apache/spark/blob/69c9c177160e32a2fbc9b36ecc52156077fca6fc/yarn/src/main/scala/org

[GitHub] incubator-zeppelin pull request: ZEPPELIN-270 added env varibles f...

2015-08-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/264#issuecomment-136522014 @Leemoonsoo good idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-273 Spark 1.5 support

2015-08-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/269#issuecomment-136526195 Instead of int/const, should we use enum for this? Instead we could say: `hasDataFrame` or `hasSchemaRDD` etc? --- If your project is set up

[GitHub] incubator-zeppelin pull request: ZEPPELIN-273 Spark 1.5 support

2015-08-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/269#issuecomment-136550204 looks good! thanks for this, I'm going to pick this up with the "provided spark" change --- If your project is set up for it, you ca

[GitHub] incubator-zeppelin pull request: ZEPPELIN-273 Spark 1.5 support

2015-08-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/269#issuecomment-136557244 awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Update documentation: Set informa...

2015-09-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/265#issuecomment-136956164 +1 on 3.2.3 - I think that version is required to build Spark --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Lowering to ping timeout to have ...

2015-09-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/272#issuecomment-137476487 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-262 Use spark-submit to ...

2015-09-04 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/270#issuecomment-137903488 looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: ZEPPELIN-277: Set the (TAB) key a...

2015-09-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/273#issuecomment-138098691 +1 @Leemoonsoo https://issues.apache.org/jira/browse/ZEPPELIN-214 I think we should be good with this PR and track the bigger work on interpreter

[GitHub] incubator-zeppelin pull request: HBase Shell Interpreter

2015-09-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/278#issuecomment-138099373 Could you elaborate on what this does? ``` hbase.irb.load: (Testing only) Default is true. Whether to load irb in the interpreter

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-283] IllegalArgumentExc...

2015-09-06 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/284 [ZEPPELIN-283] IllegalArgumentException when running provided Spark 1.5.0 snapshot build This relax the Spark version check to allow for "1.5.0-SNAPSHOT" @Leemoo

[GitHub] incubator-zeppelin pull request: ZEPPELIN-284

2015-09-07 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/287#issuecomment-138359475 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-298 Paragraph progress b...

2015-09-10 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/294#issuecomment-139389497 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Add documentation on how to add s...

2015-09-10 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/297 Add documentation on how to add syntax highlighting in the ACE editor For a new programming language You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-zeppelin pull request: ZEPPELIN-297 Dependency should be...

2015-09-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/298#issuecomment-139690876 LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn

2015-09-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/299#issuecomment-139692299 Could you please reference the JIRA ticket here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: [Website] adding DOAP file for pr...

2015-09-14 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/300#issuecomment-140147567 looks fine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-303 Zeppelin should exit...

2015-09-14 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/301#issuecomment-140149273 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

2015-09-15 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140585375 Thanks for looking into this. I myself have also bitten by this issue. Is this the right user experience though, storing something that is

[GitHub] incubator-zeppelin pull request: ZEPPELIN-296 add flink docs

2015-09-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/303#issuecomment-141516770 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-306 - Fix Notebook Actio...

2015-09-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/314#issuecomment-142160809 looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Update angular.md

2015-09-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/317#issuecomment-142453101 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Spark 1.5 moved to first place

2015-09-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/326#issuecomment-143904932 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-09-29 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/328 [ZEPPELIN-328] Interpreter page should clarify the % magic syntax for interpreter group.name Currently the Interpreter page like the interpreters as hive %hql However, this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-09-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-144201238 Any comment is welcome --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-09-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-144201203 Before ![image](https://cloud.githubusercontent.com/assets/8969467/10179144/eefdde74-66b8-11e5-90de-25e2a238a256.png) After ![image

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-09-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-144271689 I guess it's not required but the name is used as the group if absent Interpreter.java ``` public static void register(String name, S

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-09-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-144274306 Better? ![image](https://cloud.githubusercontent.com/assets/8969467/10184013/6d1f658e-66eb-11e5-9b6b-8ce5a66c9803.png) ![image](https

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-09-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-144291364 I think that is in fact correct - you could run the default interpreter in any group with %group but not %name - ie. `%hive` works but `%hql` does not

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-09-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-144306297 I think you mean %hql (interpreter name) not working. Using `%hive` (hql is the default interpreter) or `%spark` (spark/scala is the default

[GitHub] incubator-zeppelin pull request: Fix typo in Spark interpreter doc...

2015-09-30 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/330#issuecomment-144493478 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Change logging level to not print...

2015-09-30 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/329#issuecomment-144493652 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-10-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-144815284 any more feedback on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-10-02 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-145189910 I looked into this more. The default interpreter for a given group is the first interpreter: https://github.com/apache/incubator-zeppelin/blob

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-10-08 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-146723019 Updated to handle default group. My understanding is the default group is the first interpreter group from config. Here's what it looks

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-10-08 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-146730179 because when spark is the default group, you can run pyspark by simply putting `%pyspark%` at the beginning of the paragraph. This is my understanding

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-10-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/328#issuecomment-147779901 any more thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...

2015-10-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147855008 Since the auto-save is timer based, I do agree it is confusing to see a new paragraph appearing by itself. I agree with @Leemoonsoo that the 

[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...

2015-10-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147855146 And sometimes one does not want a new paragraph created automatically --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Update modules prerequisites

2015-10-14 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/342#issuecomment-148183257 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-342 Ignite interpreter u...

2015-10-16 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/344#issuecomment-148785887 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-345 Duplicate "Ctri + n"...

2015-10-16 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/346#issuecomment-148786244 looks good! thanks for fixing this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-349: Resolve NPE on null...

2015-10-16 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/348#issuecomment-148882452 Could you please include bug info in PR description? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: Fix typos in documentation

2015-10-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/352#issuecomment-149300567 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Format table and fix flink to fli...

2015-10-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/350#issuecomment-149300655 nice, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: JDBC generic interpreter

2015-10-23 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150661569 @tzolov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-334 Add documentation fo...

2015-10-24 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/360#issuecomment-150853358 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-360 Remove "Copyright 20...

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/364#issuecomment-150986444 looks good? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: ZEPPELIN-359 add NOTICE and DISCL...

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/363#issuecomment-150986471 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-361 Move licese of subco...

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/365#issuecomment-150986631 Spark does it by referring to copies under a license directory. Should that be done here? https://github.com/apache/spark/tree/master/licenses

[GitHub] incubator-zeppelin pull request: ZEPPELIN-338 Add documentation fo...

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/359#issuecomment-150986734 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: JDBC generic interpreter

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150986836 There's another earlier attempt for this #211, #60 Other JDBC-like use cases perhaps you could also factor into your design? #73, #110 -

[GitHub] incubator-zeppelin pull request: ZEPPELIN-362 Add maven-remote-res...

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/366#issuecomment-150986877 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-354] - List Notebook RE...

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/367#issuecomment-150986921 Are you able to figure why the link to json files are broken on the doc site? --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-357] Add support for a ...

2015-10-25 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/368 [ZEPPELIN-357] Add support for a configurable list of repo for dependencies Make it configurable via `zeppelin.dep.additionalRemoteRepository`, with spark-packages default. This

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-357] Add support for a ...

2015-10-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/368#issuecomment-150989388 In action: ![image](https://cloud.githubusercontent.com/assets/8969467/10718905/5ff9ab4a-7b3a-11e5-83aa-f4223e06ca4f.png) ![image](https

[GitHub] incubator-zeppelin pull request: ZEPPELIN-265 auto save on page na...

2015-10-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/357#issuecomment-151234965 maybe @nberserk can comment, it looks like we are not checking isNoteDirty anyway? --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-357] Add support for a ...

2015-10-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/368#issuecomment-151716440 @bzz ah yes, I was going to update http://zeppelin.incubator.apache.org/docs/interpreter/spark.html as the next step. It looks like it gets stale a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-364 Make interpreter set...

2015-10-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/371#issuecomment-152009968 There are other configuration though: log4j.properties, zeppelin-site.xml, zeppelin-env.sh, interpreter.json Why not just push the config

[GitHub] incubator-zeppelin pull request: JDBC generic interpreter

2015-10-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-152012132 If I recall there were 3 areas of discussions around JDBC: 1. JDBC url, authentication etc would need to be extensible since they vary greatly

[GitHub] incubator-zeppelin pull request: ZEPPELIN-372 : Exporting a notebo...

2015-10-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/376#issuecomment-152285554 should we have a test for export/import round tripping? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-371 : Import a notebook

2015-10-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/374#issuecomment-152285675 could we add test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-377 CI hanging on ./test...

2015-10-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/380#issuecomment-152761091 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-375 HOTFIX move geode fr...

2015-10-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/379#issuecomment-152761174 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-376 http://zeppelin.incu...

2015-10-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/378#issuecomment-152761290 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: added autocompletion

2015-11-02 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/382#issuecomment-153129073 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: added autocompletion

2015-11-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/382#issuecomment-153526461 Do we have a JIRA for the additional work? If not, @xhudik could you create one? --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: ZEPPELIN-389: Longer Paragraph Ti...

2015-11-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/388#issuecomment-153526585 nice, thanks for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-386 provide links to ind...

2015-11-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/387#issuecomment-153526889 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Correct contact e-mail in documen...

2015-11-05 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/393#issuecomment-154204144 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-299 Support clearing out...

2015-11-05 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/372#issuecomment-154204275 @vinayshukla no since this PR is still open... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-396 Add -Pypspark profil...

2015-11-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/396#issuecomment-154362865 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-397 Activate spark-1.5 a...

2015-11-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/397#issuecomment-154363364 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-404 Certain project depe...

2015-11-08 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/404#issuecomment-154866069 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-406 Handle license issue...

2015-11-08 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/407#issuecomment-154868436 looks good. it's a bit odd to have a html license header on the json content - should we just put the json sample on the API doc page inste

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-11-09 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/411#issuecomment-155151379 Changes look good I think in order to match the interpreter group omit rule it should be ``` %hql -- not work %hive.hql -- work

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-11-09 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/411#issuecomment-155257329 Is spark-local a group? it seems to have the same group name as the default group (which is also spark)? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: Zeppelin Flink Spark tutorial

2015-11-10 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/418#issuecomment-155594138 If I understand correctly this requires a special build of Flink? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-407] Improve document o...

2015-11-10 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/410#issuecomment-155596456 looks good, this covers most of this earlier bug: ZEPPELIN-368 I'd say we would need to add: complete list of properties supported by interpr

[GitHub] incubator-zeppelin pull request: Zeppelin Flink Spark tutorial

2015-11-10 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/418#issuecomment-155618776 I see, so this is referring to 0.10 Flink only? " http://trevorgrant.org/2015/11/03/apache-casserole-a-delicious-big-data-recipe-for-the-

[GitHub] incubator-zeppelin pull request: ZEPPELIN-383 Override classpath w...

2015-11-10 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/412#issuecomment-155619296 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-328] Interpreter page s...

2015-11-10 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/411#issuecomment-155652264 looks good. agreed multi-binding of the interpreter is confusing. also we might need to support multiple working instances too. --- If your project

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-407] Improve document o...

2015-11-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/410#issuecomment-155709616 Sure! Please feel free. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-zeppelin pull request: Zeppelin Flink Spark tutorial

2015-11-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/418#issuecomment-155912343 docs/assets/ like in: docs/assets/themes/zeppelin/img --- If your project is set up for it, you can reply to this email and have your reply

  1   2   3   4   5   6   7   >