[GitHub] incubator-zeppelin pull request: ZEPPELIN-270 added env varibles f...

[felixcheung]

Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/264#issuecomment-135931941
  
    Hmm, should we use SparkConf instead then:
    
    
https://github.com/apache/spark/blob/69c9c177160e32a2fbc9b36ecc52156077fca6fc/yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
    ```
        // Keep this for backwards compatibility but users should move to the 
config
        sys.env.get("SPARK_YARN_USER_ENV").foreach { userEnvs =>
          YarnSparkHadoopUtil.setEnvFromInputString(env, userEnvs)
        }
    ```
    
    I believe all spark.* in the interpreter settings are passed to SparkConf.
    
    
https://github.com/apache/incubator-zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
    
    Is this a bug:
    ```
          if (!key.startsWith("spark.") || !val.trim().isEmpty()) {
            logger.debug(String.format("SparkConf: key = [%s], value = [%s]", 
key, val));
            conf.set(key, val);
          }
    ```
    
    Shouldn't it say `if (key.startsWith("spark.")`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---