[GitHub] zeppelin issue #1708: [ZEPPELIN-1728] Add an example configuring classpath f...

2016-11-30 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1708 LGTM. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1840: [ZEPPELIN-1730, 1587] add spark impersonation through ...

2017-01-05 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1840 Thank you @khalidhuseynov . On > user configures export ZEPPELIN_IMPERSONATE_CMD in here with kinit @ -k -t and then it's run before spark-submit The only problem I

[GitHub] zeppelin issue #1840: [ZEPPELIN-1730, 1587] add spark impersonation through ...

2017-01-10 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1840 As far as credentials refresh are concerned, please see new comments in [SPARK-19143](https://issues.apache.org/jira/browse/SPARK-19143). Hope this helps. --- If your project is set up for it

[GitHub] zeppelin issue #1913: [ZEPPELIN-1979] fix 'File size limit Exceeded' when im...

2017-01-19 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1913 Thank you @khalidhuseynov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1921: [ZEPPELIN-1984] Zeppelin Server doesn't catch a...

2017-01-20 Thread Tagar
GitHub user Tagar opened a pull request: https://github.com/apache/zeppelin/pull/1921 [ZEPPELIN-1984] Zeppelin Server doesn't catch all exceptions when launching interpreter.sh https://issues.apache.org/jira/browse/ZEPPELIN-1984 > DEBUG [2017-01-20 13:56:37,688

[GitHub] zeppelin issue #1921: [ZEPPELIN-1984] Zeppelin Server doesn't catch all exce...

2017-01-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1921 I've tested Zeppelin with this one-line 42b02bd commit change and now RemoteInterpreterManagedProcess.java correctly gets return code as 1, notice `Process exited with an err

[GitHub] zeppelin issue #1931: [ZEPPELIN-1894] Capture stdin/stdout on interpreter pr...

2017-01-21 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1931 Thanks a lot @Leemoonsoo . ps. PR title misspelled ZEPPELIN-1894 -> ZEPPELIN-1984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] zeppelin issue #1921: [ZEPPELIN-1984] Zeppelin Server doesn't catch all exce...

2017-01-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1921 @Leemoonsoo I rebased this PR and it went green. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1931: [ZEPPELIN-1984] Capture stdin/stdout on interpreter pr...

2017-01-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1931 Tested today's master merged with #1931 and #1921 and it works great. LGTM Thanks again. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-03-01 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1663 Just upgraded to yesterday's master snapshot. When I click on any of these links, link is leading to http://hostname.domain.com:8088/proxy/application_1488384993892_0001/job

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-03-03 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1663 @karuppayya thank you for the follow up. A little bit more information - the link on paragprah leads to > http://10.20.32.57:28009/jobs/job?id=123 A Spark Driver

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-03-06 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1663 According to https://github.com/apache/spark/pull/5947 URL format is different in YARN and non-YARN modes? Was PR-1663 for ZEPPELIN-1692 tested on both of these modes? Not sure what else might

[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...

2017-04-03 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1536 IMHO, automatically adding `" (1)", " (2)" ..` etc to a note name in case of duplicate name found might be a better solution than disallowing import at all. A variation on

[GitHub] zeppelin issue #2302: [minor] Improve Session

2017-04-30 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2302 This PR breaks authentication for me .. in a weird way. After authentication (we use LDAP shiro) - I can log in, but after attempt to open any note, it closes session and redirects me back to

[GitHub] zeppelin issue #2304: [hotfix] Improve Session #2302 fix

2017-04-30 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2304 Thanks for prompt response @prabhjyotsingh I've retested with `currentUser.login(token)` moved down 2 lines - Zeppelin doesn't kick out now after attempt to open a note

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-11 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2329 Great job. Exciting to see this new feature in Zeppelin. My two cents: > through thrift in yarn-cluster mode Cloudera's Spark don't have thrift service and Clo

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-11 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2329 @zjffdu @jongyoul got it - thanks for prompt response. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-05-16 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1663 Does this feature work for anyone who is using Spark on YARN? It seems to be broken by https://issues.apache.org/jira/browse/SPARK-20772 I've updated https://issues.apache.org

[GitHub] zeppelin issue #2407: [ZEPPELIN-1907] Shell Interpreter does not renew ticke...

2017-06-27 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2407 Great addition. Thank you. Btw, `renew_lifetime` although can be set in `krb5.conf`, it's maximum value is limited on Active Directory side if AD is used for Kerberos, look for ex

[GitHub] zeppelin issue #2407: [ZEPPELIN-1907] Shell Interpreter does not renew ticke...

2017-06-28 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2407 @prabhjyotsingh, created https://issues.apache.org/jira/browse/ZEPPELIN-2703 Let me know what do you gyus think? --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2502 @sanjaydasgupta great job on getting this done. ZEPPELIN-1967 was inspired by Jupyter so I just we should do the same as it is done there. So it's less confusing for users who are swit

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-01 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2502 Info from Jupyter comitter @takluyver > It's fairly brief, but here: > http://ipython.readthedocs.io/en/stable/interactive/reference.html#manual-capture-of-command-outpu

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2502 My two cents > One of the things I learned about Jupyter's implementation is that it never intercepts an error case I personally not necessarily like how this piece is imp

[GitHub] zeppelin issue #2601: [ZEPPELIN-2956] [font-end] Downloaded CSV/TSV data wil...

2017-10-06 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2601 I wonder if it's related to https://issues.apache.org/jira/browse/ZEPPELIN-1803 ? ---

[GitHub] zeppelin issue #2631: ZEPPELIN-2197. Interpreter Lifecycle Manager

2017-10-25 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2631 Thank you @zjffdu. I just thought about this scenario: a Spark job runs for 1.5 hours, would it be killed by the LifeCycleManager in this case? (assuming here default timeout of 1 hour) If

[GitHub] zeppelin issue #2631: ZEPPELIN-2197. Interpreter Lifecycle Manager

2017-10-25 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2631 @zjffdu got it - thank you. ---

[GitHub] zeppelin issue #2631: ZEPPELIN-2197. Interpreter Lifecycle Manager

2017-10-25 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2631 One last thing - from user experience it would be convenient to know when their interpreters timed out. Something like a popup or just some sort of a graphical flag would do, I guess? Not

[GitHub] zeppelin issue #2555: [ZEPPELIN-2885] Have Logger subclass StringIO and over...

2017-10-31 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2555 @sctincman Did you find a workaround for this issue ? Thanks ---

[GitHub] zeppelin issue #2555: [ZEPPELIN-2885] Have Logger subclass StringIO and over...

2017-10-31 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2555 Found this works around the issue on Python 2.. will test more. ``` import sys sys.stdout.isatty = lambda : False sys.stdout.encoding = None ``` ---

[GitHub] zeppelin issue #2555: [ZEPPELIN-2885] Have Logger subclass StringIO and over...

2017-11-02 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2555 FYI This Zeppelin issue will be worked around in Sparkling Water in following PR - https://github.com/h2oai/h2o-3/pull/1705 ---

[GitHub] zeppelin issue #2723: ZEPPELIN-3119. Build issue with CDH

2018-01-11 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2723 thank you @zjffdu ---

[GitHub] zeppelin issue #2744: ZEPPELIN-3184. Use hadoop-azure to replace azure-stora...

2018-02-11 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2744 This commit broke build for CDH (maven convergence error on dependencies). Should there be a automated test to check if a commit breaks compatibility with Cloudera distro of Hadoop? ---

[GitHub] zeppelin issue #2744: ZEPPELIN-3184. Use hadoop-azure to replace azure-stora...

2018-02-11 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2744 Do you mean compile without option like > -Dhadoop.version=2.6.0-cdh5.12.1 ? It compiles fine but I was getting runtime errors (like some non-existent method etc). Ca

[GitHub] zeppelin issue #2790: ZEPPELIN-3222. Shade libfb303 in SparkInterpreter

2018-02-11 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2790 Manually tested master with this PR when using CDH 5.12 and it solves NPE issue when starting Spark interpreter. Thanks @zjffdu ! ---

[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering

2018-02-12 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2782 Since we migrated from Jupyter to Zeppelin, I miss a lot floating ToC menu Jupyter extension. Super useful for larger notebooks - navigation becomes very transparent. http://jupyter

[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

2018-02-14 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2802 Thanks for the heads up, yep I figured out that I have to tune up zeppelin.ipython.grpc.framesize to a large number. I looked over the PR. Two quick suggestions 1) Would it be possible

[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

2018-02-14 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2802 1) My main point was that this exception should be thrown to the user, so he or she has a chance to increase this limit. Currently if it breaks, only way to find out about this limitation is to

[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

2018-02-15 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2802 @zjffdu I don't have a reproducible case yet. This error hasn't been very consistent for me so it might be also a side effect of another problem. That's why I asked above if w

[GitHub] zeppelin issue #2805: [ZEPPELIN-3240] Zeppelin server fail to start if inter...

2018-02-16 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2805 Are those kind of properties mix in interpreter could happen because of Zeppelin upgrade? I.e. old properties and new properties mix? ---

[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

2018-02-18 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2802 > ERROR [2018-02-14 10:39:10,922] ({grpc-default-executor-3} IPythonClient.java[onError]:138) - Fail to call IPython grpc > io.grpc.StatusRuntimeException: RESOURCE_EXH

[GitHub] zeppelin issue #2808: [ZEPPELIN-3243] fix IndexOutOfBoundsException when 'No...

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2808 I think I've seen this behavior too. Thanks for fixing this. ---

[GitHub] zeppelin issue #2810: ZEPPELIN-3239. unicode characters in an iPython paragr...

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2810 thanks @zjffdu! will give this a try today. ---

[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2802 thank you @zjffdu - I will check this today. ---

[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2782 I think a low-hanging fruit here might be if Zeppelin would treat paragraph titles as mark down code? So if you added leading `#` it would mean a high-level section of the notebook, `##` would

[GitHub] zeppelin issue #2810: ZEPPELIN-3239. unicode characters in an iPython paragr...

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2810 Verified manually. Works as expected. Thanks a lot @zjffdu ---

[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2802 LGTM thanks a lot @zjffdu ---

[GitHub] zeppelin issue #2802: ZEPPELIN-3236. Make grpc framesize configurable

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2802 @zjffdu I just verified this new commit and it works great. Glad to see exceptions in ipython backend are now being captured correctly. I wasn't able to actually test frame size pr

[GitHub] zeppelin issue #2649: [ZEPPELIN-3033] IPYNB import/export

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2649 Would be great to have this functionality part of core Zeppelin. Any plans to move this PR forward? Thanks! ---

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2323 Great improvement. Submitted https://issues.apache.org/jira/browse/ZEPPELIN-3251 to consider showing rows/columns lazily on scrolling events as otherwise ui-grid has a significant overhead for

[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table

2018-02-21 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2809 I think as a nice side effect, this PR also fixes https://issues.apache.org/jira/browse/ZEPPELIN-3238 - see comments there ---

[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...

2018-02-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2624 This commit seems broke Tab to indent text behavior. https://issues.apache.org/jira/browse/ZEPPELIN-3253 ---

[GitHub] zeppelin pull request #2812: disable tab completion

2018-02-22 Thread Tagar
GitHub user Tagar opened a pull request: https://github.com/apache/zeppelin/pull/2812 disable tab completion ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide -

[GitHub] zeppelin pull request #2812: disable tab completion

2018-02-22 Thread Tagar
Github user Tagar closed the pull request at: https://github.com/apache/zeppelin/pull/2812 ---

[GitHub] zeppelin issue #2812: disable tab completion

2018-02-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2812 One way to fix [ZEPPELIN-3253](https://issues.apache.org/jira/browse/ZEPPELIN-3253?focusedCommentId=16373706&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1637

[GitHub] zeppelin issue #2822: ZEPPELIN-3242. Listener threw an exception java.lang.N...

2018-02-27 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2822 thank you @zjffdu - I will give this a try today ---

[GitHub] zeppelin issue #2822: ZEPPELIN-3242. Listener threw an exception java.lang.N...

2018-02-27 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2822 Manually tested. Works as expected. This PR fixes: - Spark job progress bar - ability to cancel as spark job from paragraph - Spark Driver web UI link. Thanks a lot

[GitHub] zeppelin issue #2817: [ZEPPELIN-3264] Notebook Snapshot feature.

2018-03-01 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2817 @SleepyThread - great feature! Building on @felixcheung's comment, it would be good if Snapshot feature would use org.apache.zeppelin.notebook.repo.GitNotebookRepo to store a sna

[GitHub] zeppelin issue #2833: ZEPPELIN-3286. Run All Paragraphs stops if there is a ...

2018-03-05 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2833 thanks Jeff! will validate a bit later today. ---

[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

2018-03-05 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2835 @weand I just logged in https://issues.apache.org/jira/browse/ZEPPELIN-3292 for data duplication ) I don't think it's related to this PR? ---

[GitHub] zeppelin issue #2833: ZEPPELIN-3286. Run All Paragraphs stops if there is a ...

2018-03-07 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2833 Tested manually - this patch fixes issue described in ZEPPELIN-3286 Thank you @zjffdu ---

[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering

2018-03-13 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2782 I think it's a good improvement. As an example, Databricks spark notebooks also have paragraph numbering across whole notebook. Thanks. ---

[GitHub] zeppelin issue #2684: [Zeppelin-2572] multiple paragraphs actions

2018-03-14 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2684 Just noticed this.. I think it's a great feature! In Jupyter we can also select multiple paragraphs. Although it is made more seamless.. I believe you could Ctrl+click anywhere

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-14 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2834 Great improvement! Many of our users were asking for this since day one they started using Zeppelin. Like, "how do I pass a variable from %pyspark paragraph to %sh one.. " Le

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-15 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2834 What happens when a notebook had code {something} and "something" doesn't exist as a 'z' variable? Would it be possible to review that comment I left earlier i

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-17 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2834 @zjffdu Great idea on paragraph-level properties! There are so many possible uses for this feature like ones you explained below. For interpolation I think there should be a way to do it

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2834 @zjffdu, @felixcheung would be exciting to have this feature be part of the 0.8.0 release. Since there is a way to maintain backward compatibility, it seems to be a low hanging fruit as

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

2018-03-26 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2894 Thanks @zjffdu cc @prabhjyotsingh - you were saying in [a comment for ZEPPELIN-3292](https://issues.apache.org/jira/browse/ZEPPELIN-3292?focusedCommentId=16387420&

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-12 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2923 Great idea.. I had a similar jira https://issues.apache.org/jira/browse/ZEPPELIN-2886 Thanks! ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-18 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2923 I was thinking we should also lower-case usernames that are stored in `notebook-authorization.json`, when doing authorization. Otherwise users wouldn't be able to see their own notebooks when

[GitHub] zeppelin issue #2742: [ZEPPELIN-3168] Interpreter Settings Authorization

2018-04-26 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2742 @necosta thanks for this great feature. It makes a lot of sense for Zeppelin instance shared with different set of users. Would it be possible to do this interpreter settings authorization for LDAP

[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine

2018-05-02 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2760 @zjffdu, just updated to master, and noticed versioning toolbar is missing... I think it's because of this PR. We have `zeppelin.notebook.st

[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine

2018-05-03 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2760 I wonder if https://github.com/apache/zeppelin/pull/2945 fixes issue I described in my earlier comment. cc @cvaliente @myuwono ---

[GitHub] zeppelin issue #2945: [ZEPPELIN-3430] fix logic of loading githubnotebookrep...

2018-05-03 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2945 This PR fixes the issue I described in https://github.com/apache/zeppelin/pull/2760#issuecomment-386148566 Now the git/versioning subpanel is back! Thanks. ---

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-15 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2963 Thanks for fixing this - I just had a chance to test and confirm it fixes number sorting. PR title reads "Number sorting issue", but code change seems tries to address String and Da

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-21 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2963 @sameer79 I was using latest Zeppelin from master snapshot. Chrome browser. Can you reproduce the same sorting issue for strings? Here's the code I used: ```python %py

[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift

2018-05-21 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2975 checked a few newer CDH 5 versions and they're packaged with 0.9.3. older CDH 5 version come with 0.9.2. CDH 6 will be shipped with 0.9.3 too. my two cents: +1 from me. thanks. ---

[GitHub] zeppelin issue #2974: ZEPPELIN-3472 No interpreter status is shown after res...

2018-05-21 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2974 I think it's a great idea to add something like this to also show status if an interpreter is running. so show a green icon if interpreter is running/ or had been restarted success

[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...

2018-05-21 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2971 Could you please also have a look at https://issues.apache.org/jira/browse/ZEPPELIN-3478 CSV/TSV exports seem to be broken too. ---

[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2975 @felixcheung as an example, I've seen NoSuchMethodError exceptions like one below when working with Spark interpreter reading Hive tables and Thrift version had a version mismatch .. so it ma

[GitHub] zeppelin issue #2976: [ZEPPELIN-3478] Download Data as CSV downloads data as...

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2976 thanks for prompt response @prabhjyotsingh I will give this a try today. ---

[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2971 How to activate XLS/XLSX download option? It doesn't show up for me with this PR applied. ![image](https://user-images.githubusercontent.com/3013418/40377041-1e9353ec-5dad-11e8

[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2975 @prabhjyotsingh yes, seems that way. It might be more specific for Cloudera or more generic. I know that Cloudera packages CDH with a specific version of Thrift. It used to be 0.9.2 in

[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2975 thanks @prabhjyotsingh bumping up 0.9.3 seems a good idea to me, but I'd like somebody else to review this too. my 2 cents - It might be also good to shade Thrift to avoid future conf

[GitHub] zeppelin issue #2976: [ZEPPELIN-3478] Download Data as CSV downloads data as...

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2976 LGTM Verified manually - this patch fixes the issue. Thanks a lot @prabhjyotsingh ---

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2963 @sameer79 I refreshed my Zeppelin to latest master snapshot. Can't reproduce any longer the issue I specified on the screenshot above. Please disregard my earlier comment.

[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2971 Got it @prabhjyotsingh - thanks. So there are two separate ways to export data now - [1] is the newer way and [2] is the older way. What's advantage of having two export op

[GitHub] zeppelin issue #2979: ZEPPELIN-3484. sc.setJobGroup() shows up in error stac...

2018-05-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2979 Thanks @zjffdu - I will test this today. ---

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2978 Thanks @sanjaydasgupta. I will give this a try today. ---

[GitHub] zeppelin issue #2945: [ZEPPELIN-3430] fix logic of loading githubnotebookrep...

2018-05-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2945 @zjffdu, is it possible to commit this into the 0.8 branch? thanks. ---

[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift

2018-05-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2975 When I build Zeppelin, I see in maven build log > [INFO] Including org.apache.thrift:libthrift:jar:0.9.3 in the shaded jar. > [INFO] Including org.apache.thrift:libfb303:jar:0.

[GitHub] zeppelin issue #2979: ZEPPELIN-3484. sc.setJobGroup() shows up in error stac...

2018-05-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2979 works as expected. thanks for quick turnaround! LGTM. ---

[GitHub] zeppelin issue #2945: [ZEPPELIN-3430] fix logic of loading githubnotebookrep...

2018-05-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2945 got it, thanks @zjffdu ---

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-23 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2978 What's difference between LocalConfigStorage and FileSystemConfigStorage? I don't know Zeppelin internals that well. Wonder if this has to be fixed FileSystemConfigStorage.ja

[GitHub] zeppelin issue #2952: [Zeppelin-2572] multiple paragraphs actions

2018-05-25 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2952 thank you @Savalek @zjffdu would it be possible to merge this to master? (and not to 0.8) thanks! ---

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-28 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2978 @sanjaydasgupta > do you recommend similar treatment for FileSystemConfigStorage also? yep, HDFS although is not a posix filesystem, but renaming a file is still implemented as

[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...

2018-05-29 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2971 Thanks @prabhjyotsingh - filed https://issues.apache.org/jira/browse/ZEPPELIN-3511 to consider removing old export csv/tsv which is broken in some other ways (like when data has double quotes and

[GitHub] zeppelin issue #2601: [ZEPPELIN-2956] [font-end] Downloaded CSV/TSV data wil...

2018-05-29 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2601 > I believe one could remove old button "Download Data as CSV". filed https://issues.apache.org/jira/browse/ZEPPELIN-3511 to remove old export csv/tsv This idea was

[GitHub] zeppelin issue #2978: [ZEPPELIN-3467] two-step, atomic configuration file wr...

2018-05-31 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2978 @sanjaydasgupta, `writeFile` in `FileSystemStorage` drops file first, and then renames temp file. It's not an atomic write, and also leaves a chance to loosing file that is being wr

[GitHub] zeppelin issue #2952: [Zeppelin-2572] multiple paragraphs actions

2018-06-05 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2952 We were using PR this in prod for a couple of weeks. Works great. Left one additional comment based on users feedback. "Select a paragraph" tooltip change to "Add th

[GitHub] zeppelin issue #3000: [ZEPPELIN-3467] two-step, atomic configuration file

2018-06-08 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/3000 > The orphaned file will not be automatically overwritten later because File.createTempFile(...) will always attempt to create a new filename that is unused in the directory. That ma

  1   2   >