[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236471742 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236471742 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236475777 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [zeppelin] jongyoul opened a new pull request, #4623: [HOTFIX] Change the location of bank.csv to fix the integration tests

2023-06-21 Thread via GitHub
jongyoul opened a new pull request, #4623: URL: https://github.com/apache/zeppelin/pull/4623 ### What is this PR for? Changing the location of `bank.csv` which is being used in integration tests ### What type of PR is it? Hot Fix ### Todos * [x] - Change the locatio

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
Reamer commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r123709 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] jongyoul commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2023-06-21 Thread via GitHub
jongyoul commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1600948242 I like it. I totally believe that we should support JDK 11 even though we lose some old versioned compatibility. Let me try to see it eagerly. -- This is an automated message from th