[GitHub] [zeppelin] huage1994 opened a new pull request #4292: [ZEPPELIN-5642] Provide REST API and SDK to get noteId by notePath

2022-01-26 Thread GitBox
huage1994 opened a new pull request #4292: URL: https://github.com/apache/zeppelin/pull/4292 ### What is this PR for? Provide REST API and SDK to get noteId by notePath. ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue?

[GitHub] [zeppelin] asfgit closed pull request #4283: [ZEPPELIN-5626] Allow to use https for Elasticsearch Interpreter

2022-01-26 Thread GitBox
asfgit closed pull request #4283: URL: https://github.com/apache/zeppelin/pull/4283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4292: [ZEPPELIN-5642] Provide REST API and SDK to get noteId by notePath

2022-01-26 Thread GitBox
zjffdu commented on a change in pull request #4292: URL: https://github.com/apache/zeppelin/pull/4292#discussion_r792769624 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java ## @@ -417,6 +417,11 @@ private boolean isNotePathAvailable(St

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4292: [ZEPPELIN-5642] Provide REST API and SDK to get noteId by notePath

2022-01-26 Thread GitBox
zjffdu commented on a change in pull request #4292: URL: https://github.com/apache/zeppelin/pull/4292#discussion_r792775676 ## File path: zeppelin-server/src/test/java/org/apache/zeppelin/rest/NotebookRestApiTest.java ## @@ -120,6 +120,38 @@ public void testGetReloadNote() thr

[GitHub] [zeppelin] zjffdu commented on pull request #4291: [ZEPPELIN-5641] Remove Google Truth to have uniform tests.

2022-01-26 Thread GitBox
zjffdu commented on pull request #4291: URL: https://github.com/apache/zeppelin/pull/4291#issuecomment-1022810240 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [zeppelin] zjffdu commented on pull request #4266: [ZEPPELIN-5576] Improve Zeppelin CI

2022-01-26 Thread GitBox
zjffdu commented on pull request #4266: URL: https://github.com/apache/zeppelin/pull/4266#issuecomment-1022810456 @Reamer Any more comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [zeppelin] asfgit closed pull request #4290: [ZEPPELIN-5636] Improvement: Automatically clean old version for /interpreter/zeppelin-interpreter-shaded-*.jar

2022-01-26 Thread GitBox
asfgit closed pull request #4290: URL: https://github.com/apache/zeppelin/pull/4290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4286: [ZEPPELIN-5613] zeppelin-interpreter-parent: Add dependencyManagement for log4j2 in pom.xml

2022-01-26 Thread GitBox
zjffdu commented on a change in pull request #4286: URL: https://github.com/apache/zeppelin/pull/4286#discussion_r793225527 ## File path: zeppelin-interpreter-parent/pom.xml ## @@ -33,6 +33,35 @@ 0.9.0-SNAPSHOT Zeppelin: Interpreter Parent + +2.17.1 + + + +

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4288: [ZEPPELIN-5632] zeppelin-zengine: Skip load notebook when it is damaged.

2022-01-26 Thread GitBox
zjffdu commented on a change in pull request #4288: URL: https://github.com/apache/zeppelin/pull/4288#discussion_r793226376 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java ## @@ -78,8 +78,8 @@ private void init() throws IOException {

[GitHub] [zeppelin] zjffdu commented on pull request #4287: [ZEPPELIN-5631] block notebook listed when user didn't have owner/reader/admin

2022-01-26 Thread GitBox
zjffdu commented on pull request #4287: URL: https://github.com/apache/zeppelin/pull/4287#issuecomment-1022815886 Should we fix it in the upgrading tool via setting the runner as the reader? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4263: [ZEPPELIN-5574] ConcurrentModificationException in JsonResponse.toString() when getNote with restAPI

2022-01-26 Thread GitBox
zjffdu commented on a change in pull request #4263: URL: https://github.com/apache/zeppelin/pull/4263#discussion_r793235588 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java ## @@ -327,10 +327,9 @@ public String cloneNote(String sourceNote

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4263: [ZEPPELIN-5574] ConcurrentModificationException in JsonResponse.toString() when getNote with restAPI

2022-01-26 Thread GitBox
zjffdu commented on a change in pull request #4263: URL: https://github.com/apache/zeppelin/pull/4263#discussion_r793236551 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java ## @@ -78,12 +81,18 @@ private Date dateUpdated; private i

[GitHub] [zeppelin] Reamer commented on a change in pull request #4263: [ZEPPELIN-5574] ConcurrentModificationException in JsonResponse.toString() when getNote with restAPI

2022-01-26 Thread GitBox
Reamer commented on a change in pull request #4263: URL: https://github.com/apache/zeppelin/pull/4263#discussion_r793335077 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java ## @@ -279,22 +284,36 @@ public void setDefaultInterpreterGroup(String

[GitHub] [zeppelin] Reamer commented on a change in pull request #4263: [ZEPPELIN-5574] ConcurrentModificationException in JsonResponse.toString() when getNote with restAPI

2022-01-26 Thread GitBox
Reamer commented on a change in pull request #4263: URL: https://github.com/apache/zeppelin/pull/4263#discussion_r793335383 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java ## @@ -279,22 +284,36 @@ public void setDefaultInterpreterGroup(String

[GitHub] [zeppelin] Reamer commented on a change in pull request #4263: [ZEPPELIN-5574] ConcurrentModificationException in JsonResponse.toString() when getNote with restAPI

2022-01-26 Thread GitBox
Reamer commented on a change in pull request #4263: URL: https://github.com/apache/zeppelin/pull/4263#discussion_r793335383 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java ## @@ -279,22 +284,36 @@ public void setDefaultInterpreterGroup(String

[GitHub] [zeppelin] Reamer commented on a change in pull request #4263: [ZEPPELIN-5574] ConcurrentModificationException in JsonResponse.toString() when getNote with restAPI

2022-01-26 Thread GitBox
Reamer commented on a change in pull request #4263: URL: https://github.com/apache/zeppelin/pull/4263#discussion_r793335383 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java ## @@ -279,22 +284,36 @@ public void setDefaultInterpreterGroup(String