zjffdu commented on a change in pull request #4263:
URL: https://github.com/apache/zeppelin/pull/4263#discussion_r793236551
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java
##########
@@ -78,12 +81,18 @@
private Date dateUpdated;
private int progress;
// paragraph configs like isOpen, colWidth, etc
- private Map<String, Object> config = new HashMap<>();
+ // Use ConcurrentHashMap to make Note thread-safe which is required by Note
serialization
+ // (saving note to NotebookRepo or broadcast to frontend), see ZEPPELIN-5530.
+ private Map<String, Object> config = new ConcurrentHashMap<>();
// form and parameter settings
public GUI settings = new GUI();
private InterpreterResult results;
// Application states in this paragraph
- private final List<ApplicationState> apps = new LinkedList<>();
+ private final Queue<ApplicationState> apps = new ConcurrentLinkedQueue<>();
Review comment:
Good catch, I don't think it is necessary, I have removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
