[GitHub] [zeppelin] Reamer commented on a change in pull request #4109: [ZEPPELIN-5357] Remove lucene writer lock during shutdown

2021-05-07 Thread GitBox
Reamer commented on a change in pull request #4109: URL: https://github.com/apache/zeppelin/pull/4109#discussion_r628002453 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java ## @@ -371,6 +372,7 @@ private void deleteDoc(String noteId, Pa

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4109: [ZEPPELIN-5357] Remove lucene writer lock during shutdown

2021-05-07 Thread GitBox
cuspymd commented on a change in pull request #4109: URL: https://github.com/apache/zeppelin/pull/4109#discussion_r628125567 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java ## @@ -371,6 +372,7 @@ private void deleteDoc(String noteId, P

[GitHub] [zeppelin] Reamer commented on a change in pull request #4109: [ZEPPELIN-5357] Remove lucene writer lock during shutdown

2021-05-07 Thread GitBox
Reamer commented on a change in pull request #4109: URL: https://github.com/apache/zeppelin/pull/4109#discussion_r628272344 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java ## @@ -371,6 +372,7 @@ private void deleteDoc(String noteId, Pa

[GitHub] [zeppelin] Reamer commented on pull request #4109: [ZEPPELIN-5357] Remove lucene writer lock during shutdown

2021-05-07 Thread GitBox
Reamer commented on pull request #4109: URL: https://github.com/apache/zeppelin/pull/4109#issuecomment-834482991 PullRequest is ready in me eyes. @cuspymd thank you for your comment. If you could review the whole PR again, I would be very grateful. -- This is an automated message from

[GitHub] [zeppelin] zjffdu opened a new pull request #4111: [ZEPPELIN-5356]. Support flink 1.13

2021-05-07 Thread GitBox
zjffdu opened a new pull request #4111: URL: https://github.com/apache/zeppelin/pull/4111 ### What is this PR for? Add new module `flink-1.13-shims` to support flink 1.3. The main change is due to the api change of flink 1.3, we have to use different `TableConfig` for each `TableEnv