[GitHub] zjffdu commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

zjffdu commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469005070 @liuxunorg I just have concern that allowing getting note json is too flexible for users, and it cause risk once the note json

[GitHub] zjffdu edited a comment on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

zjffdu edited a comment on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469005070 @liuxunorg I just have concern that allowing getting note json is too flexible for users. and it cause risk once the not

[GitHub] zjffdu commented on issue #3315: update twittr maven to HTTPS

zjffdu commented on issue #3315: update twittr maven to HTTPS URL: https://github.com/apache/zeppelin/pull/3315#issuecomment-469005777 @dbanda Thanks for the contribution, please create jira and update the PR title. This is

[GitHub] zjffdu commented on issue #3317: [ZEPPELIN-4026] document anonymous access

zjffdu commented on issue #3317: [ZEPPELIN-4026] document anonymous access URL: https://github.com/apache/zeppelin/pull/3317#issuecomment-469005850 LGTM This is an automated message from the Apache Git Service. To respond to t

[GitHub] liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469007734 @zjffdu , Ok! Because I need to get all the paragraphs in the note, i modified it to 2 interface functions. 1. Get a

[GitHub] [zeppelin] monsieurp commented on issue #3313: [ZEPPELIN-4004] add a systemd unit file to launch the Zeppelin daemon via systemd commands

monsieurp commented on issue #3313: [ZEPPELIN-4004] add a systemd unit file to launch the Zeppelin daemon via systemd commands URL: https://github.com/apache/zeppelin/pull/3313#issuecomment-469019132 Hi guys. Thanks for the feedback. I've added the needed and requested documentation. Pleas

[GitHub] [zeppelin] monsieurp commented on issue #3313: [ZEPPELIN-4004] add a systemd unit file to launch the Zeppelin daemon via systemd commands

monsieurp commented on issue #3313: [ZEPPELIN-4004] add a systemd unit file to launch the Zeppelin daemon via systemd commands URL: https://github.com/apache/zeppelin/pull/3313#issuecomment-469019133 Hi guys. Thanks for the feedback. I've added the needed and requested documentation. Pleas

[GitHub] [zeppelin] monsieurp removed a comment on issue #3313: [ZEPPELIN-4004] add a systemd unit file to launch the Zeppelin daemon via systemd commands

monsieurp removed a comment on issue #3313: [ZEPPELIN-4004] add a systemd unit file to launch the Zeppelin daemon via systemd commands URL: https://github.com/apache/zeppelin/pull/3313#issuecomment-469019132 Hi guys. Thanks for the feedback. I've added the needed and requested documentatio

[GitHub] [zeppelin] zjffdu commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

zjffdu commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469023345 @liuxunorg How about just using one api such as getParagraphsTextList otherwise you need to call these api multiple times ---

[GitHub] [zeppelin] liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469024233 @zjffdu , Redesigned the call interface, `authenticationInfo` can be used to check if the user has read permission to get t

[GitHub] [zeppelin] liuxunorg edited a comment on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

liuxunorg edited a comment on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469024233 @zjffdu , Redesigned the call interface, `authenticationInfo`(`AuthenticationInfo` to json) can be used to check if

[GitHub] [zeppelin] liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469089451 @zjffdu , CI pass. https://travis-ci.org/liuxunorg/zeppelin/builds/501127271 Please help me review the code. Thanks!

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server

zjffdu commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#discussion_r261902388 ## File path: zeppelin-interpreter/src/main/thrift/RemoteInterpreterEventService.thrift ##

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server

zjffdu commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#discussion_r261902578 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpr

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server

liuxunorg commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#discussion_r261903421 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInte

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server

zjffdu commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#discussion_r261906400 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpr

[GitHub] [zeppelin] felixcheung merged pull request #3317: [ZEPPELIN-4026] document anonymous access

felixcheung merged pull request #3317: [ZEPPELIN-4026] document anonymous access URL: https://github.com/apache/zeppelin/pull/3317 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server

liuxunorg commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#discussion_r261924220 ## File path: zeppelin-interpreter/src/main/thrift/RemoteInterpreterEventService.thrift #

[GitHub] [zeppelin] liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server

liuxunorg commented on issue #3314: [ZEPPELIN-4019] Interpreter process get note from server URL: https://github.com/apache/zeppelin/pull/3314#issuecomment-469121863 1. Users can only get own notes and notes shared by others. 2. When you don't have read access to the note, There will be