zjffdu commented on a change in pull request #3314: [ZEPPELIN-4019] Interpreter
process get note from server
URL: https://github.com/apache/zeppelin/pull/3314#discussion_r261906400
##########
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterEventClient.java
##########
@@ -86,6 +88,17 @@ public synchronized ResourceSet getAllResources() {
}
}
+ public synchronized List<ParagraphInfo> getParagraphList(AuthenticationInfo
authInfo, String noteId) {
+ try {
+ String authInfoJson = gson.toJson(authInfo);
+ List<ParagraphInfo> paragraphList =
intpEventServiceClient.getParagraphList(authInfoJson, noteId);
Review comment:
I think we should throw exception to tell user expclitly that he doesn't
have permission on this note. Otherwise it would be very difficult to know why
user get null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
