[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...

2017-11-28 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 @felixcheung I added the documentation page `docs/usage/other_features/cron_scheduler.md` to this PR. I also added the explanation about this documentation to the `Questions:` section of the top

[GitHub] zeppelin pull request #2690: [ZEPPELIN-3075]Fix unqiue algo for the web side...

2017-11-28 Thread liguohuicmss
GitHub user liguohuicmss opened a pull request: https://github.com/apache/zeppelin/pull/2690 [ZEPPELIN-3075]Fix unqiue algo for the web side in pivot.js file. ### What is this PR for? unique() algorithm is not correct in pivot.js file. If the input is `[2, 3, 3, 3, 4, 5]` and

[jira] [Created] (ZEPPELIN-3082) Zeppelin daemon does not start

2017-11-28 Thread Cristina Luengo Agullo (JIRA)
Cristina Luengo Agullo created ZEPPELIN-3082: Summary: Zeppelin daemon does not start Key: ZEPPELIN-3082 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3082 Project: Zeppelin

[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-28 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2688 @Leemoonsoo Yes, I think it will be more convenient. I made some changes. ---

[GitHub] zeppelin issue #2690: [ZEPPELIN-3075]Fix unqiue algo for the web side in piv...

2017-11-28 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2690 why another PR? #2685 ---

[GitHub] zeppelin issue #2690: [ZEPPELIN-3075]Fix unqiue algo for the web side in piv...

2017-11-28 Thread liguohuicmss
Github user liguohuicmss commented on the issue: https://github.com/apache/zeppelin/pull/2690 I don't know why the jenkins is failed for #2685. The error tip is: ``` Looks like travis-ci is not configured for your fork. Please setup by swich on 'zeppelin' repository at

[GitHub] zeppelin pull request #2690: [ZEPPELIN-3075]Fix unqiue algo for the web side...

2017-11-28 Thread liguohuicmss
GitHub user liguohuicmss reopened a pull request: https://github.com/apache/zeppelin/pull/2690 [ZEPPELIN-3075]Fix unqiue algo for the web side in pivot.js file. ### What is this PR for? unique() algorithm is not correct in pivot.js file. If the input is `[2, 3, 3, 3, 4, 5]` a

[GitHub] zeppelin pull request #2690: [ZEPPELIN-3075]Fix unqiue algo for the web side...

2017-11-28 Thread liguohuicmss
Github user liguohuicmss closed the pull request at: https://github.com/apache/zeppelin/pull/2690 ---

[GitHub] zeppelin issue #2686: [ZEPPELIN-3076]Chart field is also draggable and sorta...

2017-11-28 Thread liguohuicmss
Github user liguohuicmss commented on the issue: https://github.com/apache/zeppelin/pull/2686 Thanks you. I have done according to your suggestion. But the Jenkins still failed. I cannot find the commit message in `https://travis-ci.org/profile` and the JSON from `https://api.trav

[GitHub] zeppelin issue #2690: [ZEPPELIN-3075]Fix unqiue algo for the web side in piv...

2017-11-28 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2690 close this PR. read https://zeppelin.apache.org/contribution/contributions.html#continuous-integration you should setting travis-ci to work with your fork after that your changes wi

[GitHub] zeppelin pull request #2690: [ZEPPELIN-3075]Fix unqiue algo for the web side...

2017-11-28 Thread liguohuicmss
Github user liguohuicmss closed the pull request at: https://github.com/apache/zeppelin/pull/2690 ---

[GitHub] zeppelin pull request #2691: [FIX] fix autocomplete

2017-11-28 Thread tinkoff-dwh
GitHub user tinkoff-dwh opened a pull request: https://github.com/apache/zeppelin/pull/2691 [FIX] fix autocomplete ### What is this PR for? After refactoring of Interpreter autocomplete (from server side) not works without first Run of interpreter. This PR fix it. #

[GitHub] zeppelin issue #2691: [FIX] fix autocomplete

2017-11-28 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2691 @zjffdu pls help with review ---

[GitHub] zeppelin issue #2686: [ZEPPELIN-3076]Chart field is also draggable and sorta...

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2686 Looks like you have setup CI correctly. Job profile #4 fails https://travis-ci.org/liguohuicmss/zeppelin/builds/308472149. It is probably due to flaky test. But could you try restart #4

[GitHub] zeppelin issue #2676: [ZEPPELIN-3048] Add the option which prevents paragrap...

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2676 Thanks @kjmrknsn for the contribution. In case of a note is cron scheduled and doesn't want anyone else edit the notebook other than the cron execution user, wouldn't 'owner' of note re

[GitHub] zeppelin issue #2688: [Zeppelin-2571] & [Zeppelin-465] Run paragraphs: from ...

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2688 Tested last commit and it works well. Looks good to me. It's minor, if paragraph keeps focus after 'run all above' and 'run all below', that would be more convenient to use. ---

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2668 Doesn't https://github.com/apache/zeppelin/blob/master/bin/zeppelin-daemon.sh#L222 need to aware of recovery? Otherwise, it terminates all the interpreters on `zeppelin-deamon.sh stop` ---

[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2616 LGTM. Thanks @gef756 for the contribution! Merge to master if no further discussions. ---

[GitHub] zeppelin issue #2658: [ZEPPELIN-3042] updating jgit to support post-commit h...

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2658 Thanks @kokes for the contribution. Checked CI result https://travis-ci.org/kokes/zeppelin/builds/299146848 Some profiles are failing but not related to this PR. LGTM and merge t

[jira] [Created] (ZEPPELIN-3083) Interpreter name not checked when creating new interpreter

2017-11-28 Thread Andreas Weise (JIRA)
Andreas Weise created ZEPPELIN-3083: --- Summary: Interpreter name not checked when creating new interpreter Key: ZEPPELIN-3083 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3083 Project: Zeppelin

[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

2017-11-28 Thread weand
Github user weand commented on the issue: https://github.com/apache/zeppelin/pull/2675 Closed and created https://issues.apache.org/jira/browse/ZEPPELIN-3083 instead. ---

[GitHub] zeppelin pull request #2675: [ZEPPELIN-3060] Unable to use interpreter names...

2017-11-28 Thread weand
Github user weand closed the pull request at: https://github.com/apache/zeppelin/pull/2675 ---

[jira] [Created] (ZEPPELIN-3084) python.conda Environment Creation must have python x.x flag set

2017-11-28 Thread Brian Slater (JIRA)
Brian Slater created ZEPPELIN-3084: -- Summary: python.conda Environment Creation must have python x.x flag set Key: ZEPPELIN-3084 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3084 Project: Zepp

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

2017-11-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2668 @Leemoonsoo Recovery feature is controlled `zeppelin.recovery.enabled` by in zeppelin-site.xml, if it is enabled, interpreter process won't be killed. see https://github.com/apache/zeppelin/pu

[GitHub] zeppelin issue #2686: [ZEPPELIN-3076]Chart field is also draggable and sorta...

2017-11-28 Thread liguohuicmss
Github user liguohuicmss commented on the issue: https://github.com/apache/zeppelin/pull/2686 Not easy. All is succeed. Thank you very much. @Leemoonsoo https://travis-ci.org/liguohuicmss/zeppelin/builds/308472149 By the way. I don't know why the Traivs-ci always has

[GitHub] zeppelin issue #2686: [ZEPPELIN-3076]Chart field is also draggable and sorta...

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2686 Thanks! LGTM and merge to master if no further discussions. Ah, you're right. close/reopen will not trigger travis. Zeppelin github repo configured to trigger Jenkins, not travis direct

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2668 Correct me if i'm wrong. https://github.com/apache/zeppelin/pull/2668/files#diff-3477d79f3012453f20c3727ec60338e9R230 skips interpreter close when `zeppelin.recovery.enabled` is true. However,

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

2017-11-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2668 oops, didn't notice `zeppelin-daemon.sh` will also kill interpreter process, but according my expereince, it seems `zeppelin-daemon.sh` won't kill interpreter process, let me double check that.

[GitHub] zeppelin issue #2676: [ZEPPELIN-3048] Add the option which prevents paragrap...

2017-11-28 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2676 @Leemoonsoo > In case of a note is cron scheduled and doesn't want anyone else edit the notebook other than the cron execution user, wouldn't 'owner' of note remove users from 'writers'

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

2017-11-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2668 @Leemoonsoo Just find out that zeppelin didn't capture the correct pid of interpreter process, it capture the parent process of interpreter process (interpreter.sh) instead of the jvm process. I fi

[GitHub] zeppelin issue #2396: [ZEPPELIN-2451]: Add JDBC config option for calling co...

2017-11-28 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2396 @randerzander Can you fix the failure of CI? ---

[GitHub] zeppelin issue #2676: [ZEPPELIN-3048] Add the option which prevents paragrap...

2017-11-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2676 I agree we should make it easier. My concerns are whether we are possibly making it more confusing if we have 2 separate systems? First with the roles, second this. ---

[GitHub] zeppelin issue #2685: [ZEPPELIN-3075]Fix unqiue algo for the web side in piv...

2017-11-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2685 could you check the failed tests? ---

[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

2017-11-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2668 There's no way to shutdown everything when `zeppelin.recovery.enabled` is true. Are you concerning orphan process ? ---