GitHub user liguohuicmss opened a pull request:

    https://github.com/apache/zeppelin/pull/2690

    [ZEPPELIN-3075]Fix unqiue algo for the web side in pivot.js file.

    ### What is this PR for?
    unique() algorithm is not correct in pivot.js file.
    If the input is `[2, 3, 3, 3, 4, 5]` and the output will be `[2, 3, 3, 4, 
5]`. The number `3` is still duplicated.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3075   [ZEPPELIN-3075]
    
    ### How should this be tested?
    Added unit test. Added screenshots for test.
    
    ### Screenshots (if appropriate)
    
    ![untitled 
project](https://user-images.githubusercontent.com/5969176/33314627-2f7c48c6-d469-11e7-90bf-c04e5f507855.gif)
    
![201711240311281511507488261_small](https://user-images.githubusercontent.com/5969176/33314658-49c0b794-d469-11e7-919e-8b0314d3ad07.gif)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liguohuicmss/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2690.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2690
    
----
commit 943e80a96f492267b51392bd7df6dc9a32a0fe1a
Author: liguohui <liguo...@cmss.chinamobile.com>
Date:   2017-11-23T13:28:50Z

    Fix unqiue algo for the web side in pivot.js file.

commit f996747245ea3e055df903108190760a1d4ce5da
Author: liguohui <liguo...@cmss.chinamobile.com>
Date:   2017-11-25T05:38:45Z

    Chart field is also draggable and sortable in the 'keys', 'groups' and 
'values'

commit fdde39f523dcf85dd2de64ceb10cf1c621d86693
Author: liguohui <liguo...@cmss.chinamobile.com>
Date:   2017-11-27T05:10:41Z

    add unit test for unique algo in pivot.js

commit 99cf93da9430c68547f91b14eba5d11e397fc590
Author: liguohui <liguo...@cmss.chinamobile.com>
Date:   2017-11-27T05:24:02Z

    Revert "Chart field is also draggable and sortable in the 'keys', 'groups' 
and 'values'"
    
    This reverts commit f996747245ea3e055df903108190760a1d4ce5da.

commit 7f387c43515acd949d6aca9041d638d856973a48
Author: liguohuicmss <liguo...@cmss.chinamobile.com>
Date:   2017-11-28T10:12:54Z

    Merge pull request #1 from liguohuicmss/pivot-unqiue-algo
    
    [ZEPPELIN-3075]Fix unqiue algo for the web side in pivot.js file.

----


---

Reply via email to