Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@cloverhearts I have few questions.
What happens when we want to implement `PythonPyenvInterpreter` which is
similar to `PythonCondaInterpreter`?
- In that case, we have to add ne
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@cloverhearts Just to clarify my concern. Here's what I see when I use
conda outside of zeppelin.
Step 1. Create enviroment `env_1` using conda, and install pandas
Step 2. Set `zeppelin
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@zjffdu
This change will work exactly as your request.
There is only one python library path to be added.
1. If the user does not install python via conda.
(If the user install
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@1ambda
Currently there is a possibility that it will be structurally.
However, if you store it in PythonCondaInterpreter, the problem is greatly
aggravated.
1. PythonInterpr
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2574
I have a solution to remove conda related members from PythonInterpreter.
also PythonCondaInterpreter will not have any members.
However, it differs in focus from this PR.
(The pro
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2574
In my opinion, allowing for fluctuations in the python environment is
itself a problem.
But zeppelin are supporting it.
If it does not, then the semantics of conda activate and conda d
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@zjffdu @1ambda @felixcheung
Thank you for your kind reply despite my lack of English.
I hope this PR is merged.
So, i will try to reflect your opinions as much as possible.
Th
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@cloverhearts There is no problem about python lib paths.
`%python.conda install` command is the problem.
So you don't need to write code for python path.
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2574
I have separated this PR.
I'm sorry for the confusion.
https://github.com/apache/zeppelin/pull/2578
---
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/2574
---
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/2575
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
The problem of CI is irrelevant to this pr.
```
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.462 sec
<<< FAILURE! - in
org.apache.zeppelin.interpreter.remot
GitHub user malayhm opened a pull request:
https://github.com/apache/zeppelin/pull/2579
Zeppelin-2922 Allow removing last paragrap
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Thanks @cloverhearts , Is it possible to add unit test for
`PythonCondaInterpreter` ? Regarding the CI failure, I know this failure and
will fix it in another PR
---
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2572
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Merge if no more discussion.
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu Sure, Thank you :)
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Tested locally and works well. @cloverhearts Can we fix `conda list`
command as well? it will need exactly the same code with `conda install`.
LGTM except for it.
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda okay :)
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
fixed test case and conda list feature
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2579
@malayhm Hi, Thanks for the contribution.
I just read the JIRA issue and have a question. Could you elaborate the
situation when
> sometimes user want to delete the last empty par
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Checked that `conda list` works beautifully. But I am getting this ipython
related message when activate a new env. Can we remove this message which is
not related to conda at all.
![imag
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda This is due to IPythonInterpreter, could create a ticket ? I will
fix it in another PR.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu I created one. Thanks.
- https://issues.apache.org/jira/browse/ZEPPELIN-2923
---
Hoon Park created ZEPPELIN-2923:
---
Summary: ipython related message is displayed when enabling a
conda env
Key: ZEPPELIN-2923
URL: https://issues.apache.org/jira/browse/ZEPPELIN-2923
Project: Zeppelin
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
LGTM.
---
Hoon Park created ZEPPELIN-2924:
---
Summary: javascript source map is broken
Key: ZEPPELIN-2924
URL: https://issues.apache.org/jira/browse/ZEPPELIN-2924
Project: Zeppelin
Issue Type: Bug
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2580
[ZEPPELIN-2924] Fix broken javascript source map
### What is this PR for?
Fixed broken javascript source map. The coverage loader should be used only
for test env.
**that's reall
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2558
@ruseel Thanks for the update. Could you resolve zjffdu's last comment?
---
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2580
[ZEPPELIN-2924] Fix broken javascript source map
### What is this PR for?
Fixed broken javascript source map. The coverage loader should be used only
for test env.
**that's rea
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2580
---
36 matches
Mail list logo
