[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

[1ambda]

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2580

    [ZEPPELIN-2924] Fix broken javascript source map

    ### What is this PR for?
    
    Fixed broken javascript source map. The coverage loader should be used only 
for test env.
    
    **that's really annoying because we can't set breakpoint and even can't see 
the original source code.**
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-2924](https://issues.apache.org/jira/browse/ZEPPELIN-2924)
    
    ### How should this be tested?
    
    1. run the webapp as dev mode: `localhost:9000`
    2. open the developer console and click any log message
    3. check whether source is minified or not.
    4. execute `yarn run test` in the terminal to check that coverage feature 
works well.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![image](https://user-images.githubusercontent.com/4968473/30260684-cc095240-9703-11e7-9fd6-fe5bd370a6bd.png)
    
    
![image](https://user-images.githubusercontent.com/4968473/30260690-d4f3494c-9703-11e7-854b-29d6020eaa3c.png)
    
    
    
    #### After
    
    
![image](https://user-images.githubusercontent.com/4968473/30260654-a27579d6-9703-11e7-9d2a-a37c7ae7b148.png)
    
    
![image](https://user-images.githubusercontent.com/4968473/30260655-a9c62802-9703-11e7-9d29-be10df0302d7.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2924/fix-source-map-is-broken

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2580
    
----
commit 375e13945b12a43aec47a4809b6b16be314ba001
Author: 1ambda <1am...@gmail.com>
Date:   2017-09-11T06:09:10Z

    fix: Use coverage loader only for test env

----


---