Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Tested and LGTM. Thanks @khalidhuseynov for the improvement.
Merge to master if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
merged master and finally CI is green. @Leemoonsoo ready for final check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Tested again and now I can see the text in the looknfeel dropdown menu of
non-editable mode note. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@AhyoungRyu thanks for review, it wasn't intended behaviour actually, fixed
in bbaf286d60a07d4f5f7dd7a55e0f836ab116507d
---
If your project is set up for it, you can reply to this email an
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov Thanks for your consideration! Tested again and it works
well as we said :)
And there is one minor thing in lookandfeel setting menu. Is this intended
behavior?
- Head
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@AhyoungRyu I think it makes sense and addressed your feedback. please
check it out and let me know if it's fine.
---
If your project is set up for it, you can reply to this email and hav
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov
>since they're still not able to run or edit
Yes you're right. I just thought it's not common sense as you told. Since
the user can't run or edit anyway, but he can
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@AhyoungRyu actually i thought about it and couldn't find a reason why not
let user change "Interpreter bindings" and "Note permissions" even in read-only
mode, since they're still not able
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov How about disable "Interpreter binding" & "Note permission"
buttons as well? Currently I can change the bound interpreters and note
permission for the readonly-mode note.
---
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@Leemoonsoo @cloverhearts @1ambda thanks for the review! I addressed all
your comments and updated the screenshot above. Please check it out and let me
know what you think.
Also [
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov Thanks for reply!
> yeah that's good point, do you have something in mind regarding it? i was
thinking whether it should be more of a mode switch (say different mode added
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@Leemoonsoo thanks for testing, right i could reproduce it. So in that case
probably it shouldn't be allowed to change graph properties or pivot settings
while viewing revisions, right? bec
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Tested this branch and found
1. select HEAD
2. and then switch to any revision.
3. change height of graph or change pivot setting
4. HEAD is changed by 3)
@khalidh
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@1ambda thanks for review. answers in order:
> It would be great if there is a signal (whatever) so let user know that
this is committed version of note. It's confusing at first for me.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Works well as described. Here are few things to consider.
- It would be great if there is a signal (whatever) so let user know that
this is committed version of note. It's confusing at firs
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
FYI - you can install 2.11.0 using brew.
@khalidhuseynov is right, that should be handled in the separate issue.
Let's talk about it on ZEPPELIN-1737.
---
If your project is set up for i
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@1ambda actually i've tried to reproduce
[ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) and even
with git 2.11.0 wasn't able to do it. also from documentation
[here](
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
For other reviewers
- If you are using git 2.10+, Notebook revision feature will not work.
Checkout [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737)
---
If your proje
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1775
good feature!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Glad to help reviewing this PR :)
Let me check and then give you feedbacks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@bzz it's ready now, also /cc @cloverhearts @1ambda to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov Is it WIP?
Then please feel free to add WIP in PR title and ping back, when it's ready
for reviews.
---
If your project is set up for it, you can reply to this email and hav
22 matches
Mail list logo
