Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1775
  
    @1ambda thanks for review. answers in order: 
    > It would be great if there is a signal (whatever) so let user know that 
this is committed version of note. It's confusing at first for me. (Assume that 
someone get the link for a committed note. He might wonder why he can not 
modify this note)
    
    yeah that's good point, do you have something in mind regarding it? i was 
thinking whether it should be more of a mode switch (say different mode added 
in addition to report mode, etc)  or just represent visually (say gray out 
editor background like when running note), or something else.
    
    > Enabling and modifying committed notes affects on the HEAD note. What 
about disabling double click to committed paragraphs (you can check this in 
screenshot below)
    
    thanks for testing, addressed under 
50e1472957446f7f907e2ea8b8eb19f4347eac8b. please check it out.
    
    > the last one is not directly related with this issue. But It would be 
good to hide git notebook icons if we are other notebook repo rather than 
GitNotebookRepo. 
    
    actually we have issue regarding this one to have `GitNotebookRepo` as 
default repo, in that case we don't need to hide it i believe. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to