[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2017-01-09 Thread ChrisAdvance
Github user ChrisAdvance commented on the issue: https://github.com/apache/zeppelin/pull/1030 Does the "Connection refused" problem fixed yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-12-25 Thread neil4dong
Github user neil4dong commented on the issue: https://github.com/apache/zeppelin/pull/1030 @AhyoungRyu It looks like I am comment on a wrong place. But I am still have some problem about "spark interpreter group", When multiple notebook use timed-scheduling sharing one spa

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-12-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1030 @neil4dong This PR is not for bug fix but for adding new credential Apis. Could you elaborate more about your problem? You can also create new [Jira](https://issues.apache.org/jira/issues/?jql=

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-12-21 Thread neil4dong
Github user neil4dong commented on the issue: https://github.com/apache/zeppelin/pull/1030 I checkout the branch "branch-0.6" , but it seems that this bug fix has not merged to this branch. This problem makes cron jobschedule unusable. Really appreciate for this bug fix. Sh

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-07-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1030 PR template does have the JIRA link ask? I thought not every contributor in JIRA can change "assign" or "fix version" and it's up to the admin resolving the JIRA to set them? --- If your pro

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-30 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1030 @bzz I'll do that and It's great idea @corneadoug ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-30 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1030 @bzz How about editing our current PR template to state that JIRA issue is mandatory and that you should set both assigned and Fix Version? We may still have to repeat it, but at least it would

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-30 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 @astroshim Merged, next time please check JIRA issue - it should be assigned to somebody (you, in this case) and has a "Fix Version" set. This simplified life of the release manager a lot! -

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-30 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 Merging if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-28 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1030 The CI fail has gone.. I just did trigger CI again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-28 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 Looks great to me! Let's create a JIRA issue for current failure with label `flaky-tests` and merge this! --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-27 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1030 @bzz I fixed code and the build problem that you mentioned is gone. but another following build fail occurred. I think following problem seems not related this PR, what do you think?

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-27 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1030 @bzz okay I will. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-27 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 There are multiple CI failures - JSON parsing failure somewhere in websocket communication ``` Running org.apache.zeppelin.notebook.repo.zeppelinhub.websocket.protocol.Zeppelin

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-24 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1030 @bzz @AhyoungRyu Could you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-20 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1030 Thank you for your review @bzz and @AhyoungRyu and @cloverhearts ! And It really makes sense @bzz comments. Let me fix them. --- If your project is set up for it, you can reply to this e

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1030 For the docs, yeah I agree with @bzz. Maybe need to create a new page for this `http://zeppelin.apache.org/docs/0.6.0-SNAPSHOT/rest-api/rest-credential` :) --- If your project is set up for i

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-20 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 👍 for having tests! Two things: 1. Code Instead of locking on the map (`synchronized(credentialsMap){...}`), would it make sense to rather replace `credentialsMap` with c

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

2016-06-16 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1030 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if