Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1030
ð for having tests!
Two things:
#### 1. Code
Instead of locking on the map (`synchronized(credentialsMap){...}`), would
it make sense to rather replace `credentialsMap` with concurrent map
implementation?
The client code gets simpler and implementation usually is more efficient
than explicit locking.
#### 2. Docs
In PR description you also have
>Does this needs documentation? no
But do not you think it also shall be documented somewhere under
http://zeppelin.apache.org/docs/0.6.0-SNAPSHOT/rest-api/ ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
