Github user shijinkui commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/924
@bzz @janzhongi, Let's kick off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/924#issuecomment-222577126
Thank you for improving Scala style!
Generally, such big changes that touch multiple subsystems (spark,
cassandra, angular, etc) are VERY hard to review
Github user shijinkui commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/924#issuecomment-222407649
hi, @bzz, please check this whether is necessary of code style check.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shijinkui commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/924#issuecomment-222405364
even on master branch, `mvn checkstype:check` fail
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:che
GitHub user shijinkui opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/924
[ZEPPELIN-874] enable scala check style and refactor scala class
[ZEPPELIN-874] enable scala check style and refactor scala class
* remove return
* delete ";"
* en
