Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/924#issuecomment-222577126
Thank you for improving Scala style!
Generally, such big changes that touch multiple subsystems (spark,
cassandra, angular, etc) are VERY hard to review and will take forever to get
merged, as we now need to have a consensus between maintainers of each of those
parts.
I would suggest this PR to be separated on at least 3:
- improving checkstyle conventions for Scala (\w updated to documentation
and CONTRIBUTING to showcase it, addressing @jongyoul comments)
- refactoring `cassandra` to follow conventions
- refactoring `spark` to follow conventions
- refactoring `module N` to follow conventions
Then each of them can be improved and reviewed fast and independently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
