[GitHub] zeppelin issue #1550: [ZEPPELIN-912] Apply new mechanism to GeodeOqlInterpre...

2016-10-25 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1550 @jongyoul Thanks for the review! On Sat, Oct 22, 2016, 09:05 Jongyoul Lee wrote: > Thanks for the contribution. LGTM. > > — > You are receiving this

[GitHub] zeppelin issue #1556: [MINOR] remove comments in NotebookRestApi.java

2016-10-25 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1556 @minahlee @jongyoul Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #1556: [MINOR] remove comments in NotebookRestApi.java

2016-10-23 Thread vectorijk
GitHub user vectorijk opened a pull request: https://github.com/apache/zeppelin/pull/1556 [MINOR] remove comments in NotebookRestApi.java ### What is this PR for? Since ZEPPELIN-1162 (PR #1341) has been solved, we should remove TODO comments correspondingly. ### What

[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...

2016-10-22 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 @Leemoonsoo @bzz Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1550: [ZEPPELIN-912] Apply new mechanism to GeodeOqlInterpre...

2016-10-22 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1550 @jongyoul Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1550: [ZEPPELIN-912] Apply new mechanism to GeodeOqlI...

2016-10-22 Thread vectorijk
GitHub user vectorijk opened a pull request: https://github.com/apache/zeppelin/pull/1550 [ZEPPELIN-912] Apply new mechanism to GeodeOqlInterpreter ### What is this PR for? This PR applies the new interpreter registration mechanism to Geode Oql interpreter. ### What

[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...

2016-10-17 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 cc @Leemoonsoo @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...

2016-10-17 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 @bzz I have updated and added unit test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...

2016-10-16 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 @bzz Thanks for the quick response! I will write and update some tests for this to make sure the changes doesn't break things before. --- If your project is set up for it, you can rep

[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...

2016-10-16 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 cc @zjffdu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin pull request #1530: [Zeppelin-1555] Eliminate prefix in PythonInter...

2016-10-16 Thread vectorijk
GitHub user vectorijk opened a pull request: https://github.com/apache/zeppelin/pull/1530 [Zeppelin-1555] Eliminate prefix in PythonInterpreter exception ### What is this PR for? Solve bug metioned [here](https://github.com/apache/zeppelin/blob

[GitHub] zeppelin issue #1496: [Zeppelin-907] Apply new mechanism to AngularInterpret...

2016-10-09 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1496 @jongyoul Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1496: [Zeppelin-907] Apply new mechanism to AngularInterpret...

2016-10-08 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1496 @anthonycorbacho Thanks for your quick response. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1496: [Zeppelin-907] Apply new mechanism to AngularIn...

2016-10-08 Thread vectorijk
GitHub user vectorijk opened a pull request: https://github.com/apache/zeppelin/pull/1496 [Zeppelin-907] Apply new mechanism to AngularInterpreter ### What is this PR for? This PR applies the new interpreter registration mechanism to Angular interpreter. ### What type