[GitHub] zeppelin issue #497: ZEPPELIN-143: Git as a versioned notebook storage

2017-11-23 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/497 Haven't had the time to look into that further. TBH, I don't think storing notebooks as text files is a good strategy - not in the environment we use Zeppelin, anyway. We're likely

[GitHub] zeppelin issue #2599: [ZEPPELIN-2952] encrypt credentials.json with AES

2017-10-04 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2599 done :) ---

[GitHub] zeppelin pull request #2599: [ZEPPELIN-2952] encrypt credentials.json with A...

2017-09-25 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2599 [ZEPPELIN-2952] encrypt credentials.json with AES ### What is this PR for? Support encrypting passwords using a private key ### What type of PR is it? Improvement

[jira] [Created] (ZEPPELIN-2952) Support encrypting passwords on credentials.json

2017-09-25 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2952: --- Summary: Support encrypting passwords on credentials.json Key: ZEPPELIN-2952 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2952 Project: Zeppelin

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-09-07 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 Hi folks, Please let me know if I should close this. Tks! ---

[GitHub] zeppelin issue #2498: [ZEPPELIN-2796] Fetching LDAP roles

2017-09-07 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2498 Hi folks, Please let me know if I should close this. Tks! ---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-09-07 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Hi folks, Please let me know if I should close this. Tks! ---

[GitHub] zeppelin pull request #2480: [ZEPPELIN-1249] build all submodules w/ the sam...

2017-09-07 Thread herval
Github user herval closed the pull request at: https://github.com/apache/zeppelin/pull/2480 ---

[GitHub] zeppelin issue #2480: [ZEPPELIN-1249] build all submodules w/ the same scala...

2017-08-23 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2480 @zjffdu what's the benefit of *not* doing it, given it's a simple change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

2017-08-14 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2503 any arguments against following the current way most sites do it (which is having "remember me" on by default, instead of a checkbox option)? Showing/hiding the checkbox depe

[GitHub] zeppelin issue #2145: [ZEPPELIN-2271] encoding password of credentials

2017-08-07 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2145 https://github.com/herval/zeppelin/tree/encrypt-credentials --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

2017-08-04 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2503 Hmm It shouldn’t work without the Cookie manager. The checkbox will still show, though, which begs the question if it should be a default? (Otherwise we’ll have to hide the checkbox based on

[GitHub] zeppelin issue #2145: [ZEPPELIN-2271] encoding password of credentials

2017-08-04 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2145 I've implemented something slightly similar here, except I'm actually encrypting the entire file using AES, using a passphrase you provide (which can live in memory) it's

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

2017-08-04 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2484 @jongyoul good q. I tried another stats libraries I've seen used around (airlift), but had a hard time reconciling dependencies, so went with the smallest footprint one + implementing the se

[GitHub] zeppelin issue #497: ZEPPELIN-143: Git as a versioned notebook storage

2017-07-26 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/497 @p0wl I started remote git support here: https://github.com/herval/zeppelin/tree/remote-git-support - it's a WIP, if someone wants to take over (it would work w/ github or any other git

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

2017-07-25 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2503 That popup is not the site’s “remember me” - github actually keeps you logged in by default (close the browser and reopen, and you’re still logged, no need to re-authenticate) You

[GitHub] zeppelin pull request #2503: [ZEPPELIN-2808] remember me support

2017-07-25 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2503 [ZEPPELIN-2808] remember me support ### What is this PR for? Add support for "remember me" cookies, so we can activate LDAP without forcing users to re-login every time

[jira] [Created] (ZEPPELIN-2808) "Remember Me" for Login

2017-07-24 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2808: --- Summary: "Remember Me" for Login Key: ZEPPELIN-2808 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2808 Project: Zeppelin Issue Type: I

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-24 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 @soralee @khalidhuseynov would you or anyone else like to give this a new try? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

2017-07-24 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2484 Hi folks - any thoughts on this approach? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2498: [ZEPPELIN-2796] Fetching LDAP roles

2017-07-24 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2498 Hi folks, Any thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2498: [ZEPPELIN-2796] Fetching LDAP roles

2017-07-20 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2498 [ZEPPELIN-2796] Fetching LDAP roles ### What is this PR for? This actually fetches the user's LDAP roles, when using the LdapRealm, so they're accessible on Zeppeli

[jira] [Created] (ZEPPELIN-2796) LDAP fetching of roles not working?

2017-07-18 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2796: --- Summary: LDAP fetching of roles not working? Key: ZEPPELIN-2796 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2796 Project: Zeppelin Issue Type

[jira] [Created] (ZEPPELIN-2792) Hide UI elements the user doesn't have credentials for

2017-07-17 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2792: --- Summary: Hide UI elements the user doesn't have credentials for Key: ZEPPELIN-2792 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2792 Project: Zep

[jira] [Created] (ZEPPELIN-2791) Support "super users"

2017-07-17 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2791: --- Summary: Support "super users" Key: ZEPPELIN-2791 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2791 Project: Zeppelin Issue Type: N

[jira] [Created] (ZEPPELIN-2790) Storing Notebooks and Configs on database

2017-07-17 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2790: --- Summary: Storing Notebooks and Configs on database Key: ZEPPELIN-2790 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2790 Project: Zeppelin Issue

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-17 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 This is now passing all tests - please advise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-14 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 hmm I'm finding it difficult to get all the integration tests to pass. Inclined to test only for the presence of the button. --- If your project is set up for it, you can reply to this emai

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-07-13 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 ping - please advise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-13 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 hmm I'll see if I can somehow split "report mode" and "view only mode". I didnt experience the Helium issue, personally --- If your project is set up for it, yo

[GitHub] zeppelin issue #2480: [ZEPPELIN-1249] build all submodules w/ the same scala...

2017-07-12 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2480 sounds good, I’ll do that then _ From: Felix Cheung mailto:notificati...@github.com>> Sent: Wednesday, July 12, 2017 9:34 AM Subject: Re: [

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 all tests passing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2484 This is the basic set of functionality needed to start monitoring some common metrics - Comments & observations welcome! --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #2480: [ZEPPELIN-1249] build all submodules w/ the same scala...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2480 Regarding verification, how do you suggest I go about that? We've been using this setup internally for some time, but we only use a few of the interpreters (spark, scalding, jdbc, md) - not

[GitHub] zeppelin pull request #2484: [ZEPPELIN-2711] [WIP] basic metrics for paragra...

2017-07-11 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2484 [ZEPPELIN-2711] [WIP] basic metrics for paragraphs & notebook view/create/run ### What is this PR for? This exposes JMX metrics for a few operations on Zeppelin. The first step her

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2481 oh, Indeed. There's some inheritance there 😶 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2481 I actually don't see any test on `JdbcInterpreterTest` covering that code path at all - I think the test suite is passing simply because that bit is not tested, and feel it should be --- If

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-10 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2481 would it be worth adding a test around this? I imagine the tests would fail with a "class not found", so it would be easy to add one that proves that you don't get the error if aut

[GitHub] zeppelin pull request #2480: [ZEPPELIN-1249] build all submodules w/ the sam...

2017-07-10 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2480 [ZEPPELIN-1249] build all submodules w/ the same scala version ### What is this PR for? This uses the same Scala version throughout modules, allowing us to use only Scala 2.11

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-10 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Ok, retested now and it's working as expected. If you need to login (using anonymous mode support), you may need this PR first: https://github.com/apache/zeppelin/pull/2440 --- If

[jira] [Created] (ZEPPELIN-2760) Can't run JDBC interpreters due to class not found

2017-07-10 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2760: --- Summary: Can't run JDBC interpreters due to class not found Key: ZEPPELIN-2760 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2760 Project: Zep

[GitHub] zeppelin pull request #:

2017-07-10 Thread herval
Github user herval commented on the pull request: https://github.com/apache/zeppelin/commit/e1f0a3205eb5aede0b2d80c9d3de59b3f47b699c#commitcomment-23016085 Related ticket: https://issues.apache.org/jira/browse/ZEPPELIN-1326 --- If your project is set up for it, you can reply to this

[GitHub] zeppelin pull request #:

2017-07-10 Thread herval
Github user herval commented on the pull request: https://github.com/apache/zeppelin/commit/e1f0a3205eb5aede0b2d80c9d3de59b3f47b699c#commitcomment-23016062 This caused a regression: https://github.com/apache/zeppelin/blame/master/jdbc/src/main/java/org/apache/zeppelin/jdbc

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-07-10 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 Rebased to latest master - please advise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Hmm I’ll try again. Btw, did you `mvn clean` after switching branches? I think changes on the js/html files don’t get picked up unless you do that

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-03 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 @soralee thanks for taking the time :-) there's one more step to your list: 1. login as user1 2. create a note 3. add a paragraph **4. change the visualization to a

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-03 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 any thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-03 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 any additional thoughts on this? Is it mergeable? @jongyoul @cfries --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-07-03 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 any additional thoughts on this? Is it mergeable? @khalidhuseynov @tinkoff-dwh @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-29 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 I am using the original setting (getMaxResults). I had to set it in two calls because setFetchSize will determine that there is a “next” page, but if I only do “setMaxResults”, it will not

[jira] [Created] (ZEPPELIN-2711) Metrics for service monitoring

2017-06-29 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2711: --- Summary: Metrics for service monitoring Key: ZEPPELIN-2711 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2711 Project: Zeppelin Issue Type: New

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-29 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 @tinkoff-dwh it's not duplicate. The bug here is that if you don't do `statement.setMaxRows`, some drivers (eg postgres) will try to load everything when you issue a `select

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-29 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 ![screenshot 2017-06-29 12 37 41](https://user-images.githubusercontent.com/5610/27706856-07f38206-5cc8-11e7-9e57-03f5d6d4cffd.png) --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-29 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 hmm.. It actually seems that setFetchSize does not limit the query execution (so it takes forever & hangs Zeppelin) Figuring out if there's a way to show results are trunca

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-06-28 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Build is green: https://travis-ci.org/herval/zeppelin/builds/247345573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-28 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 Build's passing: https://travis-ci.org/herval/zeppelin/builds/247193502 Let me know if this is mergeable :-) @tinkoff-dwh --- If your project is set up for it, you can reply to

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-06-27 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 @zjffdu added one, let me know if that covers it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #2440: [ZEPPELIN-2587] allow logging in if youre anony...

2017-06-26 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2440 [ZEPPELIN-2587] allow logging in if youre anonymous ### What is this PR for? The login button is not showing (since 0.7.1) if you allow anonymous access. This shows it again

[GitHub] zeppelin pull request #2439: [ZEPPELIN-2680] allow opening notebook as a rea...

2017-06-26 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2439 [ZEPPELIN-2680] allow opening notebook as a reader ### What is this PR for? We have a few notebooks that have a list of writers & owners, but no restricted readers list. When you

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-23 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 @tinkoff-dwh build #3 is failing in both my master & zeppelin master: https://travis-ci.org/apache/zeppelin - restarting didn't make it pass: https://travis-ci.org/apache/zeppelin/jobs/

[jira] [Created] (ZEPPELIN-2681) Fix Scala 2.11 compatibility

2017-06-23 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2681: --- Summary: Fix Scala 2.11 compatibility Key: ZEPPELIN-2681 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2681 Project: Zeppelin Issue Type

[jira] [Created] (ZEPPELIN-2680) Can't open notebook as a reader

2017-06-23 Thread Herval Freire (JIRA)
Herval Freire created ZEPPELIN-2680: --- Summary: Can't open notebook as a reader Key: ZEPPELIN-2680 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2680 Project: Zeppelin Issue Type

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-22 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 It seems apache/zeppelin master (which is what this branch is based on) is failing the build - should I rebase it to 0.7 instead, or wait for master to be fixed? Please let me know what should I

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-22 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 Why +1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-22 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 I'm also not exactly sure how to write a test for this, as the JDBCInterpreterTest doesn't use anything in the line of mocks (and the outside behavior - limiting the number of returned

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-22 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 @tinkoff-dwh you're right, picked the wrong method - using setFetchSize now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin pull request #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-06-21 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2428 [ZEPPELIN-1470] limiting results from jdbc ### What is this PR for? One thing we tracked down is that if you issue a large query on a very large table, it will simply try to load all