GitHub user herval opened a pull request:
https://github.com/apache/zeppelin/pull/2439
[ZEPPELIN-2680] allow opening notebook as a reader
### What is this PR for?
We have a few notebooks that have a list of writers & owners, but no
restricted readers list.
When you try to open these notebooks as a reader AND they have a chart the
app sends a COMMIT_PARAGRAPH for each, which causes a write permission popup to
show ("Insufficient privileges to write note").
I tracked down the issue to the result.controller.js
(commitParagraphResult) - propagating the "viewOnly" state fixes that behavior.
### What type of PR is it?
Bug Fix
### How should this be tested?
- Create a notebook. Add a paragraph with a graph. Set the "owner" of the
notebook to something other than yourself. You won't be able to load the
notebook without the security popup anymore (unless logging in as the owner)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/herval/zeppelin dont-write-as-a-reader
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2439.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2439
----
commit 3b369fce0d0703fed61a2b7babe0ca3b85ffbc08
Author: Herval Freire <hfre...@twitter.com>
Date: 2017-06-26T17:00:21Z
[ZEPPELIN-2680] allow opening notebook as a reader
### What is this PR for?
We have a few notebooks that have a list of writers & owners, but no
restricted readers list.
When you try to open these notebooks as a reader AND they have a chart the
app sends a COMMIT_PARAGRAPH for each, which causes a write permission popup to
show ("Insufficient privileges to write note").
I tracked down the issue to the result.controller.js
(commitParagraphResult) - propagating the "viewOnly" state fixes that behavior.
### What type of PR is it?
Bug Fix
### How should this be tested?
- Create a notebook. Add a paragraph with a graph. Set the "owner" of the
notebook to something other than yourself. You won't be able to load the
notebook without the security popup anymore (unless logging in as the owner)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
