Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/3250
All CI builds seem to have passed as per
https://travis-ci.org/VipinRathor/zeppelin/builds/464561551
I don't know why this PR is showing 1 failed check. Can someone please help
me out?
---
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/3250
@prabhjyotsingh , @zjffdu , @felixcheung ,
Can you please help with the review? Thanks in advance.
---
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/3250
[Zeppelin 3792] Zeppelin SPNEGO support
### What is this PR for?
HTTP SPNEGO (Simple and Protected GSS-API NEGOtiation) is the standard way
to support Kerberos Ticket based user
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/3037
LGTM!
---
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/3004
LGTM
---
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2923
@Tagar, me & @prabhjyotsingh did discuss notebook authorization changes but
somehow I missed to include them. I committed those changes yesterday. Now
notebook authorization will als
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2923
After few more retries, only 2/11 are failing now. Just restarted them
again with the hope that those 2 will succeed too.
---
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2923
5/11 builds are still failing but due to unrelated errors. Tried restarting
failed one multiple times. All 5 are showing different errors. We can either
ignore them or fix them in separate
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2923
All Travis CI builds are failing for some npm error. Looks unrelated but
I'm not sure. I need some help in getting this through.
CC: @prabhjyotsingh @r-kamath
---
GitHub user VipinRathor reopened a pull request:
https://github.com/apache/zeppelin/pull/2923
ZEPPELIN-3312 Add option to convert username to lower case
### What is this PR for?
This PR introduces a new configuration property to convert username to
lower case. This is useful
Github user VipinRathor closed the pull request at:
https://github.com/apache/zeppelin/pull/2923
---
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2923
This can also be tested via REST APIs like this:
1. Login and get cookie as CaMel case user:
curl -iv -b /tmp/cookie -c /tmp/cookie --data
"userName=CaMel&password=passw0rd&
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2923
@prabhjyotsingh @felixcheung @zjffdu Can you please help review? Thanks.
---
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/2923
ZEPPELIN-3312 Add option to convert username to lower case
### What is this PR for?
This PR introduces a new configuration property to convert username to
lower case. This is useful when
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2550
@felixcheung Thanks for reviewing. Zeppelin, by default, should set
'HttpOnly' flag for all session cookies as security measure against XSS
attacks. That's why we have decided
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2550
@krishna-pandey You are right. Setting "secure=true" in cookie will force
cookie to travel only over HTTPS. When Zeppelin is running over HTTP, browsers
won't send this '
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/2550
[MINOR] Updated shiro.init.template to include secure cookie option
### What is this PR for?
Based on discussion in https://github.com/apache/zeppelin/pull/2545 , I'm
updatin
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2545
Thanks @krishna-pandey & @Leemoonsoo for reviewing this.
I have updated the doc as suggested by @krishna-pandey .
@Leemoonsoo I like your suggestion for updating the shiro.ini temp
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2545
@prabhjyotsingh @Leemoonsoo Please help with review.
For some context on httpOnly flag, please check
https://www.owasp.org/index.php/HttpOnly
Thanks.
---
If your project is
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/2545
ZEPPELIN-2873 - Add documentation on secure cookie in Shiro
### What is this PR for?
Adding a section in Shiro Authentication about how to enable secure cookie
via Shiro. Shiro do
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2524
Reviewed. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2515
@felixcheung @Leemoonsoo @prabhjyotsingh Please help with review and merge.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/2515
[ZEPPELIN-2825] - Fix Zeppelin to support any of the Shiro roles
### What is this PR for?
This PR adds support for such a configuration which can give access to user
who belongs to &quo
Github user VipinRathor closed the pull request at:
https://github.com/apache/zeppelin/pull/2414
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user VipinRathor reopened a pull request:
https://github.com/apache/zeppelin/pull/2414
[ZEPPELIN-2657] Add group search filter option to LdapRealm
### What is this PR for?
Problem:
While performing LDAP authentication, current Shiro module does a group=*
search while
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2414
@gss2002 & @weand,
Can you please help with review? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/2414
[ZEPPELIN-2657] Add group search filter option to LdapRealm
### What is this PR for?
Problem:
While performing LDAP authentication, current Shiro module does a group=*
search while
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2337
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2331
Thanks @felixcheung for spending time on this and approving.
> but we should fix it to lower case always just to be safe?
As per Shiro
[doc](https://shiro.apache.org/sta
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2330
@prabhjyotsingh
Thanks for reviewing this.
> any specific reason for chaning ldapRealm =
org.apache.zeppelin.realm.LdapRealm to
ldapRealm=org.apache.zeppelin.realm.LdapRealm
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/2331
[minor] Replace 'SIMPLE' auth with 'simple' auth everywhere in documents
### What is this PR for?
This PR fixes a security hole in documentation when 'SIMPLE'
GitHub user VipinRathor opened a pull request:
https://github.com/apache/zeppelin/pull/2330
[minor] Remove incorrect configuration and fix description of LdapRealm
### What is this PR for?
There is wrong description and incorrect configuration defined in comment
in
32 matches
Mail list logo
