Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2330
@prabhjyotsingh
Thanks for reviewing this.
> any specific reason for chaning ldapRealm =
org.apache.zeppelin.realm.LdapRealm to
ldapRealm=org.apache.zeppelin.realm.LdapRealm in all the lines ?
Earlier there were lines with mixed spacing, I just wanted to keep it
uniform. We can choose any one style that you want.
> I notice you have removed these two;
>
> ldapRealm.contextFactory=$ldapGroupContextFactory
> ldapRealm.contextFactory.systemAuthenticationMechanism=simple
>
> any specific reason?
Yes, if you keep the first one, Shiro will throw error that
ldapGroupContextFactory is not defined anywhere so can't be used. And in fact,
the sample configuration is actually not defining any such
ldapGroupContextFactory. Instead `LdapRealm` is using `JndiLdapContextFactory`
, so no need to override a contextFactory.
For `systemAuthenticationMechanism`, there is neither such configuration
available in `JndiLdapContextFactory` nor `LdapRealm` introduced any. Looks
like a left over from earlier configuration set, hence removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
