[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-10 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Addressed review comments and moved the dependency to npm. One jenkins job is failing but looks unrelated to my changes. I also see build is marked as failed in master, just double checking if m

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 And what I meant ux is about supporting spark's native yarn-cluster mode in Zeppelin :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 I mean 'not in case of spark'. And this implementation satisfies your needs. You can launches some interpreters like md in local mode and some interpreters in yarn. --- If your project is set u

[GitHub] zeppelin issue #2336: [MINOR] Change `case` indent

2017-05-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2336 This is minor issue and CI failure isn't related to this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2329 > it's improve users' experiences Sorry, I don't understand how it improve users' experience compared the native spark yarn-cluster support. And does this approach mean all the interpreter must

[GitHub] zeppelin pull request #2336: [MINOR] Change `case` indent

2017-05-10 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/2336 [MINOR] Change `case` indent ### What is this PR for? Changing style in case of 'case'. Zeppelin has two spaces as default indentation but checkstyle has different style of 'case'.

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 It makes our logic much difficult, but it's improve users' experiences. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 In case of Spark, it has two yarn apps. I agree that it's a bit weird for users. Otherwise, all other interpreters like python get better to launch it in yarn cluster. I think it would be better

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2329 Do you mean there would be 2 yarn apps for launching one spark interpreter ? That looks a little weird to me. In this approach, we still launch remote interpreter process in the zeppelin host, that

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread guptarajat
Github user guptarajat commented on the issue: https://github.com/apache/zeppelin/pull/2323 "all these things are persisted and synchronized among web socket clients" What does this mean? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2268 @Leemoonsoo the separation discussed above in the comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 @zjffdu Thanks for quick review. I know spark already have yarn-cluster by itself. In case of Zeppelin, SparkInterpreter will run yarn-client mode which means driver is still in a process zeppeli

[GitHub] zeppelin issue #2335: [ZEPPELIN-2426] Improve graph setting DOMs

2017-05-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2335 CI failed but irrelevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] zeppelin issue #2333: Notebook: (Web) HDFS as a backend storage (Read & Writ...

2017-05-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2333 I don't think it's good idea to include some interpreters as dependencies onto zeppelin-zengine. --- If your project is set up for it, you can reply to this email and have your reply appear on G

Re: What is the user case for remote of interpreter option is false

2017-05-10 Thread Jeff Zhang
ClassloaderInterpreter could also be removed. Jeff Zhang 于2017年5月10日周三 下午3:39写道: > > Hi moon > > Considering we use remote=true for interpreters now, and seems no user > complain about that. So I think we could remove it completely. Agree with > you that It could make code simpler, e.g. We don't

Re: What is the user case for remote of interpreter option is false

2017-05-10 Thread Jeff Zhang
Hi moon Considering we use remote=true for interpreters now, and seems no user complain about that. So I think we could remove it completely. Agree with you that It could make code simpler, e.g. We don't need to check to use RemoteAngularObjectRegistry or AngularObjectRegistry. https://github.com

[GitHub] zeppelin issue #2272: ZEPPELIN-2397. Add toJson and fromJson method for seri...

2017-05-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2272 @felixcheung toJson and fromJson is used in both zeppelin-interpreter and zeppelin-zengine. I didn't find a proper place to put the common interface. And actually the interface doesn't not eliminat

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

2017-05-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2334 @FireArrow Could you help check the failed test ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2335: [ZEPPELIN-2426] Improve graph setting DOMs

2017-05-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2335 CI script can't parse `=` in the branch name. - https://travis-ci.org/1ambda/zeppelin/builds/230940304 --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] zeppelin pull request #2335: [ZEPPELIN-2426] Improve graph setting DOMs

2017-05-10 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2335 [ZEPPELIN-2426] Improve graph setting DOMs ### What is this PR for? Improve graph setting DOMs. Refer the attached screenshots. ### What type of PR is it? [Improvement]

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2268 This PR adds two new field 'widget' and 'type' to each properties. 'widget' : input, checkbox, textarea, password 'type' : number, string, boolean, url, password How about j

[jira] [Created] (ZEPPELIN-2529) Create Base class for spark interpreter

2017-05-10 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2529: Summary: Create Base class for spark interpreter Key: ZEPPELIN-2529 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2529 Project: Zeppelin Issue Type: Im

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 Here's few feedbacks. 1. Table does not refreshed after height / width of paragraph change. TBD 2. How about remove 'type' in column table option? - Removed -

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2268 As far as I Know, Zeppelin supports backward compatibility even for interpreter settings. - I think we need some migration code w/ documentation --- If your project is set up for it, you

[GitHub] zeppelin issue #2330: [minor] Remove incorrect configuration and fix descrip...

2017-05-10 Thread VipinRathor
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2330 @prabhjyotsingh Thanks for reviewing this. > any specific reason for chaning ldapRealm = org.apache.zeppelin.realm.LdapRealm to ldapRealm=org.apache.zeppelin.realm.LdapRealm in a

[jira] [Created] (ZEPPELIN-2528) Add a password text input to the ZeppelinContext

2017-05-10 Thread Benjamin Vogan (JIRA)
Benjamin Vogan created ZEPPELIN-2528: Summary: Add a password text input to the ZeppelinContext Key: ZEPPELIN-2528 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2528 Project: Zeppelin

[jira] [Created] (ZEPPELIN-2527) Cursor in editor is too thick

2017-05-10 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2527: Summary: Cursor in editor is too thick Key: ZEPPELIN-2527 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2527 Project: Zeppelin Issue Type: Improvement

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

2017-05-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2334 Right, we could do it in another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

2017-05-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2329 @jongyoul Thanks for the POC. One question about the cluster mode for spark interpreter. It looks like you are creating a general yarn app support for all the interpreters. But for spark, it has al

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2268 @1ambda i wrote about migration in upgrade.md. I'll see Notebook.java if the documentation is not enough --- If your project is set up for it, you can reply to this email and have your r

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

2017-05-10 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2334 @zjffdu I agree. A also noticed there are plenty of sketchy `synchrnoized`-blocks that doesn't really work as intended. But that's a refactor for another PR --- If your project is set up for i

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

2017-05-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2334 LGTM, BTW for a long term solution, I think we should initialize `ZeppelinContext` properly (including set `InterpreterContext`) in some base class instead of initialize in each interpreter manuall

[GitHub] zeppelin pull request #2334: [HOTFIX] Set interpreter context in zeppelin co...

2017-05-10 Thread FireArrow
GitHub user FireArrow opened a pull request: https://github.com/apache/zeppelin/pull/2334 [HOTFIX] Set interpreter context in zeppelin context from SparkSqlInterpreter ### What is this PR for? When running %sql paragraphs the query is dispatched to the cluster, but when it's ti

[GitHub] zeppelin issue #1600: Using HDFS to backup and restore notebook

2017-05-10 Thread aspen01
Github user aspen01 commented on the issue: https://github.com/apache/zeppelin/pull/1600 @EronWright Thank you for your feedback. When I first developed the feature, I assumed that HDFS would not be used as default storage because remote FS failure could affect zeppelin usage. So ext

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 Tested and overall it's great improvement! Here's few feedbacks. 1. Table does not refreshed after height / width of paragraph change. 2. How about remove 'type' in column t

[GitHub] zeppelin pull request #1479: Notebook: HDFS as a backend storage (Read & Wri...

2017-05-10 Thread hayssams
Github user hayssams closed the pull request at: https://github.com/apache/zeppelin/pull/1479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1479: Notebook: HDFS as a backend storage (Read & Write Mode...

2017-05-10 Thread hayssams
Github user hayssams commented on the issue: https://github.com/apache/zeppelin/pull/1479 Replaced by PR #2333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #2333: Notebook: (Web) HDFS as a backend storage (Read...

2017-05-10 Thread hayssams
GitHub user hayssams opened a pull request: https://github.com/apache/zeppelin/pull/2333 Notebook: (Web) HDFS as a backend storage (Read & Write Mode) ### What is this PR for ? This PR replaces the PR-1479 by removing any hadoop dependency using WEBHDFS as a communication protoc

[GitHub] zeppelin pull request #2332: WebHDFS Support

2017-05-10 Thread hayssams
Github user hayssams closed the pull request at: https://github.com/apache/zeppelin/pull/2332 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (ZEPPELIN-2526) NotebookSecurityRestApiTest fails with http 302 response

2017-05-10 Thread Pravin Dsilva (JIRA)
Pravin Dsilva created ZEPPELIN-2526: --- Summary: NotebookSecurityRestApiTest fails with http 302 response Key: ZEPPELIN-2526 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2526 Project: Zeppelin

[GitHub] zeppelin pull request #2332: WebHDFS Support

2017-05-10 Thread hayssams
GitHub user hayssams opened a pull request: https://github.com/apache/zeppelin/pull/2332 WebHDFS Support You can merge this pull request into a Git repository by running: $ git pull https://github.com/ebiznext/incubator-zeppelin WEBHDFS Alternatively you can review and apply

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2268 Sorry for the late review. seems that it doesn't work with existing settings. Even can't start Zeppelin instance. ``` Caused by: java.lang.ClassCastException: java.lang.String

[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...

2017-05-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2300 even though CI is green in this PR, it seems that wasn't rebased recently. As a result CI is failing only in the second travis JOB. @AlexanderShoshin Could you check that? --- If your project is

[GitHub] zeppelin issue #2330: [minor] Remove incorrect configuration and fix descrip...

2017-05-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2330 Also, I notice you have removed these two; - ldapRealm.contextFactory=$ldapGroupContextFactory - ldapRealm.contextFactory.systemAuthenticationMechanism=simple any specific

[GitHub] zeppelin issue #2330: [minor] Remove incorrect configuration and fix descrip...

2017-05-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2330 @VipinRathor any specific reason for chaning `ldapRealm = org.apache.zeppelin.realm.LdapRealm` to `ldapRealm=org.apache.zeppelin.realm.LdapRealm` in all the lines ? --- If your project is

[GitHub] zeppelin pull request #2331: [minor] Replace 'SIMPLE' auth with 'simple' aut...

2017-05-10 Thread VipinRathor
GitHub user VipinRathor opened a pull request: https://github.com/apache/zeppelin/pull/2331 [minor] Replace 'SIMPLE' auth with 'simple' auth everywhere in documents ### What is this PR for? This PR fixes a security hole in documentation when 'SIMPLE' authentication mechanism is

[GitHub] zeppelin pull request #2330: [minor] Remove incorrect configuration and fix ...

2017-05-10 Thread VipinRathor
GitHub user VipinRathor opened a pull request: https://github.com/apache/zeppelin/pull/2330 [minor] Remove incorrect configuration and fix description of LdapRealm ### What is this PR for? There is wrong description and incorrect configuration defined in comment in LdapRealm.jav

[jira] [Created] (ZEPPELIN-2525) How to integrate zeppelin in java project

2017-05-10 Thread Srikanth Kedari (JIRA)
Srikanth Kedari created ZEPPELIN-2525: - Summary: How to integrate zeppelin in java project Key: ZEPPELIN-2525 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2525 Project: Zeppelin Is

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-10 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 I checked Jenkins Job. The sub job failing is https://travis-ci.org/vipul1409/zeppelin/jobs/230634157 It is failing because of some git access issues. Any suggestions on what could be the issue?