[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.p

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1775 @khalidhuseynov Thanks for your consideration! Tested again and it works well as we said :) And there is one minor thing in lookandfeel setting menu. Is this intended behavior? - Head

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-30 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1775 @AhyoungRyu I think it makes sense and addressed your feedback. please check it out and let me know if it's fine. --- If your project is set up for it, you can reply to this email and hav

[GitHub] zeppelin issue #1827: [ZEPPELIN-1878] added npm-debug.log on gitignore

2016-12-30 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1827 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

2016-12-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1716 Tested and LGTM. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin pull request #1721: [ZEPPELIN-969] order by note name in job menu

2016-12-30 Thread cloverhearts
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/1721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] zeppelin pull request #1721: [ZEPPELIN-969] order by note name in job menu

2016-12-30 Thread cloverhearts
GitHub user cloverhearts reopened a pull request: https://github.com/apache/zeppelin/pull/1721 [ZEPPELIN-969] order by note name in job menu ### What is this PR for? we can sort by note name in job menu. Sorting supports ascending and descending order. Sort by note name.

[GitHub] zeppelin pull request #1827: [ZEPPELIN-1878] added npm-debug.log on gitignor...

2016-12-30 Thread cloverhearts
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/1827 [ZEPPELIN-1878] added npm-debug.log on gitignore ### What is this PR for? zeppelin-web/npm-debug.log file is only used debugging. So, we do not tracking. ### What type of PR

[jira] [Created] (ZEPPELIN-1878) add ignore file npm-debug.log on gitignore

2016-12-30 Thread CloverHearts (JIRA)
CloverHearts created ZEPPELIN-1878: -- Summary: add ignore file npm-debug.log on gitignore Key: ZEPPELIN-1878 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1878 Project: Zeppelin Issue T

[GitHub] zeppelin issue #1817: remove usage of non-standard string method

2016-12-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1817 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #1810: [MINOR] Fix navbar layout misalignment

2016-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1810 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

2016-12-30 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1716 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] zeppelin pull request #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Supp...

2016-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1757 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1757 CI failure is not related with this change and already reported in [ZEPPELIN-1857](https://issues.apache.org/jira/browse/ZEPPELIN-1857). So I'm merging this now :) --- If your project is set

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1775 @khalidhuseynov >since they're still not able to run or edit Yes you're right. I just thought it's not common sense as you told. Since the user can't run or edit anyway, but he can

[GitHub] zeppelin pull request #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInt...

2016-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1826: [WIP][ZEPPELIN-1859] Add MongoNotebookRepo

2016-12-30 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1826 [WIP][ZEPPELIN-1859] Add MongoNotebookRepo ### What is this PR for? This PR adds Mongo notebook storage. The reason that I made this feature is for HA(High Availability). S3 and G

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-30 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks for considering my suggestion, @tae-jun 😄 It is good idea and I agree with you! I think this problem is a little too hard to solve. So, anyway, I will test again! --- If yo

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.p

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks for the review, @soralee! That was a big deal. I pushed a commit and now it looks like this: https://cloud.githubusercontent.com/assets/8201019/21564175/bc5fc4c2-cecd-11e6-88dd-d

[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...

2016-12-30 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1813 Tested and It works as expected like below!! [Before] ![z_1813_b](https://cloud.githubusercontent.com/assets/8110458/21563310/650e0eb2-cec4-11e6-845b-0a028ddd1755.png) [After]

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-30 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1775 @AhyoungRyu actually i thought about it and couldn't find a reason why not let user change "Interpreter bindings" and "Note permissions" even in read-only mode, since they're still not able

[GitHub] zeppelin issue #1817: remove usage of non-standard string method

2016-12-30 Thread felizbear
Github user felizbear commented on the issue: https://github.com/apache/zeppelin/pull/1817 I've retriggered CI a few times. Current error is ``` Failed tests: NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 expected: but was: ``` obvi

[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...

2016-12-30 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1813 @astroshim It's great work! I will test it! But, I would like to suggest one thing. According to what I understand, your screenshot and `Then you can see the login button like as screen shot.`

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

2016-12-30 Thread felizbear
Github user felizbear closed the pull request at: https://github.com/apache/zeppelin/pull/1817 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

2016-12-30 Thread felizbear
GitHub user felizbear reopened a pull request: https://github.com/apache/zeppelin/pull/1817 remove usage of non-standard string method ### What is this PR for? Recreating #1701 that was lost in refactoring. This PR removes a non-standard string prototype method `contains` tha

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1757 @lresende Looks good 👍 Merge this into master if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

2016-12-30 Thread felizbear
Github user felizbear closed the pull request at: https://github.com/apache/zeppelin/pull/1817 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

2016-12-30 Thread felizbear
GitHub user felizbear reopened a pull request: https://github.com/apache/zeppelin/pull/1817 remove usage of non-standard string method ### What is this PR for? Recreating #1701 that was lost in refactoring. This PR removes a non-standard string prototype method `contains` tha