[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

Fri, 30 Dec 2016 23:27:05 -0800 

GitHub user tae-jun reopened a pull request:

    https://github.com/apache/zeppelin/pull/1730

    [ZEPPELIN-1736] Introduce trash & enable removing folder

    ### What is this PR for?
    
![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
    This PR introduces the trash! (which is essential, I think ^^;)
    
    I added basic operations of the trash:
    #### Added operations of trash
    * `Move` a folder to the trash
    * `Move` a note to the trash
    * `Restore` a folder
    * `Restore` a note
    * `Remove` a folder in the trash for good
    * `Remove` a note in the trash for good
    * `Empty` the trash
    * `Restore all` in the trash
    * `Move` a note to the trash from the notebook view
    * `Remove` a note to the trash for good from the notebook view
    * If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)
    
    
    ### What type of PR is it?
    [Feature]
    
    ### Future work
    Maybe it would be better if notebook view notices that a note is in the 
trash.
    
    ### What is the Jira issue?
    [ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)
    
    ### How should this be tested?
    * Build this PR
    * Move some folders or notes to the trash
    * Restore them
    * Empty the trash
    * Restore all notes in the trash
    * Remove folders or notes in the trash
    * Remove a folder which has the same folder name in the trash
    
    ### Screenshots (if appropriate)
    ## Move, restore, remove a note from the main page
    
![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)
    
    ## Move, restore, remove a folder from the main page
    
![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)
    
    ## Move, remove a note from the notebook view
    
![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)
    
    ## Restore, empty the trash
    
![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)
    
    ## Suffix current date if the folder exists in the trash
    
![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1730
    
----
commit 94407574e4182f93dfd9dce39e7e63fde824e461
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-06T11:21:38Z

    Introduce trash & removing folder

commit 1a2a7c5a719a3127720c40cdbafe054008200988
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-06T12:54:54Z

    Satisfy style check

commit 423748811b1a56f4ed4df0950aa8b30f89cd7927
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-06T12:55:19Z

    Remove if note is in the trash from the notebook view

commit 51cc60de3c709a2c7bc45cd8713521c87738d5aa
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-07T17:12:51Z

    Use trash folder id provided by constant service

commit eb2d64b82afb260933f6f1d0ee59388eeece47bf
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-07T17:14:00Z

    Change “for good” -> “permanently”

commit da00e3cc0db8ef896706f9a2263c929bc1cd929a
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-07T17:15:51Z

    Make the order of the trash folder last

commit 6ddeeb729e97f8408504627f26caa2ffdcbeee59
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-08T15:28:15Z

    Restore a folder without removed date

commit beaf265ac1eef802588d42cc5967323bfdbe96ff
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-08T15:42:26Z

    Define isTrash function on notebook controller

commit 35aca48d83ec971068aab63a8e222feb269ab5e2
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-08T15:59:10Z

    Define notebook list button style

commit e627ae7eee7cfc93585c0d438d5822daa11e6d1d
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-08T16:03:39Z

    Fix stylecheck issue

commit dd1f506ae8e7617ec257b52634540a44e4f0159f
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-11T13:52:14Z

    Fix white space bug @marchpig addressed

commit 0f10bb59384c81bfd0b2c73122d1188dd670e776
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-11T14:07:37Z

    Change selenium test codes affected by chaging ‘removeNote’ button to 
‘moveToTrash’

commit 8b9068db9833f4e5cb5a77ad7c092d9d90cefdb9
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-17T12:38:45Z

    Change remove permanently icons, remove folder conflict infix

commit 44bea67293ec81ddbf3b5b673524e468ec5df5da
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-22T15:04:59Z

    Show trash folder icon at navbar

commit 91745f3ea89a9a35e5d67d5a3e76ce672e9f6d58
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-22T17:18:41Z

    Hide rename, clear output buttons

commit 650797e5afe15c29b22939e55cddc112c33e0b9b
Author: Jun Kim <i2r....@gmail.com>
Date:   2016-12-30T11:20:21Z

    show trash icon after searching notes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to