Re: OrgChart tool code review / proposed changes

2017-06-11 Thread Shane Curcuru
Deployed: https://whimsy.apache.org/foundation/orgchart/secretary Please test a few links before I publicize this elsewhere. 8-) Craig, please review and make any changes to officers/personnel-duties/secretary.txt if anything there should be in a [private] section instead. -- - Shane https:/

Re: OrgChart tool code review / proposed changes

2017-06-09 Thread Sam Ruby
On Fri, Jun 9, 2017 at 3:24 PM, Shane Curcuru wrote: >> >>> * TODO: deprecate www/roster/models/orgchart.rb in favor of >>> lib/whimsy/asf/orgchart.rb >> >> What do you propose for private fields? Sorry, I read too quickly. I was thinking you were suggesting deprecating the roster orgchart in fa

Re: OrgChart tool code review / proposed changes

2017-06-09 Thread Shane Curcuru
Sam Ruby wrote on 6/9/17 11:46 AM: > On Fri, Jun 9, 2017 at 11:02 AM, Shane Curcuru wrote: >> In building the public-orgchart branch, I'd like to ask: >> >> * whimsy.a.o/orgchart or whimsy.a.o/docs/orgchart or >> whimsy.a.o/foundation/orgchart ? > > I prefer more specific (foundation) over generi

Re: OrgChart tool code review / proposed changes

2017-06-09 Thread Sam Ruby
On Fri, Jun 9, 2017 at 11:02 AM, Shane Curcuru wrote: > In building the public-orgchart branch, I'd like to ask: > > * whimsy.a.o/orgchart or whimsy.a.o/docs/orgchart or > whimsy.a.o/foundation/orgchart ? I prefer more specific (foundation) over generic (docs). > * For a code review of some part

OrgChart tool code review / proposed changes

2017-06-09 Thread Shane Curcuru
In building the public-orgchart branch, I'd like to ask: * whimsy.a.o/orgchart or whimsy.a.o/docs/orgchart or whimsy.a.o/foundation/orgchart ? * For a code review of some parts before we merge to master: https://github.com/apache/whimsy/blob/public-orgchart/www/docs/orgchart.cgi#L66 Since this