In building the public-orgchart branch, I'd like to ask:

* whimsy.a.o/orgchart or whimsy.a.o/docs/orgchart or
whimsy.a.o/foundation/orgchart ?

* For a code review of some parts before we merge to master:


https://github.com/apache/whimsy/blob/public-orgchart/www/docs/orgchart.cgi#L66
Since this cgi will publicly expose bits of formerly private data in
foundation/officers/personnel-duties, can someone double-check that
fields marked 'private' in the .yamls won't leak?


https://github.com/apache/whimsy/blob/public-orgchart/lib/whimsy/asf/orgchart.rb#L13
Since this is a private repo, is there anything else we explicitly need
to check before .untaint in this class?


https://github.com/apache/whimsy/blob/public-orgchart/www/docs/orgchart.cgi#L129
Why doesn't my use of _markdown work, when it seems identical to the one
in www/roster/views/duties.html.rb?

* Consider changing some of the personnel-duties data structure:

- The [info] id: field should really be a list, not a string - this
allows the board and infra-staff groups to properly reflect they are
groups of committers, not single individuals.  Any objections?

* TODO: deprecate www/roster/models/orgchart.rb in favor of
lib/whimsy/asf/orgchart.rb

-- 

- Shane
  https://www.apache.org/foundation/marks/resources

Reply via email to