Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-26 Thread Sam Ruby
On Sun, Jul 25, 2021 at 7:40 PM Craig Russell wrote: > > > On Jul 25, 2021, at 2:06 PM, sebb wrote: > > > > AFAICT the code cannot have been tested -- previously it did not even > > compile, and there was a missing method. > > You are completely correct. I made the decision not to invest the few

Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-25 Thread sebb
On Mon, 26 Jul 2021 at 00:40, Craig Russell wrote: > > > > > On Jul 25, 2021, at 2:06 PM, sebb wrote: > > > > On Sun, 25 Jul 2021 at 19:32, Craig Russell > > wrote: > >> > >> Hi Sebb, > >> > >>> On Jul 25, 2021, at 2:55 AM, sebb wrote: > >>> > >>> On Sat, 24 Jul 202

Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-25 Thread Craig Russell
> On Jul 25, 2021, at 2:06 PM, sebb wrote: > > On Sun, 25 Jul 2021 at 19:32, Craig Russell > wrote: >> >> Hi Sebb, >> >>> On Jul 25, 2021, at 2:55 AM, sebb wrote: >>> >>> On Sat, 24 Jul 2021 at 23:46, Craig Russell wrote: Hi Sebb, Thanks

Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-25 Thread sebb
On Sun, 25 Jul 2021 at 19:32, Craig Russell wrote: > > Hi Sebb, > > > On Jul 25, 2021, at 2:55 AM, sebb wrote: > > > > On Sat, 24 Jul 2021 at 23:46, Craig Russell wrote: > >> > >> Hi Sebb, > >> > >> Thanks for the review. > >> > >> Do you see any harm in merging this branch? > > > > Yes, there a

Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-25 Thread Craig Russell
Hi Sebb, > On Jul 25, 2021, at 2:55 AM, sebb wrote: > > On Sat, 24 Jul 2021 at 23:46, Craig Russell wrote: >> >> Hi Sebb, >> >> Thanks for the review. >> >> Do you see any harm in merging this branch? > > Yes, there are no tests. News to me. Where are the tests for the icla panel? Thanks,

Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-25 Thread sebb
On Sat, 24 Jul 2021 at 23:46, Craig Russell wrote: > > Hi Sebb, > > Thanks for the review. > > Do you see any harm in merging this branch? Yes, there are no tests. > I'd like to see it in action... > > Thanks, > > Craig > > > On Jul 24, 2021, at 3:27 PM, s...@apache.org wrote: > > > > This is an

Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-24 Thread Craig Russell
Hi Sebb, Thanks for the review. Do you see any harm in merging this branch? I'd like to see it in action... Thanks, Craig > On Jul 24, 2021, at 3:27 PM, s...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a commit to branch family-f