On Sat, 24 Jul 2021 at 23:46, Craig Russell <apache....@gmail.com> wrote: > > Hi Sebb, > > Thanks for the review. > > Do you see any harm in merging this branch?
Yes, there are no tests. > I'd like to see it in action... > > Thanks, > > Craig > > > On Jul 24, 2021, at 3:27 PM, s...@apache.org wrote: > > > > This is an automated email from the ASF dual-hosted git repository. > > > > sebb pushed a commit to branch family-first > > in repository https://gitbox.apache.org/repos/asf/whimsy.git > > > > > > The following commit(s) were added to refs/heads/family-first by this push: > > new 9a297b3 Fix obvious errors > > 9a297b3 is described below > > > > commit 9a297b38f1a77b908e939e341248b7a8cd8808b1 > > Author: Sebb <s...@apache.org> > > AuthorDate: Sat Jul 24 23:27:37 2021 +0100 > > > > Fix obvious errors > > > > - spurious trailing ) > > - duplicate function name > > --- > > www/secretary/workbench/views/forms/icla.js.rb | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/www/secretary/workbench/views/forms/icla.js.rb > > b/www/secretary/workbench/views/forms/icla.js.rb > > index 4a893a3..656a854 100644 > > --- a/www/secretary/workbench/views/forms/icla.js.rb > > +++ b/www/secretary/workbench/views/forms/icla.js.rb > > @@ -258,7 +258,7 @@ class ICLA < Vue > > end > > > > # generate file name from the real name > > - def genfilename(realname, familyfirst)) > > + def genfilename(realname, familyfirst) > > nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-') > > if !familyfirst > > return nominalname > > @@ -280,7 +280,7 @@ class ICLA < Vue > > end > > > > # generate LDAP givenName from public name > > - def genldapsn(pnamearray, ffirst) > > + def genldapgivenname(pnamearray, ffirst) > > if ffirst > > return pnamearray[-1] > > else > > Craig L Russell > c...@apache.org >
